[login_manager] Enable hang detection on non-developer-user ... [chromiumos/platform/login_manager : master]

3 views
Skip to first unread message

Chris Masone (Code Review)

unread,
Nov 19, 2012, 7:58:48 PM11/19/12
to
Chris Masone has uploaded a new change for review.

Change subject: [login_manager] Enable hang detection on non-developer-user images.
......................................................................

[login_manager] Enable hang detection on non-developer-user images.

If a device does not have a developer end-user, enable hang detection.

Also allow a magic file to enable it with a shorter interval, for testing.

BUG=chromium-os:35729
TEST=boot in a VM, run 'pkill -STOP -o "^chrome$"'. Then watch /var/log/messages to see that

Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
---
M session_manager_setup.sh
1 file changed, 15 insertions(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/login_manager refs/changes/45/38345/1
--
To view, visit https://gerrit.chromium.org/gerrit/38345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
Nov 19, 2012, 8:03:57 PM11/19/12
to Gerrit
Chris Masone has posted comments on this change.

Change subject: [login_manager] Enable hang detection on non-developer-user images.
......................................................................


Patch Set 2: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/38345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Chris Masone (Code Review)

unread,
Nov 19, 2012, 8:06:18 PM11/19/12
to Gerrit, Daniel Erat
Chris Masone has posted comments on this change.

Change subject: [login_manager] Enable hang detection on non-developer-user images.
......................................................................


Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/38345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Daniel Erat <de...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Daniel Erat (Code Review)

unread,
Nov 19, 2012, 8:15:39 PM11/19/12
to Chris Masone, Gerrit
Daniel Erat has posted comments on this change.

Change subject: [login_manager] Enable hang detection on non-developer-user images.
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/38345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
Nov 20, 2012, 1:00:47 PM11/20/12
to Gerrit, Daniel Erat
Chris Masone has posted comments on this change.

Change subject: [login_manager] Enable hang detection on non-developer-user images.
......................................................................


Patch Set 5: Verified; Looks good to me, approved; Ready

inheriting LGTM

--
To view, visit https://gerrit.chromium.org/gerrit/38345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied5c9e897485aaf75fdefd211445219712972bdf
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/platform/login_manager
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Reply all
Reply to author
Forward
0 new messages