CHROMIUM: config: enable exynos5420 support [chromiumos/third_party/kernel-next : chromeos-3.8]

1 view
Skip to first unread message

Andrew Bresticker (Code Review)

unread,
May 23, 2013, 11:41:45 PM5/23/13
to Simon Glass, Doug Anderson, Olof Johansson
Hello Simon Glass, Doug Anderson,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/56562

to review the following change.

Change subject: CHROMIUM: config: enable exynos5420 support
......................................................................

CHROMIUM: config: enable exynos5420 support

This enables support for the Exynos 5420 SoC.

BUG=chrome-os-partner:19007
TEST=Builds

Change-Id: I0ea217f8b3c2c01fe3b48834006475a7818d83b3
Signed-off-by: Andrew Bresticker <abre...@chromium.org>
---
M chromeos/config/armel/chromeos-exynos5.flavour.config
1 file changed, 1 insertion(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/62/56562/1

diff --git a/chromeos/config/armel/chromeos-exynos5.flavour.config b/chromeos/config/armel/chromeos-exynos5.flavour.config
index d4f601b..442c02b 100644
--- a/chromeos/config/armel/chromeos-exynos5.flavour.config
+++ b/chromeos/config/armel/chromeos-exynos5.flavour.config
@@ -262,6 +262,7 @@
CONFIG_SND_SOC_WM8994=y
CONFIG_SND_SOC_WM_HUBS=y
CONFIG_SOC_EXYNOS5250=y
+CONFIG_SOC_EXYNOS5420=y
# CONFIG_SOC_EXYNOS5440 is not set
# CONFIG_SOFT_WATCHDOG is not set
CONFIG_SPARSEMEM=y

--
To view, visit https://gerrit.chromium.org/gerrit/56562
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ea217f8b3c2c01fe3b48834006475a7818d83b3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Doug Anderson (Code Review)

unread,
May 23, 2013, 11:54:08 PM5/23/13
to Andrew Bresticker, ChromeBot, Simon Glass
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: config: enable exynos5420 support
......................................................................


Patch Set 1: Looks good to me, approved; Verified

Right. This is actually just a config normalization since default is to have this on. Nice to have it in, though. Thanks!

I've verified this too, so marking so. Hit ready any time. :)

--
To view, visit https://gerrit.chromium.org/gerrit/56562
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea217f8b3c2c01fe3b48834006475a7818d83b3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>

Andrew Bresticker (Code Review)

unread,
May 23, 2013, 11:54:48 PM5/23/13
to ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has posted comments on this change.

Change subject: CHROMIUM: config: enable exynos5420 support
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/56562
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea217f8b3c2c01fe3b48834006475a7818d83b3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>

Andrew Bresticker (Code Review)

unread,
May 24, 2013, 1:57:33 AM5/24/13
to ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has abandoned this change.

Change subject: CHROMIUM: config: enable exynos5420 support
......................................................................


Patch Set 2: Abandoned

Looks like someone else beat me to it.

--
To view, visit https://gerrit.chromium.org/gerrit/56562
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I0ea217f8b3c2c01fe3b48834006475a7818d83b3
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Reply all
Reply to author
Forward
0 new messages