shill: Increase timeout when calling modem Enable command in... [chromiumos/platform/shill : master]

0 views
Skip to first unread message

Thieu Le (Code Review)

unread,
May 15, 2012, 5:32:58 PM5/15/12
to
Thieu Le has uploaded a new change for review.

Change subject: shill: Increase timeout when calling modem Enable command in DisableModem().
......................................................................

shill: Increase timeout when calling modem Enable command in DisableModem().

BUG=chromium-os:30933
TEST=Unit test, network_3GModemControl

Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
---
M cellular_capability_classic.cc
M cellular_capability_classic_unittest.cc
M cellular_unittest.cc
3 files changed, 4 insertions(+), 4 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/shill refs/changes/48/22748/1
--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Gary Morain (Code Review)

unread,
May 15, 2012, 5:43:21 PM5/15/12
to Thieu Le, Jason Glasgow
Gary Morain has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable command in DisableModem().
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>
Gerrit-Reviewer: Gary Morain <gmo...@chromium.org>
Gerrit-Reviewer: Jason Glasgow <jgla...@chromium.org>

Jason Glasgow (Code Review)

unread,
May 16, 2012, 10:04:30 AM5/16/12
to Thieu Le, Gary Morain
Jason Glasgow has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable command in DisableModem().
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 12:44:39 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable command in DisableModem().
......................................................................


Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>
Gerrit-Reviewer: Gary Morain <gmo...@chromium.org>
Gerrit-Reviewer: Jason Glasgow <jgla...@chromium.org>
Gerrit-Reviewer: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 4:05:13 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable.
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

Clean rebase, inheriting LGTM.

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 4:11:03 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable.
......................................................................


Patch Set 3: Verified; Looks good to me, approved; Ready

Rebased for real this time :)

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 5:03:21 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable.
......................................................................


Patch Set 3: Ready

Unit test in chromeos-ec failed, not shill related.

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 5:23:15 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable.
......................................................................


Patch Set 3: Ready

Once again

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 6:09:26 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: shill: Increase timeout when calling modem Enable.
......................................................................


Patch Set 3: Ready

Trying again, maybe petkov's CL caused shill unit test to fail?

--
To view, visit https://gerrit.chromium.org/gerrit/22748
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0574ba9bd12462d09a24502de1c04b3e6296d3e5
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>
Reply all
Reply to author
Forward
0 new messages