Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   10 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Dylan Reid (Code Review)  
View profile  
 More options Apr 20 2012, 2:31 pm
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Fri, 20 Apr 2012 11:31:57 -0700
Local: Fri, Apr 20 2012 2:31 pm
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has uploaded a new change for review.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

UPSTREAM: ALSA: Introduce common helper functions for jack-detection control

Now move the helper function for creating and reporting the jack-detection
to the common place.  The driver that needs this functionality should
select CONFIG_SND_KCTL_JACK kconfig.

BUG=chromium-os:20620
TEST=Manual, run kernel on stumpy and check for JACK controls.

Signed-off-by: Takashi Iwai <ti...@suse.de>
(cherry picked from commit 35be544af367170a9c6bf63adcf9d0cb2d569dbb)
Signed-off-by: Dylan Reid <dgr...@chromium.org>

Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
---
M include/sound/control.h
M sound/core/Kconfig
M sound/core/Makefile
A sound/core/ctljack.c
M sound/pci/hda/Kconfig
M sound/pci/hda/hda_jack.c
M sound/pci/hda/hda_jack.h
7 files changed, 76 insertions(+), 49 deletions(-)

  git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/18/20718/1
--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Todd Broch (Code Review)  
View profile  
 More options Apr 26 2012, 4:13 pm
From: "Todd Broch (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 13:13:14 -0700
Local: Thurs, Apr 26 2012 4:13 pm
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Todd Broch has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 26 2012, 9:28 pm
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 18:28:14 -0700
Local: Thurs, Apr 26 2012 9:28 pm
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 2: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 26 2012, 11:44 pm
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 20:44:01 -0700
Local: Thurs, Apr 26 2012 11:44 pm
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 3: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 1:02 am
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 22:02:03 -0700
Local: Fri, Apr 27 2012 1:02 am
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 4: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 1:48 am
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 22:48:12 -0700
Local: Fri, Apr 27 2012 1:48 am
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 5: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 2:24 am
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 23:24:00 -0700
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 5: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 4:31 am
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Fri, 27 Apr 2012 01:31:13 -0700
Local: Fri, Apr 27 2012 4:31 am
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 6: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 11:38 am
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Fri, 27 Apr 2012 08:38:28 -0700
Local: Fri, Apr 27 2012 11:38 am
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 6: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Dylan Reid (Code Review)  
View profile  
 More options Apr 27 2012, 4:26 pm
From: "Dylan Reid (Code Review)" <ger...@chromium.org>
Date: Fri, 27 Apr 2012 13:26:18 -0700
Local: Fri, Apr 27 2012 4:26 pm
Subject: UPSTREAM: ALSA: Introduce common helper functions for jack-d... [chromiumos/third_party/kernel : chromeos-3.2]
Print | Individual message | Show original | Find messages by this author
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: Introduce common helper functions for jack-detection control
......................................................................

Patch Set 8: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20718
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If33dc63b6ec9755bb9bd76a43b72cfbe15346af2
Gerrit-PatchSet: 8
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google