newbitmaps: Get rid of ImageMagick and use PIL for image pro... [chromiumos/platform/vboot_reference : master]

2 views
Skip to first unread message

Hung-Te Lin (Code Review)

unread,
Nov 14, 2012, 2:13:12 AM11/14/12
to Dave Parker, Bill Richardson
Hello Dave Parker, Bill Richardson,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37985

to review the following change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................

newbitmaps: Get rid of ImageMagick and use PIL for image processing.

To allow building bitmaps inside chroot, we need to get rid of dependency for
ImageMagick, which is now entirely replaceable by Python Image Library.

BRANCH=none
BUG=none
TEST=make # pass

Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
---
M scripts/newbitmaps/Makefile
M scripts/newbitmaps/README
M scripts/newbitmaps/images/make_default_yaml
M scripts/newbitmaps/strings/build_font
M scripts/newbitmaps/strings/localized_text/build_message
M scripts/newbitmaps/strings/text_to_png
6 files changed, 10 insertions(+), 13 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/vboot_reference refs/changes/85/37985/1
--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 14, 2012, 2:16:34 AM11/14/12
to Gerrit, Bill Richardson, Dave Parker
Hung-Te Lin has posted comments on this change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................


Patch Set 1: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 14, 2012, 6:57:15 AM11/14/12
to Gerrit, Bill Richardson, Dave Parker
Hung-Te Lin has posted comments on this change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................


Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 14, 2012, 7:21:23 AM11/14/12
to Gerrit, Bill Richardson, Dave Parker
Hung-Te Lin has posted comments on this change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................


Patch Set 4: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>

Bill Richardson (Code Review)

unread,
Nov 14, 2012, 12:27:21 PM11/14/12
to Hung-Te Lin, Gerrit, Bill Richardson, Dave Parker
Bill Richardson has posted comments on this change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 14, 2012, 7:56:09 PM11/14/12
to Gerrit, Bill Richardson, Dave Parker
Hung-Te Lin has posted comments on this change.

Change subject: newbitmaps: Get rid of ImageMagick and use PIL for image processing.
......................................................................


Patch Set 4: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37985
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3d3a4ac399b2fe58aa75f8e02e4475bcba21c51
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/platform/vboot_reference
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Bill Richardson <wfri...@chromium.org>
Gerrit-Reviewer: Dave Parker <dpa...@chromium.org>
Reply all
Reply to author
Forward
0 new messages