dbus: Handle printing of 64-bit values [chromiumos/overlays/chromiumos-overlay : master]

2 views
Skip to first unread message

Paul Stewart (Code Review)

unread,
Nov 13, 2012, 2:53:11 PM11/13/12
to Matt Tennant, Elly Jones
Hello Matt Tennant, Elly Jones,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37924

to review the following change.

Change subject: dbus: Handle printing of 64-bit values
......................................................................

dbus: Handle printing of 64-bit values

The "send-print-fixed" patch left the arguments for printing
64-bit signed and unsigned values undefined. Define them.

BUG=chromium-os:36315
TEST=Run:
dbus-send --fixed --system --dest=org.chromium.flimflam --print-reply=literal /device/wlan0 org.chromium.flimflam.Device.GetProperties
on a system with a "wlan0" device, and note that 64-bit values like
"LinkMonitorResponseTime" and "ReceiveByteCount" are presented.

Change-Id: Ideec9e4b53cf7a47b1e0d038891f5bef3ddc757a
---
M sys-apps/dbus/files/dbus-1.4.12-send-print-fixed.patch
1 file changed, 12 insertions(+), 9 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/24/37924/1
--
To view, visit https://gerrit.chromium.org/gerrit/37924
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ideec9e4b53cf7a47b1e0d038891f5bef3ddc757a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Elly Jones <elly...@chromium.org>
Gerrit-Reviewer: Matt Tennant <mten...@chromium.org>

mukesh agrawal (Code Review)

unread,
Nov 13, 2012, 7:10:54 PM11/13/12
to Paul Stewart, Gerrit, Elly Jones, Matt Tennant
mukesh agrawal has posted comments on this change.

Change subject: dbus: Handle printing of 64-bit values
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37924
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ideec9e4b53cf7a47b1e0d038891f5bef3ddc757a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Elly Jones <elly...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Matt Tennant <mten...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

Paul Stewart (Code Review)

unread,
Nov 13, 2012, 7:12:02 PM11/13/12
to Gerrit, Elly Jones, Matt Tennant, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: dbus: Handle printing of 64-bit values
......................................................................


Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37924
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ideec9e4b53cf7a47b1e0d038891f5bef3ddc757a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Elly Jones <elly...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Matt Tennant <mten...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>
Reply all
Reply to author
Forward
0 new messages