Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Add flashrom EC support [chromiumos/platform/saft : master]
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   4 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Vic Yang (Code Review)  
View profile  
 More options May 18 2012, 5:28 am
From: "Vic Yang (Code Review)" <ger...@chromium.org>
Date: Fri, 18 May 2012 02:28:09 -0700
Local: Fri, May 18 2012 5:28 am
Subject: Add flashrom EC support [chromiumos/platform/saft : master]
Print | Individual message | Show original | Find messages by this author
Vic Yang has uploaded a new change for review.

Change subject: Add flashrom EC support
......................................................................

Add flashrom EC support

Current flashrom module only support reading/writing BIOS. To enable EC
FAFT, let's add flashrom EC support.

BUG=chrome-os-partner:9188
TEST=Manual test.

Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
---
M flashrom_handler.py
M saft_flashrom_util.py
2 files changed, 28 insertions(+), 14 deletions(-)

  git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/saft refs/changes/31/23031/1
--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Tom Wai-Hong Tam (Code Review)  
View profile  
 More options May 18 2012, 8:36 pm
From: "Tom Wai-Hong Tam (Code Review)" <ger...@chromium.org>
Date: Fri, 18 May 2012 17:36:48 -0700
Local: Fri, May 18 2012 8:36 pm
Subject: Add flashrom EC support [chromiumos/platform/saft : master]
Print | Individual message | Show original | Find messages by this author
Tom Wai-Hong Tam has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................

Patch Set 1: Looks good to me, approved

(1 inline comment)

LGTM w/ nit.

....................................................
Commit Message
Line 13: TEST=Manual test.
Please add more detailed steps about your test. At least, it doesn't break the existing bios FAFT tests.

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <waih...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Tom Wai-Hong Tam (Code Review)  
View profile  
 More options May 21 2012, 2:50 am
From: "Tom Wai-Hong Tam (Code Review)" <ger...@chromium.org>
Date: Sun, 20 May 2012 23:50:24 -0700
Local: Mon, May 21 2012 2:50 am
Subject: Add flashrom EC support [chromiumos/platform/saft : master]
Print | Individual message | Show original | Find messages by this author
Tom Wai-Hong Tam has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................

Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <waih...@chromium.org>
Gerrit-Reviewer: Vic Yang <victory...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Vic Yang (Code Review)  
View profile  
 More options May 21 2012, 2:51 am
From: "Vic Yang (Code Review)" <ger...@chromium.org>
Date: Sun, 20 May 2012 23:51:21 -0700
Local: Mon, May 21 2012 2:51 am
Subject: Add flashrom EC support [chromiumos/platform/saft : master]
Print | Individual message | Show original | Find messages by this author
Vic Yang has posted comments on this change.

Change subject: Add flashrom EC support
......................................................................

Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/23031
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e20e0e1b00749b5448490f841f9e1ae6a9c6ec4
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/saft
Gerrit-Branch: master
Gerrit-Owner: Vic Yang <victory...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <waih...@chromium.org>
Gerrit-Reviewer: Vic Yang <victory...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google