Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumo s-overlay : master]
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   20 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Jon Salz (Code Review)  
View profile  
 More options Apr 25 2012, 2:17 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Wed, 25 Apr 2012 11:17:06 -0700
Local: Wed, Apr 25 2012 2:17 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has uploaded a new change for review.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Build static directory (containing JS/CSS for factory UI).

BUG=None
TEST=Build and run

Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
---
M chromeos-base/autotest/autotest-9999.ebuild
1 file changed, 2 insertions(+), 0 deletions(-)

  git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/67/21067/1
--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chris Sosa (Code Review)  
View profile  
 More options Apr 25 2012, 6:53 pm
From: "Chris Sosa (Code Review)" <ger...@chromium.org>
Date: Wed, 25 Apr 2012 15:53:28 -0700
Local: Wed, Apr 25 2012 6:53 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Chris Sosa has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

Adding scottz:

Scott - while usually deps is the way we'd want to package an outside dependency into autotest, it seems for factory since they want the entire autotest blob than this might be the best approach.  Any comments?

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52:        dev-lang/closure-compiler-bin
Do we know how big this is?

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options Apr 25 2012, 7:00 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Wed, 25 Apr 2012 16:00:46 -0700
Local: Wed, Apr 25 2012 7:00 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: (1 inline comment)

Also note that this is a fairly special kind of dep - it is not ever used by an autotest directly (at runtime); it's just used at compile time.

Also worth noting that we are planning on the factory test harness, including the UI, out of autotest: the fact that it is in autotest is sort of an artifact of a previous implementation.  At that point we will also be reverting the autotest-9999.ebuild changes, of course, and removing the Closure library archive from the autotest tree.

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52:        dev-lang/closure-compiler-bin
5.2MB. However, it also requires the IcedTea JRE, which is ~113MB unpacked or ~35MB packed. We've discussed this in the "Using Google Closure library for our UI" thread on chromeos-build, and it seems like the consensus is that it's OK to include it. (It's necessary for serious JavaScript development, and in fact other projects in ChromiumOS are already using it; they just haven't added it to the chroot.)

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike Frysinger (Code Review)  
View profile  
 More options Apr 25 2012, 7:01 pm
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Wed, 25 Apr 2012 16:01:43 -0700
Local: Wed, Apr 25 2012 7:01 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: (1 inline comment)

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52:        dev-lang/closure-compiler-bin
this pkg itself is small.  but it pulls in a jre ;).

 $ qsize java closure
 dev-lang/closure-compiler-bin-20120305: 4 files, 9 non-files, 5255.501 KB
 dev-java/icedtea6-bin-1.6.2-r2: 689 files, 53 non-files, 113562.482 KB
 dev-java/java-config-2.1.10: 78 files, 30 non-files, 136.458 KB
 dev-java/java-config-wrapper-0.16: 4 files, 5 non-files, 17.194 KB

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Scott Zawalski (Code Review)  
View profile  
 More options Apr 25 2012, 8:19 pm
From: "Scott Zawalski (Code Review)" <ger...@chromium.org>
Date: Wed, 25 Apr 2012 17:19:58 -0700
Local: Wed, Apr 25 2012 8:19 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Scott Zawalski has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Looks good to me, but someone else must approve

Since we want the whole blob this is going to be the best way.

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options Apr 26 2012, 10:52 am
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 07:52:13 -0700
Local: Thurs, Apr 26 2012 10:52 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Chris Sosa (Code Review)  
View profile  
 More options Apr 26 2012, 4:07 pm
From: "Chris Sosa (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 13:07:37 -0700
Local: Thurs, Apr 26 2012 4:07 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Chris Sosa has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options Apr 26 2012, 4:09 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 13:09:25 -0700
Local: Thurs, Apr 26 2012 4:09 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options Apr 26 2012, 4:26 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 26 Apr 2012 13:26:16 -0700
Local: Thurs, Apr 26 2012 4:26 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3:

Ha, oops, I confused this with the Makefile change (which is obviously necessary before this one).  God Bless CQ

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options May 3 2012, 4:37 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 3 May 2012 13:37:36 -0700
Local: Thurs, May 3 2012 4:37 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options May 3 2012, 4:59 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 3 May 2012 13:59:11 -0700
Local: Thurs, May 3 2012 4:59 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 4: Verified; Looks good to me, approved; Ready

Rebased, self+2-ing

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options May 3 2012, 9:39 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 3 May 2012 18:39:39 -0700
Local: Thurs, May 3 2012 9:39 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 4: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jon Salz (Code Review)  
View profile  
 More options May 3 2012, 10:16 pm
From: "Jon Salz (Code Review)" <ger...@chromium.org>
Date: Thu, 3 May 2012 19:16:08 -0700
Local: Thurs, May 3 2012 10:16 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Jon Salz has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 5: Verified; Looks good to me, approved; Ready

Re-rebased, +2ing

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike Frysinger (Code Review)  
View profile  
 More options May 4 2012, 4:54 pm
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Fri, 4 May 2012 13:54:55 -0700
Local: Fri, May 4 2012 4:54 pm
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 5: (1 inline comment)

....................................................
File chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
Line 52:        dev-lang/closure-compiler-bin
i missed this the first time around, but this ebuild needs to be revbumped when updating

--
To view, visit https://gerrit.chromium.org/gerrit/21067
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Chris Sosa <s...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>
Gerrit-Reviewer: Zdenek Behan <zbe...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hsinyu Chao (Code Review)  
View profile  
 More options May 10 2012, 3:49 am
From: "Hsinyu Chao (Code Review)" <ger...@chromium.org>
Date: Thu, 10 May 2012 00:49:16 -0700
Local: Thurs, May 10 2012 3:49 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Hsinyu Chao has uploaded a new change for review.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Build static directory (containing JS/CSS for factory UI).

This CL takes over the work of the reverted CL and fixed by
version bump hard-host-depends.
The original Change-Id: Ib0f7dacdbadb38abdf5acb38393e36c1d262b64d

BUG=None
TEST=Build and run

Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
---
M chromeos-base/autotest/autotest-9999.ebuild
R chromeos-base/hard-host-depends/hard-host-depends-0.0.1-r122.ebuild
M chromeos-base/hard-host-depends/hard-host-depends-0.0.1.ebuild
3 files changed, 2 insertions(+), 0 deletions(-)

  git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/45/22345/1
--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Tammo Spalink (Code Review)  
View profile  
 More options May 10 2012, 4:16 am
From: "Tammo Spalink (Code Review)" <ger...@chromium.org>
Date: Thu, 10 May 2012 01:16:05 -0700
Local: Thurs, May 10 2012 4:16 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Tammo Spalink has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike Frysinger (Code Review)  
View profile  
 More options May 10 2012, 11:25 am
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Thu, 10 May 2012 08:25:37 -0700
Local: Thurs, May 10 2012 11:25 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 1: Fails

the lack of a bump to hard host depends isn't why it broke.  please see http://crosbug.com/30547 ... once that's been addressed, we can add this.

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hsinyu Chao (Code Review)  
View profile  
 More options May 11 2012, 2:12 am
From: "Hsinyu Chao (Code Review)" <ger...@chromium.org>
Date: Thu, 10 May 2012 23:12:01 -0700
Local: Fri, May 11 2012 2:12 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Hsinyu Chao has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 2: Verified

Rebased.

The cause of failure in http://crosbug.com/30547 was lacking of java. Which will be included in dependencies of dev-lang/closure-compiler-bin, which added to hard-host-depends in this cl. Therefore I think version bump is the correct way to fix it. Please take a look at the trybot result of my rebased change: http://chromegw/p/tryserver.chromiumos/builders/alex-paladin/builds/143

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike Frysinger (Code Review)  
View profile  
 More options May 11 2012, 4:01 am
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Fri, 11 May 2012 01:01:19 -0700
Local: Fri, May 11 2012 4:01 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Mike Frysinger has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 2: Looks good to me, approved

i guess we'll find out in the CQ ;)

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Hsinyu Chao (Code Review)  
View profile  
 More options May 11 2012, 4:30 am
From: "Hsinyu Chao (Code Review)" <ger...@chromium.org>
Date: Fri, 11 May 2012 01:30:39 -0700
Local: Fri, May 11 2012 4:30 am
Subject: Build static directory (containing JS/CSS for factory UI). [chromiumos/overlays/chromiumos-overlay : master]
Print | Individual message | Show original | Find messages by this author
Hsinyu Chao has posted comments on this change.

Change subject: Build static directory (containing JS/CSS for factory UI).
......................................................................

Patch Set 2: Ready

Thanks for the quick review!

--
To view, visit https://gerrit.chromium.org/gerrit/22345
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d2e5b21611d732db1a7a9478809b49c6bdecd8b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Tammo Spalink <ta...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google