exynos: fdt: daisy: Take the SPI keyboard out until it works... [chromiumos/third_party/u-boot : chromeos-v2011.12]

2 views
Skip to first unread message

Doug Anderson (Code Review)

unread,
May 15, 2012, 2:28:16 PM5/15/12
to
Doug Anderson has uploaded a new change for review.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................

exynos: fdt: daisy: Take the SPI keyboard out until it works better

When I have the SPI keyboard part of the FDT but don't have a keyboard
connected, I can get all sorts of junk. This should be fixed before
the SPI keyboard stuff is enabled.

BUG=chromium-os:30925
TEST=Booted and dind't see garbage.

Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Signed-off-by: Doug Anderson <dian...@chromium.org>
---
M board/samsung/dts/exynos5250-daisy.dts
1 file changed, 0 insertions(+), 8 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/u-boot refs/changes/16/22716/1
--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>

Gabe Black (Do Not Use) (Code Review)

unread,
May 15, 2012, 3:49:35 PM5/15/12
to Doug Anderson, Gabe Black, Simon Glass, Bernie Thompson
Gabe Black (Do Not Use) has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

This looks like it's doing what's advertised, but I'm not familiar with our SPI keyboard setup.

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Gabe Black (Do Not Use) <gabe...@google.com>
Gerrit-Reviewer: Gabe Black <gabe...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Bernie Thompson (Code Review)

unread,
May 15, 2012, 3:51:21 PM5/15/12
to Doug Anderson, Gabe Black, Gabe Black (Do Not Use), Simon Glass
Bernie Thompson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

This does look to work as I watched over Doug's shoulder, leaving the final +2 up to sjg, not sure where we are in regards to SPI keyboard working on ToT.

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>

Vincent Palatin (Code Review)

unread,
May 15, 2012, 7:49:39 PM5/15/12
to Doug Anderson, Vincent Palatin, Gabe Black, Gabe Black (Do Not Use), Simon Glass, Bernie Thompson
Vincent Palatin has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Gabe Black (Do Not Use) <gabe...@google.com>
Gerrit-Reviewer: Gabe Black <gabe...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Gerrit-Reviewer: Vincent Palatin <vpal...@chromium.org>

Doug Anderson (Code Review)

unread,
May 15, 2012, 8:47:07 PM5/15/12
to Vincent Palatin, Gabe Black, Gabe Black (Do Not Use), Simon Glass, Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Simon would prefer to submit <https://gerrit.chromium.org/gerrit/22775> instead. I can't test this now, but will try to test tomorrow morning.

Can anyone else replicate my problems and my fix? Can anyone else see if sjg's patch works?

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>

Doug Anderson (Code Review)

unread,
May 16, 2012, 3:17:17 PM5/16/12
to Vincent Palatin, Gabe Black, Gabe Black (Do Not Use), Simon Glass, Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Verified; No score

Since other CL doesn't fix my problem, removing -1 and marking verified. Will submit once tree opens.

This can always be reverted later if problems are fixed.

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>

Doug Anderson (Code Review)

unread,
May 16, 2012, 4:03:00 PM5/16/12
to Vincent Palatin, Gabe Black, Gabe Black (Do Not Use), Simon Glass, Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>

Doug Anderson (Code Review)

unread,
May 16, 2012, 5:33:07 PM5/16/12
to Vincent Palatin, Gabe Black (Do Not Use), Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Gabe Black (Do Not Use) <gabe...@google.com>
Gerrit-Reviewer: Vincent Palatin <vpal...@chromium.org>

Doug Anderson (Code Review)

unread,
May 16, 2012, 6:22:53 PM5/16/12
to Vincent Palatin, Gabe Black (Do Not Use), Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>

Doug Anderson (Code Review)

unread,
May 16, 2012, 8:31:51 PM5/16/12
to Gerrit, Vincent Palatin, Gabe Black (Do Not Use), Bernie Thompson
Doug Anderson has posted comments on this change.

Change subject: exynos: fdt: daisy: Take the SPI keyboard out until it works better
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

Carry forward reviews after rebase.

--
To view, visit https://gerrit.chromium.org/gerrit/22716
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I756e7f55fbb92db0865126f71aa3b2c9fd0037f4
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/u-boot
Gerrit-Branch: chromeos-v2011.12
Gerrit-Owner: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Gabe Black (Do Not Use) <gabe...@google.com>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Vincent Palatin <vpal...@chromium.org>
Reply all
Reply to author
Forward
0 new messages