Get network_3GModemControl working with shill. [chromiumos/third_party/autotest : master]

2 views
Skip to first unread message

Thieu Le (Code Review)

unread,
May 15, 2012, 6:46:33 PM5/15/12
to
Thieu Le has uploaded a new change for review.

Change subject: Get network_3GModemControl working with shill.
......................................................................

Get network_3GModemControl working with shill.

- Fix mis-capitalization in "LastGoodAPN" property.
- Switch to Device.Enable()/Disable() instead of "Powered" property.
- Increase timeout waiting for cellular service to enter a specific
state.
- Add additional debug tags to help debug failures.

BUG=chromium-os:25566
TEST=network_3GModemControl

Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
---
M client/cros/cellular/cell_tools.py
M client/site_tests/network_3GModemControl/network_3GModemControl.py
2 files changed, 10 insertions(+), 7 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/60/22760/1
--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Jason Glasgow (Code Review)

unread,
May 16, 2012, 10:03:39 AM5/16/12
to Thieu Le, Gary Morain
Jason Glasgow has posted comments on this change.

Change subject: Get network_3GModemControl working with shill.
......................................................................


Patch Set 2: Looks good to me, approved

The test will no longer run against flimflam -- but I guess that is okay.

--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>
Gerrit-Reviewer: Gary Morain <gmo...@chromium.org>
Gerrit-Reviewer: Jason Glasgow <jgla...@chromium.org>
Gerrit-Reviewer: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 4:19:18 PM5/16/12
to Jason Glasgow, Gary Morain
Thieu Le has posted comments on this change.

Change subject: Get network_3GModemControl working with shill.
......................................................................


Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 5:03:43 PM5/16/12
to Jason Glasgow
Thieu Le has posted comments on this change.

Change subject: Get network_3GModemControl working with shill.
......................................................................


Patch Set 2: Ready

Unit test in chromeos-ec failed, not shill related.

--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 5:23:34 PM5/16/12
to Jason Glasgow
Thieu Le has posted comments on this change.

Change subject: Get network_3GModemControl working with shill.
......................................................................


Patch Set 2: Looks good to me, approved; Ready

Once again

--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 6:08:55 PM5/16/12
to Jason Glasgow
Thieu Le has posted comments on this change.

Change subject: Get network_3GModemControl working with shill.
......................................................................


Patch Set 2: Ready

Trying again, maybe petkov's CL.

--
To view, visit https://gerrit.chromium.org/gerrit/22760
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd097950dfc918c78c1daba7776600ed12bf977c
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Thieu Le <thi...@chromium.org>
Reply all
Reply to author
Forward
0 new messages