CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg... [chromiumos/third_party/kernel : chromeos-3.2]

3 views
Skip to first unread message

Yufeng Shen (Code Review)

unread,
May 16, 2012, 3:03:16 PM5/16/12
to Olof Johansson, Mandeep Singh Baines
Yufeng Shen has uploaded a new change for review.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................

CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend

If the atmel chip enters suspend mode and wants to be able to
wakeup from suspend, T9 object has to be enabled during suspend.
If T9 is enalbed from a disabled state, the chip will perform an
auto calibration and send back the status of the calibration.
We have to wait for these messages to be read before entering
suspend, otherwise these message will wakeup the system automatically.

Signed-off-by: Yufeng Shen <mil...@chromium.org>

BUG=chrome-os-partner:8722
TEST=run powerd_suspend to put system into sleep and make sure it
does not wakeup automatically. And touch the TS/TP to wake the
system up

Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
---
M drivers/input/touchscreen/atmel_mxt_ts.c
1 file changed, 33 insertions(+), 6 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/42/22842/1
--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>

Benson Leung (Code Review)

unread,
May 16, 2012, 3:47:51 PM5/16/12
to Yufeng Shen
Benson Leung has posted comments on this change.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

lgtm with small nit.

....................................................
File drivers/input/touchscreen/atmel_mxt_ts.c
Line 2104: /* Enable T9 objcet */
s/objcet/object

--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Gerrit-Reviewer: Benson Leung <ble...@chromium.org>

Yufeng Shen (Code Review)

unread,
May 16, 2012, 4:10:03 PM5/16/12
to Benson Leung
Yufeng Shen has posted comments on this change.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File drivers/input/touchscreen/atmel_mxt_ts.c
Line 2104: /* Enable T9 objcet */
Done

--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
Gerrit-Reviewer: Yufeng Shen <mil...@chromium.org>

Benson Leung (Code Review)

unread,
May 16, 2012, 4:24:47 PM5/16/12
to Yufeng Shen
Benson Leung has posted comments on this change.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>

Vadim Bendebury (Code Review)

unread,
May 16, 2012, 7:12:02 PM5/16/12
to Yufeng Shen, Benson Leung, Vadim Bendebury
Vadim Bendebury has posted comments on this change.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

I just verified that the change causes the suspend function operate properly, while touch pad and touch screen still work as expected.

While you are at it, can you fix a compilation warning also?


diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c
index 234d4c0..e96d76e 100644
--- a/drivers/input/touchscreen/atmel_mxt_ts.c
+++ b/drivers/input/touchscreen/atmel_mxt_ts.c
@@ -1451,7 +1451,6 @@ static ssize_t mxt_update_fw_store(struct device *dev,
struct device_attribute *attr,
const char *buf, size_t count)
{
- struct mxt_data *data = dev_get_drvdata(dev);
int error;

--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
Gerrit-Reviewer: Vadim Bendebury <vbe...@chromium.org>
Gerrit-Reviewer: Yufeng Shen <mil...@chromium.org>

Yufeng Shen (Code Review)

unread,
May 17, 2012, 12:33:44 PM5/17/12
to Benson Leung, Vadim Bendebury
Yufeng Shen has posted comments on this change.

Change subject: CHROMIUM: Input: atmel_mxt_ts - Wait on auto calibration msg in suspend
......................................................................


Patch Set 2: Verified; Ready

The warning issue is going to be fixed here

https://gerrit.chromium.org/gerrit/#change,22867

--
To view, visit https://gerrit.chromium.org/gerrit/22842
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8175c8e6d523edfd152172e1966303ac8fd65f
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Reply all
Reply to author
Forward
0 new messages