ARM: dts: peach-pit: add i2c busses and devices [chromiumos/third_party/kernel-next : chromeos-3.8]

1 view
Skip to first unread message

Andrew Bresticker (Code Review)

unread,
May 24, 2013, 12:22:11 AM5/24/13
to Simon Glass, Doug Anderson, Olof Johansson
Hello Simon Glass, Doug Anderson,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/56565

to review the following change.

Change subject: ARM: dts: peach-pit: add i2c busses and devices
......................................................................

ARM: dts: peach-pit: add i2c busses and devices

This adds device-tree bindings for the i2c and high-speed i2c busses and
their attached devices on Peach-Pit.

BUG=chrome-os-partner:19007
TEST=Build and boot on peach-pit. Trackpad works; can communicate with
TPM, PMIC, and codec.

Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Signed-off-by: Andrew Bresticker <abre...@chromium.org>
---
M arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
1 file changed, 375 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/65/56565/1

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts b/arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
index e03d035..a594ff8 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
@@ -19,4 +19,379 @@

aliases {
};
+
+ pinctrl@13400000 {
+ cyapa_irq: cyapa-irq {
+ samsung,pins = "gpx1-1";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ max77802_irq: max77802-irq {
+ samsung,pins = "gpx3-1";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ max98090_irq: max98090-irq {
+ samsung,pins = "gpx0-2";
+ samsung,pin-function = <0>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ ps8625_sleep: ps8625-sleep {
+ samsung,pins = "gpx3-5";
+ samsung,pin-function = <1>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+
+ ps8625_reset: ps8625-reset {
+ samsung,pins = "gpy7-7";
+ samsung,pin-function = <1>;
+ samsung,pin-pud = <0>;
+ samsung,pin-drv = <0>;
+ };
+ };
+
+ hsi2c@12CA0000 {
+ status = "okay";
+
+ max77802-pmic@9 {
+ compatible = "maxim,max77802";
+ interrupt-parent = <&gpx3>;
+ interrupts = <1 0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&max77802_irq>;
+ wakeup-source;
+ reg = <0x9>;
+
+ voltage-regulators {
+ ldo1_reg: LDO1 {
+ regulator-name = "vdd_1v0";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+ ldo2_reg: LDO2 {
+ regulator-name = "vdd_1v2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+ ldo3_reg: LDO3 {
+ regulator-name = "vdd_1v8_3";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo4_reg: LDO4 {
+ regulator-name = "vdd_sd";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-always-on;
+ };
+ ldo5_reg: LDO5 {
+ regulator-name = "vdd_1v8_5";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo6_reg: LDO6 {
+ regulator-name = "vdd_1v8_6";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo7_reg: LDO7 {
+ regulator-name = "vdd_1v8_7";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ ldo8_reg: LDO8 {
+ regulator-name = "vdd_ldo8";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+ ldo9_reg: LDO9 {
+ regulator-name = "vdd_ldo9";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo10_reg: LDO10 {
+ regulator-name = "vdd_ldo10";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo11_reg: LDO11 {
+ regulator-name = "vdd_ldo11";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo12_reg: LDO12 {
+ regulator-name = "vdd_ldo12";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ regulator-always-on;
+ };
+ ldo13_reg: LDO13 {
+ regulator-name = "vdd_ldo13";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo14_reg: LDO14 {
+ regulator-name = "vdd_ldo14";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo15_reg: LDO15 {
+ regulator-name = "vdd_ldo15";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+ ldo17_reg: LDO17 {
+ regulator-name = "ldo_17";
+ regulator-min-microvolt = <1000000>;
+ regulator-max-microvolt = <1000000>;
+ regulator-always-on;
+ };
+ ldo18_reg: LDO18 {
+ regulator-name = "ldo_18";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ ldo19_reg: LDO19 {
+ regulator-name = "ldo_19";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ ldo20_reg: LDO20 {
+ regulator-name = "ldo_20";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+ ldo21_reg: LDO21 {
+ regulator-name = "ldo_21";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ ldo23_reg: LDO23 {
+ regulator-name = "ld0_23";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ ldo24_reg: LDO24 {
+ regulator-name = "ldo_24";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ ldo25_reg: LDO25 {
+ regulator-name = "ldo_25";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ };
+ ldo26_reg: LDO26 {
+ regulator-name = "ldo_26";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+ ldo27_reg: LDO27 {
+ regulator-name = "ldo_27";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+ ldo28_reg: LDO28 {
+ regulator-name = "ldo_28";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ ldo29_reg: LDO29 {
+ regulator-name = "ldo_29";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+ ldo30_reg: LDO30 {
+ regulator-name = "ldo_30";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+ ldo32_reg: LDO32 {
+ regulator-name = "ldo_32";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ };
+ ldo33_reg: LDO33 {
+ regulator-name = "ldo_33";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ };
+ ldo34_reg: LDO34 {
+ regulator-name = "ldo_34";
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ };
+ ldo35_reg: LDO35 {
+ regulator-name = "ldo_35";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ };
+ buck1_reg: BUCK1 {
+ regulator-name = "vdd_mif";
+ regulator-min-microvolt = <950000>;
+ regulator-max-microvolt = <1300000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck2_reg: BUCK2 {
+ regulator-name = "vdd_arm";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1500000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck3_reg: BUCK3 {
+ regulator-name = "vdd_int";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck4_reg: BUCK4 {
+ regulator-name = "vdd_g3d";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1400000>;
+ /*
+ * TODO(s...@chromium.org): Maybe remove
+ * this once things are hooked up.
+ */
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck5_reg: BUCK5 {
+ regulator-name = "vdd_1v2";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck6_reg: BUCK6 {
+ regulator-name = "vdd_kfc";
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1500000>;
+ /*
+ * TODO(s...@chromium.org): Can this
+ * be powered off?
+ */
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck7_reg: BUCK7 {
+ regulator-name = "vdd_1v35";
+ regulator-min-microvolt = <1350000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck8_reg: BUCK8 {
+ regulator-name = "vdd_emmc";
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <2850000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck9_reg: BUCK9 {
+ regulator-name = "vdd_2v";
+ regulator-min-microvolt = <2000000>;
+ regulator-max-microvolt = <2000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ buck10_reg: BUCK10 {
+ regulator-name = "vdd_1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+ en32khz_ap: EN32KHZ_AP {
+ regulator-name = "en32khz_ap";
+ regulator-always-on;
+ };
+ en32khz_cp: EN32KHZ_CP {
+ regulator-name = "en32khz_cp";
+ regulator-always-on;
+ };
+ };
+
+ maxim_rtc: rtc {
+ };
+ };
+ };
+
+ hsi2c@12CD0000 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ ps8625-bridge@48 {
+ compatible = "parade,ps8625";
+ reg = <0x48>;
+ sleep-gpio = <&gpx3 5 0>;
+ reset-gpio = <&gpy7 7 0>;
+ lane-count = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&ps8625_sleep &ps8625_reset>;
+ };
+
+ codec@10 {
+ compatible = "maxim,max98090";
+ reg = <0x10>;
+ interrupts = <2 0>;
+ interrupt-parent = <&gpx0>;
+ mic-left-digital;
+ mic-right-digital;
+ mclk-pin = <2>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&max98090_irq>;
+ };
+
+ light-sensor@44 {
+ compatible = "invn,isl29023";
+ reg = <0x44>;
+ };
+ };
+
+ hsi2c@12E00000 {
+ status = "okay";
+ clock-frequency = <333000>;
+
+ trackpad@67 {
+ reg = <0x67>;
+ compatible = "cypress,cyapa";
+ interrupts = <1 0>;
+ interrupt-parent = <&gpx1>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&cyapa_irq>;
+ wakeup-source;
+ };
+ };
+
+ hsi2c@12E10000 {
+ status = "okay";
+ clock-frequency = <400000>;
+
+ tpm@20 {
+ compatible = "infineon,slb9645tt";
+ reg = <0x20>;
+ };
+ };
};

--
To view, visit https://gerrit.chromium.org/gerrit/56565
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Simon Glass (Code Review)

unread,
May 24, 2013, 2:22:09 AM5/24/13
to Andrew Bresticker, ChromeBot, Doug Anderson
Simon Glass has posted comments on this change.

Change subject: ARM: dts: peach-pit: add i2c busses and devices
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

LGTM with suggestion

Test looks good.

....................................................
File arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
Line 60: hsi2c@12CA0000 {
Again suggest comments for each node


--
To view, visit https://gerrit.chromium.org/gerrit/56565
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>

Andrew Bresticker (Code Review)

unread,
May 24, 2013, 12:20:44 PM5/24/13
to ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has posted comments on this change.

Change subject: ARM: dts: peach-pit: add i2c busses and devices
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File arch/arm/boot/dts/exynos5420-peach-pit-rev1.dts
Line 60: hsi2c@12CA0000 {
Done


--
To view, visit https://gerrit.chromium.org/gerrit/56565
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>

Andrew Bresticker (Code Review)

unread,
May 24, 2013, 12:36:09 PM5/24/13
to ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has posted comments on this change.

Change subject: ARM: dts: peach-pit: add i2c busses and devices
......................................................................


Patch Set 3: Looks good to me, approved; Ready; Verified

Carrying Simon's +2.

--
To view, visit https://gerrit.chromium.org/gerrit/56565
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>

Andrew Bresticker (Code Review)

unread,
May 24, 2013, 1:49:21 PM5/24/13
to ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has posted comments on this change.

Change subject: ARM: dts: peach-pit: add i2c busses and devices
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/56565
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6ce741755ed47d7251b616772714a389c26e3f7
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Reply all
Reply to author
Forward
0 new messages