CHROMIUM: config: add S2MP PMIC to exynos5 flavour [chromiumos/third_party/kernel-next : chromeos-3.8]

4 views
Skip to first unread message

Arun Kumar K (Code Review)

unread,
May 22, 2013, 12:03:26 PM5/22/13
to naveen krishna chatradhi, Olof Johansson
Hello naveen krishna chatradhi,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/56219

to review the following change.

Change subject: CHROMIUM: config: add S2MP PMIC to exynos5 flavour
......................................................................

CHROMIUM: config: add S2MP PMIC to exynos5 flavour

this patch adds the S2MP PMIC from samsung to exynos5 flavour

BUG=chrome-os-partner:19007
TEST=PMIC S2MP should be probing based on dts definitions

Change-Id: Ib17e4823a942c04707c1b02c73d0dfbc5e513071
Signed-off-by: Naveen Krishna Chatradhi <ch.n...@samsung.com>
---
M chromeos/config/armel/chromeos-exynos5.flavour.config
M chromeos/config/armel/chromiumos-arm.flavour.config
M chromeos/config/base.config
M chromeos/config/i386/common.config
M chromeos/config/x86_64/common.config
5 files changed, 6 insertions(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/19/56219/1

diff --git a/chromeos/config/armel/chromeos-exynos5.flavour.config b/chromeos/config/armel/chromeos-exynos5.flavour.config
index f7e0704..3c2a81f 100644
--- a/chromeos/config/armel/chromeos-exynos5.flavour.config
+++ b/chromeos/config/armel/chromeos-exynos5.flavour.config
@@ -152,6 +152,7 @@
CONFIG_MFD_CROS_EC_I2C=y
# CONFIG_MFD_CROS_EC_SPI is not set
CONFIG_MFD_MAX77686=y
+CONFIG_MFD_SEC_CORE=y
CONFIG_MFD_TPS65090=y
# CONFIG_MFD_TPS6586X is not set
CONFIG_MFD_WM8994=y
@@ -183,6 +184,8 @@
CONFIG_PWM_SAMSUNG=y
CONFIG_REGMAP_IRQ=y
CONFIG_REGULATOR_MAX77686=y
+CONFIG_REGULATOR_S2MPS11=y
+# CONFIG_REGULATOR_S5M8767 is not set
CONFIG_REGULATOR_TPS65090=y
CONFIG_REGULATOR_WM8994=y
CONFIG_RT2500USB=m
diff --git a/chromeos/config/armel/chromiumos-arm.flavour.config b/chromeos/config/armel/chromiumos-arm.flavour.config
index 52aa21d..e1d6ab3 100644
--- a/chromeos/config/armel/chromiumos-arm.flavour.config
+++ b/chromeos/config/armel/chromiumos-arm.flavour.config
@@ -92,6 +92,7 @@
# CONFIG_MFD_CROS_EC is not set
# CONFIG_MFD_MAX77686 is not set
# CONFIG_MFD_NVEC is not set
+# CONFIG_MFD_SEC_CORE is not set
# CONFIG_MFD_TPS65090 is not set
CONFIG_MFD_TPS6586X=y
# CONFIG_MFD_WM8994 is not set
diff --git a/chromeos/config/base.config b/chromeos/config/base.config
index fc5c07c..42d0c0e 100644
--- a/chromeos/config/base.config
+++ b/chromeos/config/base.config
@@ -992,7 +992,6 @@
# CONFIG_MFD_PCF50633 is not set
# CONFIG_MFD_RC5T583 is not set
# CONFIG_MFD_RETU is not set
-# CONFIG_MFD_SEC_CORE is not set
# CONFIG_MFD_SM501 is not set
# CONFIG_MFD_SMSC is not set
# CONFIG_MFD_STMPE is not set
diff --git a/chromeos/config/i386/common.config b/chromeos/config/i386/common.config
index 0094218..d7cee6b 100644
--- a/chromeos/config/i386/common.config
+++ b/chromeos/config/i386/common.config
@@ -507,6 +507,7 @@
# CONFIG_MFD_MAX77686 is not set
# CONFIG_MFD_RDC321X is not set
# CONFIG_MFD_RTSX_PCI is not set
+# CONFIG_MFD_SEC_CORE is not set
# CONFIG_MFD_TIMBERDALE is not set
# CONFIG_MFD_TPS65090 is not set
# CONFIG_MFD_TPS6586X is not set
diff --git a/chromeos/config/x86_64/common.config b/chromeos/config/x86_64/common.config
index 86d1df3..6535481 100644
--- a/chromeos/config/x86_64/common.config
+++ b/chromeos/config/x86_64/common.config
@@ -553,6 +553,7 @@
# CONFIG_MFD_MAX77686 is not set
# CONFIG_MFD_RDC321X is not set
# CONFIG_MFD_RTSX_PCI is not set
+# CONFIG_MFD_SEC_CORE is not set
# CONFIG_MFD_TIMBERDALE is not set
# CONFIG_MFD_TPS65090 is not set
# CONFIG_MFD_TPS6586X is not set

--
To view, visit https://gerrit.chromium.org/gerrit/56219
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib17e4823a942c04707c1b02c73d0dfbc5e513071
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: naveen krishna chatradhi <nav...@chromium.org>

Doug Anderson (Code Review)

unread,
May 24, 2013, 12:05:25 AM5/24/13
to Arun Kumar K, naveen krishna chatradhi, ChromeBot, Simon Glass
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: config: add S2MP PMIC to exynos5 flavour
......................................................................


Patch Set 1: Looks good to me, approved

Rebase to ToT and we can land this.
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib17e4823a942c04707c1b02c73d0dfbc5e513071
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Arun Kumar K (Code Review)

unread,
Jun 21, 2013, 2:51:22 AM6/21/13
to naveen krishna chatradhi, ChromeBot, Doug Anderson, Simon Glass
Arun Kumar K has abandoned this change.

Change subject: CHROMIUM: config: add S2MP PMIC to exynos5 flavour
......................................................................


Patch Set 1: Abandoned

Not needed anymore.
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib17e4823a942c04707c1b02c73d0dfbc5e513071
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <arunkk....@gmail.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Reply all
Reply to author
Forward
0 new messages