[autotest] Search for control files more precisely [chromiumos/third_party/autotest : master]

0 views
Skip to first unread message

Chris Masone (Code Review)

unread,
May 16, 2012, 4:20:07 PM5/16/12
to Scott Zawalski, Chris Sosa
Hello Scott Zawalski, Chris Sosa,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/22849

to review the following change.

Change subject: [autotest] Search for control files more precisely
......................................................................

[autotest] Search for control files more precisely

In control_file_getter.DevServerGetter, we use a regexp to go through
the list of files returned from the dev server, looking for the
control file the caller wants to run. The existing re has no anchor
at the end, so it was basically doing prefix matching. So, looking
for 'control.bvt' would be non-unique fail if 'control.bvt' and
'control.bvt_bigger' both existed.

This CL adds an anchor at the end, so that 'control.bvt' matches only
'control.bvt', 'dummy_Pass/control' matches only that, etc etc etc.

BUG=chromium-os:30824
TEST=use run_suite to run the 'dummy' suite
TEST=create a 'dummy_x1' suite control file, and run that with run_suite as well.
STATUS=Fixed

Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
---
M server/cros/control_file_getter.py
1 file changed, 2 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/49/22849/1
--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 4:21:12 PM5/16/12
to Chris Sosa, Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Scott Zawalski (Code Review)

unread,
May 16, 2012, 4:28:16 PM5/16/12
to Chris Masone, Chris Sosa
Scott Zawalski has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 4:30:21 PM5/16/12
to Chris Sosa, Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 5:23:52 PM5/16/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 6:58:40 PM5/16/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 7:46:58 PM5/16/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Search for control files more precisely
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22849
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1127ce721e176f729406868d346c2240f22d9cde
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Reply all
Reply to author
Forward
0 new messages