firmware: clean up firmware updater packaging content [chromiumos/platform/firmware : master]

Hung-Te Lin (Code Review)

unread,

Aug 31, 2011, 12:03:13 AM8/31/11

to Randall Spangler, Tom Wai-Hong Tam

Hello Randall Spangler, Tom Wai-Hong Tam,

I'd like you to do a code review. Please visit

http://gerrit.chromium.org/gerrit/6978

to review the following change.

Change subject: firmware: clean up firmware updater packaging content
......................................................................

firmware: clean up firmware updater packaging content

Since updater[n].sh is versioned and no dependency with each other, we should
remove inactivate updater scripts to minimize the output updater.

BUG=chromium-os:17296
TEST=emerge-x86-alex chromeos-firmware-alex
# see only updater2.sh in output updater, no updater[13].sh

Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
---
D pack_dist/legacy_updater.sh
M pack_firmware.sh
2 files changed, 11 insertions(+), 1,797 deletions(-)

git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/firmware refs/changes/78/6978/1
--
To view, visit http://gerrit.chromium.org/gerrit/6978
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/firmware
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Randall Spangler <rspa...@chromium.org>
Gerrit-Reviewer: Tom Wai-Hong Tam <wai...@chromium.org>

Hung-Te Lin (Code Review)

unread,

Aug 31, 2011, 7:24:23 AM8/31/11

to Yung-Chieh Lo, Randall Spangler

Hung-Te Lin has posted comments on this change.

Change subject: firmware: clean up firmware updater packaging content
......................................................................

Patch Set 1: Verified

--
To view, visit http://gerrit.chromium.org/gerrit/6978
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/firmware
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>

Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Randall Spangler <rspa...@chromium.org>
Gerrit-Reviewer: Yung-Chieh Lo <yjlou%chromi...@gtempaccount.com>

Randall Spangler (Code Review)

unread,

Aug 31, 2011, 11:13:23 AM8/31/11

to Hung-Te Lin, Yung-Chieh Lo

Randall Spangler has posted comments on this change.

Change subject: firmware: clean up firmware updater packaging content
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit http://gerrit.chromium.org/gerrit/6978
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/firmware
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>

Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Randall Spangler <rspa...@chromium.org>
Gerrit-Reviewer: Yung-Chieh Lo <yjlou%chromi...@gtempaccount.com>

Hung-Te Lin (Code Review)

unread,

Aug 31, 2011, 11:20:56 AM8/31/11

to Yung-Chieh Lo, Randall Spangler

Hung-Te Lin has submitted this change and it was merged.

Change subject: firmware: clean up firmware updater packaging content
......................................................................

firmware: clean up firmware updater packaging content

Since updater[n].sh is versioned and no dependency with each other, we should
remove inactivate updater scripts to minimize the output updater.

BUG=chromium-os:17296
TEST=emerge-x86-alex chromeos-firmware-alex
# see only updater2.sh in output updater, no updater[13].sh

Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
---
D pack_dist/legacy_updater.sh
M pack_firmware.sh
2 files changed, 11 insertions(+), 1,797 deletions(-)

Approvals:
Hung-Te Lin: Verified
Randall Spangler: Looks good to me, approved

--
To view, visit http://gerrit.chromium.org/gerrit/6978
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged

Gerrit-Change-Id: I204003d115fcf0f8ec1d490f68d1d207ef75ed8a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/firmware
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>

Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Randall Spangler <rspa...@chromium.org>
Gerrit-Reviewer: Yung-Chieh Lo <yjlou%chromi...@gtempaccount.com>

Reply all

Reply to author

Forward