UPSTREAM: ALSA: HDA: Jack: Export required functions from hd... [chromiumos/third_party/kernel : chromeos-3.2]

2 views
Skip to first unread message

Dylan Reid (Code Review)

unread,
Apr 20, 2012, 2:31:58 PM4/20/12
to Olof Johansson, Mandeep Singh Baines
Dylan Reid has uploaded a new change for review.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................

UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c

These two functions are being used by the codec-idt and codec-hdmi
modules, so they need to be exported properly.

BUG=chromium-os:20620
TEST=Manual, run kernel on stumpy and check for JACK controls.

Signed-off-by: David Henningsson <david.he...@canonical.com>
Signed-off-by: Takashi Iwai <ti...@suse.de>
(cherry picked from commit d1cb620081f51c78cf95224efb593a886875078f)
Signed-off-by: Dylan Reid <dgr...@chromium.org>

Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
---
M sound/pci/hda/hda_jack.c
1 file changed, 2 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/20/20720/1
--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Todd Broch (Code Review)

unread,
Apr 26, 2012, 6:45:20 PM4/26/12
to Dylan Reid, Taylor Hutt
Todd Broch has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 26, 2012, 9:28:04 PM4/26/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 26, 2012, 11:44:03 PM4/26/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................


Patch Set 3: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 1:02:05 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................


Patch Set 4: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 1:48:22 AM4/27/12
to Taylor Hutt, Todd Broch
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................


Patch Set 5: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
Apr 27, 2012, 2:24:04 AM4/27/12
to Taylor Hutt, Todd Broch, Gerrit
Dylan Reid has posted comments on this change.

Change subject: UPSTREAM: ALSA: HDA: Jack: Export required functions from hda_jack.c
......................................................................




--
To view, visit https://gerrit.chromium.org/gerrit/20720
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa36f1659b2b6f9ccd4977f56fffc129b940373
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.2
Gerrit-Owner: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Reply all
Reply to author
Forward
0 new messages