factory_install: Disable checking WP before clearing TPM. [chromiumos/platform/factory_installer : master]

1 view
Skip to first unread message

Hung-Te Lin (Code Review)

unread,
Nov 4, 2012, 11:00:40 PM11/4/12
to Jon Salz
Hello Jon Salz,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37337

to review the following change.

Change subject: factory_install: Disable checking WP before clearing TPM.
......................................................................

factory_install: Disable checking WP before clearing TPM.

BUG=chrome-os-partner:15795
TEST=build_image factory_install

Change-Id: Iec7fcbd4fe104833c11e3461a18741e9eb2ba14a
---
M factory_install.sh
1 file changed, 7 insertions(+), 8 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/factory_installer refs/changes/37/37337/1
--
To view, visit https://gerrit.chromium.org/gerrit/37337
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec7fcbd4fe104833c11e3461a18741e9eb2ba14a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/factory_installer
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 4, 2012, 11:02:40 PM11/4/12
to Gerrit, Jon Salz
Hung-Te Lin has posted comments on this change.

Change subject: factory_install: Disable checking WP before clearing TPM.
......................................................................


Patch Set 2: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/37337
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7fcbd4fe104833c11e3461a18741e9eb2ba14a
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/factory_installer
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>

Jon Salz (Code Review)

unread,
Nov 4, 2012, 11:20:50 PM11/4/12
to Hung-Te Lin, Gerrit
Jon Salz has posted comments on this change.

Change subject: factory_install: Disable checking WP before clearing TPM.
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File factory_install.sh
Line 213: log " - System was not booted in recovery mode (current: $mainfw_type)."
I think you can now just put the warning in this block now, no? (No need for the tpm_is_cleared variable)

--
To view, visit https://gerrit.chromium.org/gerrit/37337
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7fcbd4fe104833c11e3461a18741e9eb2ba14a
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/factory_installer
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>

Hung-Te Lin (Code Review)

unread,
Nov 4, 2012, 11:46:42 PM11/4/12
to Gerrit, Jon Salz
Hung-Te Lin has posted comments on this change.

Change subject: factory_install: Disable checking WP before clearing TPM.
......................................................................


Patch Set 2: Ready

(1 inline comment)

....................................................
File factory_install.sh
Line 213: log " - System was not booted in recovery mode (current: $mainfw_type)."
Probably - but let's keep it for a while :)

--
To view, visit https://gerrit.chromium.org/gerrit/37337
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec7fcbd4fe104833c11e3461a18741e9eb2ba14a
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/factory_installer
Gerrit-Branch: master
Gerrit-Owner: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hung-Te Lin <hun...@chromium.org>
Gerrit-Reviewer: Jon Salz <js...@chromium.org>
Reply all
Reply to author
Forward
0 new messages