Initial commit of Raspberry Pi board [chromiumos/overlays/board-overlays : master]

28 views
Skip to first unread message

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 2:32:26 PM5/16/12
to
Liam McLoughlin has uploaded a new change for review.

Change subject: Initial commit of Raspberry Pi board
......................................................................

Initial commit of Raspberry Pi board

BUG=none
TEST=Build raspberrypi board, confirm board boots (minus UI, since the dispmanx stuff isn't present in Chrome yet)

Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
---
A overlay-raspberrypi/chromeos-base/chromeos-bsp-raspberrypi/chromeos-bsp-raspberrypi-0.0.1-r1.ebuild
A overlay-raspberrypi/chromeos-base/chromeos-bsp-raspberrypi/chromeos-bsp-raspberrypi-0.0.1.ebuild
A overlay-raspberrypi/make.conf
A overlay-raspberrypi/metadata/layout.conf
A overlay-raspberrypi/profiles/base/parent
A overlay-raspberrypi/profiles/base/virtuals
A overlay-raspberrypi/profiles/repo_name
A overlay-raspberrypi/sys-kernel/raspberrypi-kernel/raspberrypi-kernel-3.1.9-r1.ebuild
A overlay-raspberrypi/sys-kernel/raspberrypi-kernel/raspberrypi-kernel-3.1.9.ebuild
A overlay-raspberrypi/toolchain.conf
A overlay-raspberrypi/virtual/linux-sources/linux-sources-0.0.2.ebuild
A overlay-raspberrypi/virtual/opengles/opengles-2.ebuild
A overlay-raspberrypi/x11-drivers/opengles-bin/opengles-bin-0.0.1.ebuild
13 files changed, 139 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/board-overlays refs/changes/36/22836/1
--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 2:33:41 PM5/16/12
to
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 1: Verified

Might have some difficulty testing this one without a board, but at least it's fairly isolated, and shouldn't have any effect on other boards.

Second CL to add raspberrypi to cros-board.eclass is incoming.

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>
Gerrit-Reviewer: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 2:45:43 PM5/16/12
to
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 2: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>
Gerrit-Reviewer: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 3:31:05 PM5/16/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(20 inline comments)

....................................................
File overlay-raspberrypi/chromeos-base/chromeos-bsp-raspberrypi/chromeos-bsp-raspberrypi-0.0.1.ebuild
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2012

Line 6: inherit toolchain-funcs
you don't need this

Line 13: IUSE="opengles"
or this

....................................................
File overlay-raspberrypi/sys-kernel/raspberrypi-kernel/raspberrypi-kernel-3.1.9.ebuild
Line 17: KEYWORDS="amd64 arm x86"
only want arm i would think

....................................................
File overlay-raspberrypi/virtual/linux-sources/linux-sources-0.0.2.ebuild
Line 11: KEYWORDS="amd64 arm x86"
only want arm i think

....................................................
File overlay-raspberrypi/virtual/opengles/opengles-2.ebuild
Line 1: # Copyright (c) 2011 The Chromium OS Authors. All rights reserved.
2012

Line 8: KEYWORDS="alpha amd64 arm hppa ia64 mips ppc ppc64 sh sparc x86 ~x86-fbsd"
only need arm

....................................................
File overlay-raspberrypi/x11-drivers/opengles-bin/opengles-bin-0.0.1.ebuild
Line 1: # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
2012

Line 4: EAPI=2
set to 4, then drop all the `die` calls in src_install

Line 36: insinto /usr/lib
drop this

Line 37: newins libEGL.so libEGL.so.1 || die
newlib.so libEGL.so libEGL.so.1

Line 38: fperms 0755 /usr/lib/libEGL.so.1 || die
don't need this anymore

Line 41: newins libGLESv2.so libGLESv2.so.2 || die
newlib.so

Line 42: fperms 0755 /usr/lib/libGLESv2.so.2 || die
drop

Line 45: newins libbcm_host.so libbcm_host.so || die
dolib.so

Line 46: fperms 0755 /usr/lib/libbcm_host.so || die
drop

Line 48: newins libvchiq_arm.so libvchiq_arm.so || die
dolib.so

Line 49: fperms 0755 /usr/lib/libvchiq_arm.so || die
drop

Line 51: newins libvcos.so libvcos.so || die
dolib.so

Line 52: fperms 0755 /usr/lib/libvcos.so || die
drop

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>
Gerrit-Reviewer: Liam McLoughlin <hex...@hexxeh.net>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 3:42:09 PM5/16/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 3: Verified

Fixed all the points noted in comments to the previous set

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 3:56:43 PM5/16/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 3: (3 inline comments)

....................................................
File overlay-raspberrypi/make.conf
Line 3: MARCH_TUNE="-march=armv6zk -mtune=arm1176jzf-s -mfloat-abi=hard -mfpu=vfp"
i guess this is thumb, but not thumb2, and that's what chrome uses ?

....................................................
File overlay-raspberrypi/x11-drivers/opengles-bin/opengles-bin-0.0.1.ebuild
Line 37: dosym libEGL.so.1 /usr/lib/libEGL.so || die
you can drop these `die`

Line 42: dolib.so libbcm_host.so libbcm_host.so || die
only need to specify the file name once. and you can merge these three statements into one:

dolib.so libbcm_host.so libvchiq_arm.so libvcos.so

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 4:02:43 PM5/16/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 4: Verified

Was convinced I'd removed those "die" parts, damn, all fixed.

Yep, thumb but no thumb2. Built toolchain by running following in chroot as root:

USE="-thumb -hardened hardfp" FEATURES="splitdebug" crossdev -S -t armv6j-cros-linux-gnueabi --ex-gdb

Couldn't find any way of specifying this inside the board overlay that worked. I think specifying -thumb actually disables thumb altogether, but without that, crossdev fails to build any armv6 toolchain.

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 4:47:39 PM5/16/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 4: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 5:01:45 PM5/16/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 4: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 5:21:39 PM5/16/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 4: Fails

hrm, we're going to have to rethink the toolchain.conf stuff. we don't want toolchains for boards we don't care about being included in our builds.

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
May 16, 2012, 5:25:06 PM5/16/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................




--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
Jun 18, 2012, 1:27:47 AM6/18/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 5: Fails

(1 inline comment)

....................................................
File overlay-raspberrypi/toolchain.conf
Line 1: armv6j-cros-linux-gnueabi
change to:

armv6j-cros-linux-gnueabi { "sdk":false }

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
Jun 18, 2012, 1:33:16 PM6/18/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 6: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Mike Frysinger (Code Review)

unread,
Jun 18, 2012, 8:59:38 PM6/18/12
to Liam McLoughlin, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 6: Looks good to me, approved

seems to be passing bots now :)

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>

Liam McLoughlin (Code Review)

unread,
Jun 18, 2012, 9:29:47 PM6/18/12
to Mike Frysinger
Liam McLoughlin has posted comments on this change.

Change subject: Initial commit of Raspberry Pi board
......................................................................


Patch Set 6: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22836
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cac20e7d5ec8de74f255f1d0f0b2118d54fe84e
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/overlays/board-overlays
Gerrit-Branch: master
Gerrit-Owner: Liam McLoughlin <hex...@hexxeh.net>
Reply all
Reply to author
Forward
0 new messages