CHROMIUM: Input: cyapa - Use a strncmp to check product_id s... [chromiumos/third_party/kernel : chromeos-3.4]

1 view
Skip to first unread message

Benson Leung (Code Review)

unread,
Oct 24, 2012, 5:52:19 PM10/24/12
to Olof Johansson, Mandeep Singh Baines
Benson Leung has uploaded a new change for review.

Change subject: CHROMIUM: Input: cyapa - Use a strncmp to check product_id string
......................................................................

CHROMIUM: Input: cyapa - Use a strncmp to check product_id string

Use a strncmp instead of memcmp to check that the beginning
of the product_id string is "CYTRA"

Signed-off-by: Benson Leung <ble...@chromium.org>

BUG=chromium-os:21047
TEST=builds clean
Check that trackpad is functional.

Change-Id: I5fe60c7175ea965f5946b486a753ce08c3b5b954
---
M drivers/input/mouse/cyapa.c
1 file changed, 2 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/78/36478/1
--
To view, visit https://gerrit.chromium.org/gerrit/36478
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5fe60c7175ea965f5946b486a753ce08c3b5b954
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Benson Leung <ble...@chromium.org>

Daniel Kurtz (Code Review)

unread,
Oct 24, 2012, 5:58:58 PM10/24/12
to Benson Leung, Yufeng Shen, Dudley Du
Daniel Kurtz has posted comments on this change.

Change subject: CHROMIUM: Input: cyapa - Use a strncmp to check product_id string
......................................................................


Patch Set 1: (1 inline comment)

why?

....................................................
File drivers/input/mouse/cyapa.c
Line 1008: strlen(unique_str))) {
why?

--
To view, visit https://gerrit.chromium.org/gerrit/36478
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5fe60c7175ea965f5946b486a753ce08c3b5b954
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Benson Leung <ble...@chromium.org>
Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djk...@chromium.org>
Gerrit-Reviewer: Dudley Du <du...@cypress.com>
Gerrit-Reviewer: Yufeng Shen <mil...@chromium.org>

Benson Leung (Code Review)

unread,
Oct 24, 2012, 6:07:15 PM10/24/12
to Daniel Kurtz, Yufeng Shen, Dudley Du
Benson Leung has abandoned this change.

Change subject: CHROMIUM: Input: cyapa - Use a strncmp to check product_id string
......................................................................


Patch Set 1: Abandoned

--
To view, visit https://gerrit.chromium.org/gerrit/36478
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I5fe60c7175ea965f5946b486a753ce08c3b5b954
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Benson Leung <ble...@chromium.org>
Reply all
Reply to author
Forward
0 new messages