sys-apps: Add mtderase utility. [chromiumos/overlays/chromiumos-overlay : master]
4 views
Skip to first unread message
Bryan Freed (Code Review)
May 15, 2012, 7:01:06 PM5/15/12
to
Bryan Freed has uploaded a new change for review.
Change subject: sys-apps: Add mtderase utility.
......................................................................
sys-apps: Add mtderase utility.
Add an ebuild file for building the simple mtderase utility in
the files directory.
BUG=chrome-os-partner:9081
TEST=Manually confirm mtderase erases the MTD part:
dd if=/dev/mtd0 count=1 bs=64 | od
mtderase /dev/mtd0
dd if=/dev/mtd0 count=1 bs=64 | od
Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
---
M chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-9999.ebuild
M chromeos-base/chromeos-installer/chromeos-installer-9999.ebuild
A sys-apps/mtderase/files/Makefile
A sys-apps/mtderase/files/mtderase.c
A sys-apps/mtderase/mtderase-0.0.1.ebuild
5 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/65/22765/1
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Change subject: sys-apps: Add mtderase utility.
......................................................................
sys-apps: Add mtderase utility.
Add an ebuild file for building the simple mtderase utility in
the files directory.
BUG=chrome-os-partner:9081
TEST=Manually confirm mtderase erases the MTD part:
dd if=/dev/mtd0 count=1 bs=64 | od
mtderase /dev/mtd0
dd if=/dev/mtd0 count=1 bs=64 | od
Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
---
M chromeos-base/chromeos-factoryinstall/chromeos-factoryinstall-9999.ebuild
M chromeos-base/chromeos-installer/chromeos-installer-9999.ebuild
A sys-apps/mtderase/files/Makefile
A sys-apps/mtderase/files/mtderase.c
A sys-apps/mtderase/mtderase-0.0.1.ebuild
5 files changed, 101 insertions(+), 0 deletions(-)
git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/65/22765/1
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Mike Frysinger (Code Review)
May 16, 2012, 12:28:35 AM5/16/12
to Bryan Freed, Mike Frysinger
Mike Frysinger has posted comments on this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1:
why not use the standard mtd-utils package instead of writing your own ?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Change subject: sys-apps: Add mtderase utility.
......................................................................
why not use the standard mtd-utils package instead of writing your own ?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Bryan Freed (Code Review)
May 16, 2012, 1:01:05 AM5/16/12
to Mike Frysinger
Bryan Freed has posted comments on this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1:
It seemed like overkill at the time.
It might be worth a relook at some point, but for now this is a temporary utility for use until we get flashrom working.
By the way, I am not sure I got the dependancies right.
I put them in chromeos-factoryinstall and chromeos-installer, but my build from earlier this evening appeared not to pick up this ebuild. Maybe that was because https://gerrit-int.chromium.org/#change,17449 (since merged) was also in my tree, and that took precedence?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Change subject: sys-apps: Add mtderase utility.
......................................................................
It seemed like overkill at the time.
It might be worth a relook at some point, but for now this is a temporary utility for use until we get flashrom working.
By the way, I am not sure I got the dependancies right.
I put them in chromeos-factoryinstall and chromeos-installer, but my build from earlier this evening appeared not to pick up this ebuild. Maybe that was because https://gerrit-int.chromium.org/#change,17449 (since merged) was also in my tree, and that took precedence?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-Reviewer: Bryan Freed <bfr...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Mike Frysinger (Code Review)
May 16, 2012, 1:15:10 AM5/16/12
to Bryan Freed, Mike Frysinger
Mike Frysinger has posted comments on this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1:
importing packages into the tree from upstream is trivial
cros_portage_upgrade --boards amd64-generic:arm-generic:x86-generic --upgrade mtd-utils
it def should take less time than writing any util from scratch ;)
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Change subject: sys-apps: Add mtderase utility.
......................................................................
importing packages into the tree from upstream is trivial
cros_portage_upgrade --boards amd64-generic:arm-generic:x86-generic --upgrade mtd-utils
it def should take less time than writing any util from scratch ;)
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Bryan Freed (Code Review)
May 16, 2012, 1:36:08 AM5/16/12
to Mike Frysinger
Bryan Freed has posted comments on this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1:
> cros_portage_upgrade --boards amd64-generic:arm-generic:x86-generic --upgrade mtd-utils
What does this command do?
Does it add an ebuild? Where?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Change subject: sys-apps: Add mtderase utility.
......................................................................
> cros_portage_upgrade --boards amd64-generic:arm-generic:x86-generic --upgrade mtd-utils
Does it add an ebuild? Where?
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Mike Frysinger (Code Review)
May 16, 2012, 12:08:01 PM5/16/12
to Bryan Freed, Mike Frysinger
Mike Frysinger has posted comments on this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1:
run it in the chroot and it'll add an ebuild to the portage-stable overlay for you to upload like normal
i've created one now:
https://gerrit.chromium.org/gerrit/22822
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: comment
Change subject: sys-apps: Add mtderase utility.
......................................................................
run it in the chroot and it'll add an ebuild to the portage-stable overlay for you to upload like normal
i've created one now:
https://gerrit.chromium.org/gerrit/22822
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Bryan Freed (Code Review)
May 16, 2012, 4:18:49 PM5/16/12
to Mike Frysinger
Bryan Freed has abandoned this change.
Change subject: sys-apps: Add mtderase utility.
......................................................................
Patch Set 1: Abandoned
Ok, let's go with the mtd-utils solution of https://gerrit.chromium.org/gerrit/#change,22822.
flash_erase of mtd-utils provides the same functionality plus the ability to specify the start and length to erase.
Other utilities (like flash_[un]lock) would be useful if they worked.
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-MessageType: abandon
Change subject: sys-apps: Add mtderase utility.
......................................................................
Ok, let's go with the mtd-utils solution of https://gerrit.chromium.org/gerrit/#change,22822.
flash_erase of mtd-utils provides the same functionality plus the ability to specify the start and length to erase.
Other utilities (like flash_[un]lock) would be useful if they worked.
--
To view, visit https://gerrit.chromium.org/gerrit/22765
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings
Gerrit-Change-Id: I9b1dd61bbdcf070f50fe60540102e77e9c68766a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Bryan Freed <bfr...@chromium.org>
Reply all
Reply to author
Forward
0 new messages