Re: add keyboard driver in st1.5 (issue723001)

[nle...@codeaurora.org]

Similar comments to the trackpad driver re signed-off-by line etc. Thanks!

http://codereview.chromium.org/723001/diff/4001/5001
File arch/arm/mach-msm/board-qsd8x50.c (right):

http://codereview.chromium.org/723001/diff/4001/5001#newcode1971
arch/arm/mach-msm/board-qsd8x50.c:1971: .irq = KEYBOARD_INT_GPIO
These changes in the board-qsd8x50.c file are correct, but they
shouldn't be included in this patch. Changes in the driver tree and
mach-msm tree should be in separate patches. Please remove
board-qsd8x50.c from this patch. Qualcomm can add the mach-msm patch.

http://codereview.chromium.org/723001/diff/4001/5002
File drivers/input/keyboard/Kconfig (right):

http://codereview.chromium.org/723001/diff/4001/5002#newcode366
drivers/input/keyboard/Kconfig:366: default m
Should have a depends line such as:
depends on I2C && ARCH_MSM_SCORPION

Also it should default to 'n'. In the defconfig file for the appropriate
target system it can be selected as 'm'. Qualcomm can do that patch.

http://codereview.chromium.org/723001

[hora...@quantatw.com]

On 2010/03/11 23:13:38, nleeder wrote:

Got it, and will inform qualcomm to help to do that. thanks!

http://codereview.chromium.org/723001

[nle...@codeaurora.org]

lgtm

http://codereview.chromium.org/723001