Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium OS reviews
+ new post
About this group
Join this group
build_image: use an array for excludes [chromiumos/platform/crosutils : master]
Options
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
   3 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Mike Frysinger (Code Review)  
View profile  
 More options Nov 5 2012, 5:18 pm
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Mon, 5 Nov 2012 14:18:43 -0800
Local: Mon, Nov 5 2012 5:18 pm
Subject: build_image: use an array for excludes [chromiumos/platform/crosutils : master]
Print | Individual message | Show original | Find messages by this author
Hello David James,

I'd like you to do a code review.  Please visit

    https://gerrit.chromium.org/gerrit/37377

to review the following change.

Change subject: build_image: use an array for excludes
......................................................................

build_image: use an array for excludes

This makes a follow up commit easier to document excludes.

BUG=chromium-os:22939
TEST=build_image for daisy installs same set of files

Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
---
M build_library/base_image_util.sh
1 file changed, 8 insertions(+), 2 deletions(-)

  git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/crosutils refs/changes/77/37377/1
--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
David James (Code Review)  
View profile  
 More options Nov 5 2012, 7:47 pm
From: "David James (Code Review)" <ger...@chromium.org>
Date: Mon, 5 Nov 2012 16:47:18 -0800
Local: Mon, Nov 5 2012 7:47 pm
Subject: build_image: use an array for excludes [chromiumos/platform/crosutils : master]
Print | Individual message | Show original | Find messages by this author
David James has posted comments on this change.

Change subject: build_image: use an array for excludes
......................................................................

Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Mike Frysinger (Code Review)  
View profile  
 More options Nov 5 2012, 10:21 pm
From: "Mike Frysinger (Code Review)" <ger...@chromium.org>
Date: Mon, 5 Nov 2012 19:21:16 -0800
Local: Mon, Nov 5 2012 10:21 pm
Subject: build_image: use an array for excludes [chromiumos/platform/crosutils : master]
Print | Individual message | Show original | Find messages by this author
Mike Frysinger has posted comments on this change.

Change subject: build_image: use an array for excludes
......................................................................

Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <davidja...@chromium.org>
Gerrit-Reviewer: Gerrit <chrome-...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »

Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google