drm/exynos: vidi: Fix compilation error re: pitch [chromiumos/third_party/kernel : chromeos-3.4]

3 views
Skip to first unread message

Sean Paul (Code Review)

unread,
Oct 24, 2012, 5:44:00 PM10/24/12
to Olof Johansson, Mandeep Singh Baines
Sean Paul has uploaded a new change for review.

Change subject: drm/exynos: vidi: Fix compilation error re: pitch
......................................................................

drm/exynos: vidi: Fix compilation error re: pitch

Was getting "'struct exynos_drm_overlay' has no member named 'pitch'"
compilation errors when compiling with VIDI enabled.

BUG=None
TEST=Compiles

Change-Id: I375ba229b538b25601745d01cf1c70dcd751d275
Signed-off-by: Sean Paul <sean...@chromium.org>
---
M drivers/gpu/drm/exynos/exynos_drm_vidi.c
1 file changed, 3 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/76/36476/1
--
To view, visit https://gerrit.chromium.org/gerrit/36476
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I375ba229b538b25601745d01cf1c70dcd751d275
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Sean Paul <sean...@chromium.org>

Stéphane Marchesin (Code Review)

unread,
Oct 24, 2012, 5:46:05 PM10/24/12
to Sean Paul, Daniel Kurtz, Mandeep Singh Baines
Stéphane Marchesin has posted comments on this change.

Change subject: drm/exynos: vidi: Fix compilation error re: pitch
......................................................................


Patch Set 1: Looks good to me, approved
Gerrit-MessageType: comment
Gerrit-Change-Id: I375ba229b538b25601745d01cf1c70dcd751d275
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Sean Paul <sean...@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djk...@chromium.org>
Gerrit-Reviewer: Mandeep Singh Baines <m...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <mar...@chromium.org>

Daniel Kurtz (Code Review)

unread,
Oct 24, 2012, 5:54:53 PM10/24/12
to Sean Paul, Mandeep Singh Baines, Stéphane Marchesin
Daniel Kurtz has posted comments on this change.

Change subject: drm/exynos: vidi: Fix compilation error re: pitch
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File drivers/gpu/drm/exynos/exynos_drm_vidi.c
Line 291: DRM_DEBUG_KMS("offset = 0x%lx, pitch = %x\n", offset,
optional: fb_pitch in the debug message?
Gerrit-MessageType: comment
Gerrit-Change-Id: I375ba229b538b25601745d01cf1c70dcd751d275
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Sean Paul <sean...@chromium.org>

Sean Paul (Code Review)

unread,
Oct 26, 2012, 1:53:32 PM10/26/12
to Daniel Kurtz, Mandeep Singh Baines, Stéphane Marchesin, Gerrit
Sean Paul has posted comments on this change.

Change subject: drm/exynos: vidi: Fix compilation error re: pitch
......................................................................


Patch Set 2: Verified; Looks good to me, approved; Ready

Carrying +2 forward.
Gerrit-MessageType: comment
Gerrit-Change-Id: I375ba229b538b25601745d01cf1c70dcd751d275
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Sean Paul <sean...@chromium.org>
Gerrit-Reviewer: Daniel Kurtz <djk...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mandeep Singh Baines <m...@chromium.org>
Gerrit-Reviewer: Sean Paul <sean...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <mar...@chromium.org>
Reply all
Reply to author
Forward
0 new messages