Audio feedback test: assert audio loopback dongle plugged. [chromiumos/third_party/autotest : master]

38 views
Skip to first unread message

Hsinyu Chao (Code Review)

unread,
Nov 5, 2012, 6:01:02 AM11/5/12
to
Hsinyu Chao has uploaded a new change for review.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................

Audio feedback test: assert audio loopback dongle plugged.

Use amixer to look up 'Mic Jack' control, if it exist then
assert its value be 'on', since we require audio feedback test
run with audio loopback dongle equipped. If that control does
not exist, log and skip the check.

BUG=chromium-os:36035
TEST=Manual run audio feedback tests with and without audio loopback
dongle plugged, see expected behavior.

Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
---
M client/cros/audio/audio_helper.py
M client/site_tests/desktopui_AudioFeedback/desktopui_AudioFeedback.py
M client/site_tests/desktopui_MediaAudioFeedback/desktopui_MediaAudioFeedback.py
3 files changed, 52 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/50/37350/1
--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Dylan Reid (Code Review)

unread,
Nov 5, 2012, 11:38:10 AM11/5/12
to Hsinyu Chao, Gerrit, Rohit Makasana
Dylan Reid has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 1: (1 inline comment)

Would it be helpful to check the headphone jack as well? For systems like ZGB that have separate jacks, it might catch a few more cases.

....................................................
File client/site_tests/desktopui_MediaAudioFeedback/desktopui_MediaAudioFeedback.py
Line 108: def check_loopback_dongle(self):
Could this code go into the audio helper as well to avoid duplication?

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Rohit Makasana <roh...@chromium.org>

Hsinyu Chao (Code Review)

unread,
Nov 5, 2012, 11:28:22 PM11/5/12
to Gerrit, Rohit Makasana, Dylan Reid
Hsinyu Chao has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 1: (1 inline comment)

Thanks for your suggestion. Added headphone jack check as well.

....................................................
File client/site_tests/desktopui_MediaAudioFeedback/desktopui_MediaAudioFeedback.py
Line 108: def check_loopback_dongle(self):
Done

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>
Gerrit-Reviewer: Rohit Makasana <roh...@chromium.org>

Rohit Makasana (Code Review)

unread,
Nov 6, 2012, 1:45:56 AM11/6/12
to Hsinyu Chao, Gerrit, Dylan Reid
Rohit Makasana has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Dylan Reid (Code Review)

unread,
Nov 6, 2012, 12:06:30 PM11/6/12
to Hsinyu Chao, Gerrit, Rohit Makasana
Dylan Reid has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Dylan Reid (Code Review)

unread,
Nov 6, 2012, 12:07:07 PM11/6/12
to Hsinyu Chao, Gerrit, Rohit Makasana
Dylan Reid has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 2:

FYI, you will never see these jacks on ARM as they still use /dev/input to signal jacks.

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>

Hsinyu Chao (Code Review)

unread,
Nov 6, 2012, 11:00:06 PM11/6/12
to Gerrit, Rohit Makasana, Dylan Reid
Hsinyu Chao has posted comments on this change.

Change subject: Audio feedback test: assert audio loopback dongle plugged.
......................................................................


Patch Set 2: Verified; Ready

Thanks for reminding. I just took a look and it seems a bit complicated to get jack status from input event using python.
I will have separate CL for that. Merge this change first so we can get jack info during audio tests for most of devices.

--
To view, visit https://gerrit.chromium.org/gerrit/37350
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19ae1790bdaebd4ecaca166bad06a77cbff20bc5
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Hsinyu Chao <hyc...@chromium.org>
Reply all
Reply to author
Forward
0 new messages