kernel-next : chromeos-3.4-rc4 branch compiles

55 views
Skip to first unread message

Grant Grundler

unread,
Apr 27, 2012, 1:56:59 PM4/27/12
to Chromium OS dev
Hi,

I've quietly pushed the following branches to kernel-next repo:
chromeos-3.4-rc4
chromeos-base-3.4-rc4
chromeos-misc-3.4-rc4
chromeos-input-3.4-rc4
chromeos-platform-3.4-rc4
chromeos-seccomp-3.4-rc4
chromeos-wifi-3.4-rc4
chromeos-verity-3.4-rc4

Note that I have the same concerns as I listed for chromeos-3.4-rc3
email I sent a few minutes ago:
1) ath9k patches need to be reviewed
2) tpm patches we are carrying appear to contradict code from
upstream. This needs to be cleaned up.
3) I ran "rebase -i v3.4-rc4" on the seccomp topic branch and dropped
everything that looked like it was from other branches.

I'll pester folks to see how they'd like those concerns addressed.

chromeos-3.4-rc4 compiles on all x86 flavors:
(cr) (chromeos-3.4-rc4) grundler@grundler
~/trunk/src/third_party/kernel-next $ ~/buildall-cros
 cleaning                       [00:04]  done
 prepareconfig chromiumos-x86_64 [00:00]  done
 chromiumos-x86_64              [01:20]  passed, 10 warnings
 cleaning                       [00:03]  done
 prepareconfig chromeos-intel-pineview [00:00]  done
 chromeos-intel-pineview        [01:21]  passed, 10 warnings
 cleaning                       [00:03]  done
 prepareconfig chromeos-pinetrail-i386 [00:00]  done
 chromeos-pinetrail-i386        [01:18]  passed, 10 warnings
 cleaning                       [00:03]  done
 prepareconfig chromiumos-i386  [00:00]  done
 chromiumos-i386                [01:31]  passed, 12 warnings
 cleaning                       [00:03]  done
 prepareconfig chromeos-intel-menlow [00:00]  done
 chromeos-intel-menlow          [01:17]  passed, 10 warnings


cheers,
grant

Grant Grundler

unread,
Apr 27, 2012, 4:34:59 PM4/27/12
to Chromium OS dev
On Fri, Apr 27, 2012 at 10:56 AM, Grant Grundler <grun...@chromium.org> wrote:
> Hi,
>
> I've quietly pushed the following branches to kernel-next repo:
> chromeos-3.4-rc4

Ran "BVT" test suite: 30/32 pass

INFO    : Test results:
---------------------------------------------------------
suites.bvt/build_RootFilesystemSize           [  PASSED  ]
suites.bvt/build_RootFilesystemSize             bytes_rootfs_prod
                    653860864.0
suites.bvt/build_RootFilesystemSize             bytes_rootfs_test
                    653963264.0
suites.bvt/desktopui_FlashSanityCheck         [  PASSED  ]
suites.bvt/desktopui_KillRestart.chrome       [  PASSED  ]
suites.bvt/desktopui_KillRestart.session      [  PASSED  ]
suites.bvt/desktopui_ScreenLocker             [  PASSED  ]
suites.bvt/desktopui_UrlFetch.not-live        [  PASSED  ]
suites.bvt/logging_CrashSender                [  PASSED  ]
suites.bvt/logging_UserCrash                  [  PASSED  ]
suites.bvt/login_BadAuthentication            [  PASSED  ]
suites.bvt/login_CryptohomeIncognitoMounted   [  PASSED  ]
suites.bvt/login_CryptohomeIncognitoUnmounted [  PASSED  ]
suites.bvt/login_CryptohomeMounted            [  PASSED  ]
suites.bvt/login_CryptohomeUnmounted          [  PASSED  ]
suites.bvt/login_LoginSuccess                 [  PASSED  ]
suites.bvt/login_OwnershipApi                 [  PASSED  ]
suites.bvt/login_RemoteLogin                  [  PASSED  ]
suites.bvt/network_DisableInterface.wifi_only [  PASSED  ]
suites.bvt/network_Ping                       [  PASSED  ]
suites.bvt/platform_AccurateTime              [  PASSED  ]
suites.bvt/platform_AccurateTime                seconds_offset
                    0.0
suites.bvt/platform_CryptohomeChangePassword  [  PASSED  ]
suites.bvt/platform_CryptohomeMount           [  PASSED  ]
suites.bvt/platform_CryptohomeTestAuth        [  FAILED  ]
suites.bvt/platform_FilePerms                 [  FAILED  ]
suites.bvt/platform_FilePerms                   FAIL: Found 1 permission errors
suites.bvt/platform_HighResTimers             [  PASSED  ]
suites.bvt/platform_KernelVersion             [  PASSED  ]
suites.bvt/platform_OSLimits                  [  PASSED  ]
suites.bvt/platform_PartitionCheck            [  PASSED  ]
suites.bvt/platform_RootPartitionsNotMounted  [  PASSED  ]
suites.bvt/platform_Shutdown                  [  PASSED  ]
suites.bvt/platform_Shutdown                    seconds_shutdown
                    0.0999999999999
suites.bvt/platform_Shutdown                    sectors_read_shutdown
                    600.0
suites.bvt/platform_Shutdown
sectors_written_shutdown                    8.0
suites.bvt/power_Resume                       [  PASSED  ]
suites.bvt/power_Resume                         num_retry_attempts
                    0
suites.bvt/power_Resume                         seconds_3G_disconnect
                    0
suites.bvt/power_Resume                         seconds_system_resume
                    0.936738014221
suites.bvt/power_Resume
seconds_system_resume_firmware              0.549828014221
suites.bvt/power_Resume
seconds_system_resume_kernel                0.38691
suites.bvt/power_Resume
seconds_system_resume_kernel_cpu            0.0141940000001
suites.bvt/power_Resume
seconds_system_resume_kernel_dev            0.362971
suites.bvt/power_Resume                         seconds_system_suspend
                    0.995725
suites.bvt/security_ProfilePermissions.BWSI   [  PASSED  ]
suites.bvt/security_ProfilePermissions.login  [  PASSED  ]
---------------------------------------------------------
Total PASS: 30/32 (93%)
>>> Details stored under /tmp/run_remote_tests.aSDo


I've not run BVT to understand if this is recent regression (e.g.
FilePerms) or how it could be kernel related (maybe something under
/proc or /sys).  I'll ignore for now and repeat/pursue with -rc5 next
week.

cheers,
grant

Grant Grundler

unread,
Apr 27, 2012, 5:18:48 PM4/27/12
to Chromium OS dev
On Fri, Apr 27, 2012 at 1:34 PM, Grant Grundler <grun...@chromium.org> wrote:
> On Fri, Apr 27, 2012 at 10:56 AM, Grant Grundler <grun...@chromium.org> wrote:
>> Hi,
>>
>> I've quietly pushed the following branches to kernel-next repo:
>> chromeos-3.4-rc4
>
> Ran "BVT" test suite: 30/32 pass

And ran "regression" (which seems to have very few tests...must be
running the wrong flavor):
3/5 passed

INFO : Test results:
---------------------------------------------------------------------
suites.kernel_daily_regression/hardware_SAT [ PASSED ]
suites.kernel_daily_regression/hardware_Trackpad [ FAILED ]
suites.kernel_daily_regression/hardware_Trackpad FAIL:
Unhandled TypeError: coercing to Unicode: need string or buffer,
NoneType found
suites.kernel_daily_regression/platform_BootDevice.stress [ PASSED ]
suites.kernel_daily_regression/platform_KernelErrorPaths [ FAILED ]
suites.kernel_daily_regression/platform_KernelErrorPaths FAIL:
Unhandled AutoservShutdownError: Host did not shut down
suites.kernel_daily_regression/platform_KernelErrorPaths 04/27
20:50:21 ERROR|base_utils:0113| [stderr] Warning: Permanently added
'172.22.75.44' (RSA) to the list of known hosts.
suites.kernel_daily_regression/platform_KernelErrorPaths 04/27
20:51:30 ERROR|base_utils:0113| [stderr] Warning: Permanently added
'172.22.75.44' (RSA) to the list of known hosts.
suites.kernel_daily_regression/platform_KernelErrorPaths 04/27
20:54:47 ERROR|base_utils:0113| [stderr] Warning: Permanently added
'172.22.75.44' (RSA) to the list of known hosts.
suites.kernel_daily_regression/scrashme [ PASSED ]
---------------------------------------------------------------------
Total PASS: 3/5 (60%)
>>> Details stored under /tmp/run_remote_tests.njmQ

Trackpad might be a 3.4-rc4 kernel bug.

cheers,
grant

Rajkumar Manoharan

unread,
May 13, 2012, 5:52:04 AM5/13/12
to Chromium OS dev, Grant Grundler
Grant,

Im unable to bring up 3.4-rc5 kernel on alex. I did the board setup as

setup_board --board=x86-generic --profile=kernel-next --
latest_toolchain --fast --jobs=5 --kernel_version=3.4

--
Rajkumar

Rajkumar Manoharan

unread,
May 13, 2012, 7:02:47 AM5/13/12
to Chromium OS dev, Rajkumar Manoharan, Grant Grundler
Grant,

I can bring up 3.4-rc4 image successfully.

--
Rajkumar

On May 13, 2:52 pm, Rajkumar Manoharan
<rajkumar....@chromium.org> wrote:
> Grant,
>
> Im unable to bring up3.4-rc5kernel on alex. I did the board setup as

Benson Leung

unread,
May 14, 2012, 12:52:14 PM5/14/12
to Grant Grundler, Rajkumar Manoharan, Chromium OS dev, Daniel Kurtz
+djkurtz.

Grant,

Dan and I should be able to help you with this today or tomorrow.

Benson

On Mon, May 14, 2012 at 9:26 AM, Grant Grundler <grun...@chromium.org> wrote:
> On Sun, May 13, 2012 at 2:52 AM, Rajkumar Manoharan
> <rajkumar....@chromium.org> wrote:
>> Grant,
>>
>> Im unable to bring up 3.4-rc5 kernel on alex. I did the board setup as
>>
>> setup_board --board=x86-generic --profile=kernel-next --
>> latest_toolchain --fast --jobs=5 --kernel_version=3.4
>
> Rajkumar,
> Your board setup isn't the problem. The problem is a bad patch that I
> pushed on Friday to chromeos-3.4-rc5 branch. My apologies.
>
> I've git bisected and found this patch prevented my alex machine from booting:
>   [67ebfae56ea11673229a342187ab937a167f4e14] CHROMIUM:
> drm/i915/intel_i2c: refactor using intel_gmbus_get_adapter
>
> I haven't tested if just reverting this patch is sufficient.
>
> I'll dig into this patch to figure out what I messed up when merging
> in i915 code. This should be resolved today..
>
> cheers,
> grant
>
> --
> Chromium OS Developers mailing list: chromiu...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en



--
Benson Leung
Software Engineer, Chrom* OS
ble...@chromium.org

Rajkumar Manoharan

unread,
May 15, 2012, 9:40:20 AM5/15/12
to Chromium OS dev, Benson Leung, Grant Grundler, Rajkumar Manoharan, Daniel Kurtz
Grant,

I just noticed that ASPM is disabled in 3.4.0-rc4 in my Alex m/c. I
chose board type as x86-generic instead of x86-alex. Is that the
problem?
Or how do I enable it by default?

--
Rajkumar

On May 14, 9:52 pm, Benson Leung <ble...@chromium.org> wrote:
> +djkurtz.
>
> Grant,
>
> Dan and I should be able to help you with this today or tomorrow.
>
> Benson
>
>
>
>
>
>
>
>
>
> On Mon, May 14, 2012 at 9:26 AM, Grant Grundler <grun...@chromium.org> wrote:
> > On Sun, May 13, 2012 at 2:52 AM, Rajkumar Manoharan
> > <rajkumar....@chromium.org> wrote:
> >> Grant,
>
> >> Im unable to bring up3.4-rc5 kernel on alex. I did the board setup as

Grant Grundler

unread,
May 15, 2012, 1:07:57 PM5/15/12
to Rajkumar Manoharan, Chromium OS dev, Benson Leung, Daniel Kurtz
On Tue, May 15, 2012 at 6:40 AM, Rajkumar Manoharan
<rajkumar....@chromium.org> wrote:
> Grant,
>
> I just noticed that ASPM is disabled in 3.4.0-rc4 in my Alex m/c. I
> chose board type as x86-generic instead of x86-alex. Is that the
> problem?

I suspect 3.4.0-rc4 doesn't contain one of the patches that deals with ASPM:
CHROMIUM:drivers:acpi: REWRITE "Do not clear ASPM for Mario and
Alex" for 3.2.7

I don't believe there is any significant difference between
x86-generic and x86-alex configurations.

> Or how do I enable it by default?

I hope it's as simple as adding the above patch...but I'm not working
-rc4 (never have).

I'm hoping djkurtz and I can sort out the i915/gmbus issue on 3.4-rc7
branch today.

For now, you can try the kernel-next/chromeos-3.4-rc3 branch even
though that will be missing a large number of trackpad and i915
patches. At least -rc3 should boot on alex.

cheers,
grant

Rajkumar Manoharan

unread,
May 15, 2012, 1:43:02 PM5/15/12
to Chromium OS dev, Grant Grundler, Rajkumar Manoharan, Benson Leung, Daniel Kurtz


On May 15, 10:07 pm, Grant Grundler <grun...@chromium.org> wrote:
> On Tue, May 15, 2012 at 6:40 AM, Rajkumar Manoharan
>
> <rajkumar....@chromium.org> wrote:
> > Grant,
>
> > I just noticed that ASPM is disabled in 3.4.0-rc4 in my Alex m/c. I
> > chose board type as x86-generic instead of x86-alex. Is that the
> > problem?
>
> I suspect 3.4.0-rc4 doesn't contain one of the patches that deals with ASPM:
>     CHROMIUM:drivers:acpi: REWRITE "Do not clear ASPM for Mario and
> Alex" for 3.2.7
>
No. it has the patch.

git commit --oneline --grep "Do not clear ASPM"

bded7b7 CHROMIUM:drivers:acpi: REWRITE "Do not clear ASPM for Mario
and Alex" for 3.2.7

> I don't believe there is any significant difference between
> x86-generic and x86-alex configurations.
>
> > Or how do I enable it by default?
>
> I hope it's as simple as adding the above patch...but I'm not working
> -rc4 (never have).
>
> I'm hoping djkurtz and I can sort out the i915/gmbus issue on 3.4-rc7
> branch today.
>
> For now, you can try the kernel-next/chromeos-3.4-rc3 branch even
> though that will be missing a large number of trackpad and i915
> patches. At least -rc3 should boot on alex.

I believe that all 3.4-rcX has the aspm issue. I checked only on rc1.
I could not verify it on rc5 as I had issues in booting up Alex.

--
Rajkumar

Grant Grundler

unread,
May 16, 2012, 12:51:19 AM5/16/12
to Daniel Kurtz, Benson Leung, Rajkumar Manoharan, Chromium OS dev
On Mon, May 14, 2012 at 4:52 PM, Benson Leung <ble...@chromium.org> wrote:
> +djkurtz.
>
> Grant,
>
> Dan and I should be able to help you with this today or tomorrow.

Thanks Benson! And kudos to Dan since he unraveled the issues with
the intel_i2c.c code that was causing the problems. Dan also reworked
the series of patches in chromeos-base-3.4 that deal with intel
gmbus/i2c support so I could drop them into a seperate branch
(chromeos-intel_i2c-3.4 in kernel-next).

I should also thank Will Drewery for similar work that I used to build
chromeos-security-3.4 branch (also pushed to kernel-next).

I've pushed chromeos-3.4 (based on -rc7 still) branch to kernel-next.
This boots on Alex and a newer x86 machine. I've not tested on cr48 or
Acer ZGB. (I'm writing this email from home via wireless using my
build on an Alex).

Rajkumar, can you please try the chromeos-3.4 branch and let me know
how that goes?
I'm still running tests on that branch but initial results look promising.

thanks!
grant

Rajkumar Manoharan

unread,
May 16, 2012, 7:48:34 AM5/16/12
to Chromium OS dev, Grant Grundler, Daniel Kurtz, Benson Leung, Rajkumar Manoharan
Thanks Grant for pushing 3.4.0-rc7. I can able to boot up Alex without
issues.
But still ASPM is disabled. How do i enable support to setpci
commands?

--
Rajkumar

Grant Grundler

unread,
May 16, 2012, 12:38:58 PM5/16/12
to Rajkumar Manoharan, Chromium OS dev, Daniel Kurtz, Benson Leung
On Wed, May 16, 2012 at 4:48 AM, Rajkumar Manoharan
<rajkumar....@chromium.org> wrote:
...
>> Rajkumar, can you please try the chromeos-3.4 branch and let me know
>> how that goes?
>> I'm still running tests on that branch but initial results look promising.
>>
> Thanks Grant for pushing 3.4.0-rc7. I can able to boot up Alex without
> issues.
> But still ASPM is disabled. How do i enable support to setpci
> commands?

The kernel should be automatically setting that up. I'll look into it
this morning.

BTW, test results are dismal. :( I'll rerun for alex this morning so
I can post results.

cheers,
grant
Reply all
Reply to author
Forward
This conversation is locked
You cannot reply and perform actions on locked conversations.
0 new messages