Revert "cros_mark_as_stable: push down cwd" [chromiumos/chromite : master]

0 views
Skip to first unread message

Peter Mayo (Code Review)

unread,
May 15, 2012, 4:31:10 PM5/15/12
to David James, Chris Sosa, Mike Frysinger, Bernie Thompson
Peter Mayo has submitted this change and it was merged.

Change subject: Revert "cros_mark_as_stable: push down cwd"
......................................................................


Revert "cros_mark_as_stable: push down cwd"

This reverts commit 393903d60b78fe8c2812acbc68ae25466225f8bf

It broke http://chromegw/i/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/builds/1935/steps/Uprev/logs/stdio

with
INFO: 12:50:42: RunCommand: ['cros_sdk', '--', '../../chromite/buildbot/cros_mark_chrome_as_stable', u'--tracking_branch=master', '--boards=amd64-generic', '--force_revision=137208', 'spec'] in /b/cbuild.amd64/src/scripts
Traceback (most recent call last):

File "../../chromite/buildbot/cros_mark_chrome_as_stable", line 516, in <module>
main()

File "../../chromite/buildbot/cros_mark_chrome_as_stable", line 497, in main
tracking_branch)

TypeError: __init__() takes exactly 4 arguments (3 given)
---
M buildbot/cros_mark_as_stable.py
M buildbot/cros_mark_as_stable_unittest.py
M buildbot/portage_utilities.py
M buildbot/portage_utilities_unittest.py
4 files changed, 78 insertions(+), 78 deletions(-)

Approvals:
Chris Sosa: Looks good to me, approved
Peter Mayo: Verified
Bernie Thompson: Looks good to me, but someone else must approve


--
To view, visit https://gerrit.chromium.org/gerrit/22730
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I65a32027b562b8a245c02ea1b4a2260f42f37608
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Peter Mayo <pete...@chromium.org>
Gerrit-Reviewer: Bernie Thompson <bhtho...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Peter Mayo <pete...@chromium.org>
Reply all
Reply to author
Forward
0 new messages