Issue 36181 in chromium-os: Crash Reporting is enabled during BWSI (Guest) session

[chrom...@googlecode.com]

Status: Untriaged
Owner: ----
CC: kr...@chromium.org, rohi...@chromium.org
Labels: Type-Regression Pri-1 Area-Logging Sev-1 Mstone-25 Arch-All

New issue 36181 by son...@chromium.org: Crash Reporting is enabled during
BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

Chrome Version : 25.0.1315.1
OS Version : 3160.0.0
Type of computer : All


Please specify Area- Crash reporting

What steps will reproduce the problem?
1. Power on device and sign in to the guest session.
2. Go to VT2 (Ctrl +Alt +F2)
3. Run the commands.
a) metrics_client -c && echo $?
b) sudo pkill -SEGV shill
c) sudo SECONDS_SEND_SPREAD=1 /sbin/crash_sender

What is the expected output?
a) Nothing should be displayed.
b) should not generate dmp files.
c) should not upload the dmp files.

What do you see instead?
a) Getting "0" ( means enabled)
b) Getting .dmp and .meta files in /var/spool/crash directory.
c) dmp files are uploaded successfully.

How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always

[chrom...@googlecode.com]

Comment #1 on issue 36181 by son...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

logs are present at
http://cros-hwqual-5.mtv.corp.google.com/bugs/36181/log-110912-045139.tar.bz2

[chrom...@googlecode.com]

Updates:
Labels: ReleaseBlock-Dev

Comment #2 on issue 36181 by rohi...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

(No comment was entered for this change.)

[chrom...@googlecode.com]

Updates:
Status: Assigned
Owner: mkr...@chromium.org

Comment #3 on issue 36181 by dd...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

mkrebs - can you please help assign if this isn't something you would work
on?
sontis - can you clarify reason for releaseblock-dev?

[chrom...@googlecode.com]

Updates:
Owner: son...@chromium.org

Comment #4 on issue 36181 by mkr...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

What does "metrics_client -g; echo $?" report? It should show "0" if you
are in guest mode.

I'm guessing it shows "1", though, because otherwise crash_sender is
supposed to delay uploading any crash reports.

[chrom...@googlecode.com]

Updates:
Cc: mkr...@chromium.org

Comment #5 on issue 36181 by mkr...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

[chrom...@googlecode.com]

Comment #6 on issue 36181 by rohi...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

We marked this a Dev blocker because we don't upload crash reports or any
other metrics in the Guest session.

[chrom...@googlecode.com]

Updates:
Owner: mkr...@chromium.org

Comment #7 on issue 36181 by son...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

@comment#4
"metrics_client -g; echo $?" is displaying "1" in guest mode.

[chrom...@googlecode.com]

Updates:
Status: Started

Comment #8 on issue 36181 by mkr...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

Huh.. that's definitely the problem.

Can you post the output from "grep chronos/user /proc/mounts" and "ls -l
/var/run/state"?

[chrom...@googlecode.com]

Comment #9 on issue 36181 by son...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

@comment#8

chronos@localhost / $ grep chronos/user /proc/mounts
guestfs /home/chronos/user tmpfs rw,nosuid,nodev,noexec,relatime,mode=700 0
0

chronos@localhost / $ ls -l /var/run/state
total 0
-rw-r--r-- 1 root root 0 Nov 9 12:39 allow-vt-switching
drwxr-xr-x 2 chronos chronos 40 Nov 9 12:39 windowmanager

[chrom...@googlecode.com]

Comment #10 on issue 36181 by mkr...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

So it's returning false for being in guest mode because the
/var/run/state/logged-in file doesn't exist. That file should be created
when you login -- which I assume you are.

Can you see what "grep logged-in /etc/init/login.conf" shows?

[chrom...@googlecode.com]

Comment #11 on issue 36181 by son...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

chronos@localhost / $ grep logged-in /etc/init/login.conf
# The "logged-in" file is used by ACPI events to behave
touch /var/run/state/logged-in

[chrom...@googlecode.com]

Updates:
Status: Assigned
Owner: ps...@chromium.org

Comment #12 on issue 36181 by mkr...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

So I can reproduce this on an Alex with 3160.0.0. I talked to pstew@ and
he thinks this is because shill is failing in that login.conf script for
guest mode.

So I'm assigning this to him...

[chrom...@googlecode.com]

Updates:
Status: Started

Comment #13 on issue 36181 by ps...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

Testing a change.

[chrom...@googlecode.com]

Updates:
Status: Fixed

Comment #14 on issue 36181 by ps...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

[chrom...@googlecode.com]

Updates:
Cc: chrome-...@google.com

Comment #15 on issue 36181 by bugdro...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session

http://code.google.com/p/chromium-os/issues/detail?id=36181#c15

Project : chromiumos/platform/shill
Branch : master
Author : Paul Stewart <ps...@chromium.org>
Committer: Gerrit <chrom...@google.com>
Commit : 70743f4891e06e66b577158eea46014b689392c8

Code Review +2: Richard Barnette
Verified +1: Paul Stewart
Change-Id : Ice8299e83cebe00b7c560cc00455d6228a09c9e2
Reviewed-at : https://gerrit.chromium.org/gerrit/37779

shill: login: Allow guest login

Modify shill login script to allow an empty "user" parameter, since
this is how guest login works. In this situation, create a temporary
directory for the user profile which will be removed at logout.

BUG=chromium-os:36181
TEST=Rerun unit tests. Login as guest and make sure profile is pushed,
temporary directory exists. On logout ensure profile directory has
been removed.

M bin/shill_login_user
M bin/shill_logout_user

[chrom...@googlecode.com]

Updates:
Status: Verified

Comment #16 on issue 36181 by son...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

Verified on build 3196.0.0

[chrom...@googlecode.com]

Comment #17 on issue 36181 by bugdro...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session

http://code.google.com/p/chromium-os/issues/detail?id=36181#c17

Project: chromiumos/third_party/autotest

Branch : master
Author : Paul Stewart <ps...@chromium.org>

Commit : 9f29def08d6ff2f472aee180bee3bc22f8880c74

Code Review +1: Michael Krebs, Richard Barnette
Code Review +2: mukesh agrawal
Verified +1: Paul Stewart
Change-Id : Ic7be1232a1de02031b2d60928c0821d1e31ee2c1
Reviewed-at : https://gerrit.chromium.org/gerrit/37780

autotest: shill_login: Update for changes to init script

Flimflam /var/run link no longer exists. Also test for guest
login.

BUG=chromium-os:36181
TEST=This is a test.

M client/site_tests/network_ShillInitScripts/network_ShillInitScripts.py

[chrom...@googlecode.com]

Updates:
Cc: sq...@chromium.org de...@chromium.org arsc...@chromium.org
har...@chromium.org cma...@chromium.org mnis...@chromium.org

Comment #18 on issue 36181 by cma...@chromium.org: Crash Reporting is

enabled during BWSI (Guest) session
http://code.google.com/p/chromium-os/issues/detail?id=36181

Issue 35980 has been merged into this issue.