Issue 33651 in chromium-os: Gestures: tvpiew's shrink function loses the last hardware state

[chrom...@googlecode.com]

Status: Assigned
Owner: chuwf...@chromium.org
Labels: Type-Bug Pri-1 Area-Platform Mstone-23 Iteration-63 Touch

New issue 33651 by ad...@chromium.org: Gestures: tvpiew's shrink function
loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651

Repro steps:

- put the attached log into tpview
- move the start-time scrubber forward, keep end-time at the very end
- see the end time's finger count is 0
- shrink range
- see the end time's finger count is now 1. Bug.

For now, reverting the offending change.

[chrom...@googlecode.com]

Comment #1 on issue 33651 by ad...@chromium.org: Gestures: tvpiew's shrink

function loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651

(No comment was entered for this change.)

Attachments:
log.txt 4.0 MB

[chrom...@googlecode.com]

Updates:
Cc: ad...@chromium.org

Comment #2 on issue 33651 by chuwf...@chromium.org: Gestures: tvpiew's

shrink function loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651

I think the problem is because the "type" of last one element in the
log.txt is not hardwareState. And the new version shrink functionality is
based on the timestamp of hardwareState. The shrink function will extract
the region between first hardwareState and the last hardwareState in the
selected region. Thus, the elements after the last hardwardState will be
discarded. If you think the discarded messages are important, revert it.

[chrom...@googlecode.com]

Comment #3 on issue 33651 by chuwf...@chromium.org: Gestures: tvpiew's

shrink function loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651

If you think the discarded message are not important, I think the bug can
be fix by adding 1 at the end of slice function.
That is,
change currentLayer.entries = currentLayer.entries.slice(currentBegin,
currentEnd);
to currentLayer.entries = currentLayer.entries.slice(currentBegin,
currentEnd + 1);
I will solve it next Monday if you think discard the messages after the
last hardwareState is fine.

[chrom...@googlecode.com]

Comment #4 on issue 33651 by ad...@chromium.org: Gestures: tvpiew's shrink

function loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651

The problem isn't just that a non-hardware state goes missing. We are
missing a hardware state that claims 0 fingers on the pad.

Follow the repro steps above carefully to see the problem.

[chrom...@googlecode.com]

Updates:
Status: Fixed

Comment #5 on issue 33651 by chuwf...@chromium.org: Gestures: tvpiew's

shrink function loses the last hardware state
http://code.google.com/p/chromium-os/issues/detail?id=33651