Issue 39874 in chromium-os: cros_bundle_firmware allows negative section overlaps

[chrom...@googlecode.com]

Status: Untriaged
Owner: vben...@chromium.org
CC: s...@chromium.org
Labels: Type-Bug Pri-2 Cr-OS-Firmware-BIOS OS-Chrome

New issue 39874 by vben...@chromium.org: cros_bundle_firmware allows
negative section overlaps
http://code.google.com/p/chromium-os/issues/detail?id=39874

It turns out that in case there are sections in the device tree specified
through `size' property followed by sections specified by 'reg' property,
cros_bundle_firmware generates a map showing negative gap, but otherwise
reports success.

Here is a fragment of the generated map:

. 001b6000 00010000 RO_VPD
! 001c6000 -0006000 <gap>
. 001c0000 00000100 RO_FRID



--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chrom...@googlecode.com]

Comment #1 on issue 39874 by bugdro...@chromium.org: cros_bundle_firmware
allows negative section overlaps
http://code.google.com/p/chromium-os/issues/detail?id=39874#c1

Project: chromiumos/platform/dev-util
Branch : master
Author : Simon Glass <s...@chromium.org>
Commit : b688a3c2c8f765acce639f9826ee53422d1434ac

Code Review +1: Randall Spangler
Code Review +2: Vadim Bendebury
Verified +1: Simon Glass
Commit Queue : Chumped
Change-Id : I718e82b3e5afb01f6532d0fb8aff0401287fd86b
Reviewed-at : https://gerrit.chromium.org/gerrit/49399

cros_bundle_firmware: Tidy up automatic placement with empty sections

Due to the fact that we use a non-hierarchical flashmap to store a
hierarchy, we have a strange problem where a negative gap is reported
in some cases.

Correct this by updating the 'up to' offset every now and then.

BUG=chromium-os:39874
TEST=manual

Run cros_bundle_firmware ... -m

Without this change:

P 001b6000 00010000 RO_VPD
P 001c6000 00000100 RO_FRID
- 00200000 000f0000 RW_SECTION_A
! 001c6100 00039f00 <gap>
P 00200000 00002000 VBLOCK_A

(the <gap> section should preceed RW_SECTION_A)

With this change:

P 001b6000 00010000 RO_VPD
P 001c6000 00000100 RO_FRID
! 001c6100 00039f00 <gap>
- 00200000 000f0000 RW_SECTION_A
P 00200000 00002000 VBLOCK_A

Signed-off-by: Simon Glass <s...@chromium.org>

M host/lib/pack_firmware.py