[chromium-discuss] M5 UI changes moving to M6

30 views
Skip to first unread message

Peter Kasting

unread,
Apr 19, 2010, 7:26:05 PM4/19/10
to Chromium-dev, Chromium-discuss
This is a heads-up: we are moving many of the UI changes originally planned for M5 into M6.  Among other things, changes to the omnibox, toolbar buttons, window shape, default theme color, new tab animation, autofill, and possibly other things are going to be postponed to M6 so we can spend more time testing, polishing and tweaking them.

We're in the process of temporarily reverting these changes and retargeting the associated bugs.  We expect to ship one or two Dev releases without these, to ensure we've gotten rid of everything we need to, and at that point the reverts will themselves be reverted (i.e. the trunk will regain all the changes, so we can continue to work on them), while the branch for M5 will continue on without them.

Consider this a forewarning, so you don't do the following:
* Ask why some bugs are being moved from M5 to M6
* Freak out when suddenly a lot of stuff reverts on trunk or Dev, and file bugs, only to have them be closed
* Believe that some change you hated has been killed, only to be disappointed when it relands later

Please don't debate whether particular things should or shouldn't be reverted, or ask for precise details on whether change X is going to be reverted, as the folks in charge of doing this are heads-down trying to make it happen as fast as possible, and this will just add noise that slows things down.  The best guide to what will be in M5 will probably be the next Beta channel release that gets shipped.

Thanks for your patience and understanding,
PK

--
Chromium Discussion mailing list: chromium...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-discuss

Meok

unread,
Apr 19, 2010, 9:50:23 PM4/19/10
to Chromium-discuss
Thanks for the heads-up. I do thing the proposed changes need some
time to be hashed out properly (a LOT of people are upset). I would
like to offer a suggestion though, as it relates to the M6 UI. The
link below leads to a series of mock-ups showing how we can integrate
the Bookmarks Star onto an omnibar button without changing the
position of anything else. I think it is the logical choice and a
good compromise for the people who want it on the left / right.

http://www.gowebnow.net/chrome/images/bookmark-star-placement.jpg
> Chromium Discussion mailing list: chromium-disc...@chromium.org

gerickson

unread,
Apr 20, 2010, 3:22:10 AM4/20/10
to Chromium-discuss
What if I'm at a website, start typing an address in the omnibox, and
but then decide that I want to bookmark my current page before I leave
it? Your mock-up doesn't allow for that situation. Anyway, I doubt
Peter wants people giving suggestions here, as this was meant to just
be a heads-up. If you have suggestions, start a new discussion or file
a new issue.

PhistucK

unread,
Apr 20, 2010, 3:24:59 AM4/20/10
to pkas...@google.com, meo...@gmail.com, Chromium-discuss
According to this issue, code.google.com/p/chromium/issues/detail?id=41833 "new style autofill" will be dropped "anyway".
Can you, please, elaborate on this (or is this referring only to milestone 5)?

(And Meok - I do not agree that the bookmark star is not needed before the page has finished loading. And also what gerickson wrote.)

☆PhistucK

Meok

unread,
Apr 20, 2010, 6:57:39 AM4/20/10
to Chromium-discuss
Just wondering, what's the rush to push out M5? With these features
removed, the only features M5 will have are integrated flash,
preference and theme sync, bookmark manager and geolocation. I was
just wondering, are you pushing out M5 to get out these features or to
get out a stable release for Mac and Linux? Because I think we can
wait until you polish the features.

On Apr 20, 4:24 am, PhistucK <phist...@gmail.com> wrote:
> According to this issue, code.google.com/p/chromium/issues/detail?id=41833 "new
> style autofill" will be dropped "anyway".
> Can you, please, elaborate on this (or is this referring *only* to milestone

PhistucK

unread,
Apr 20, 2010, 10:29:24 AM4/20/10
to meo...@gmail.com, Chromium-discuss
Also Application Cache, AutoFill (I guess), history extension API, extensions in Incognito, Pepper plugin API, edit mode for the History page, extended about:plugins page, additional Developer Tools features, faster JavaScript, behind the scene changes and probably some more I am forgetting.
Full already implemented features can be found here -

Besides that, a lot of bugs were fixed and Linux and Mac versions will probably be released.
Sounds like enough for a milestone.
(Do not forget that these milestones are not supposed to be so big, generally. You cannot expect a lot of really big features every three months, after all. It is just better to wait three, four months for each big feature, than to wait a year for three big features.)

☆PhistucK

krtulmay

unread,
Apr 20, 2010, 11:35:38 AM4/20/10
to Chromium-discuss
Thanks for the feature reminders from Meok for the initial list and to
PhistucK for the supplements!

On Apr 20, 7:29 am, PhistucK <phist...@gmail.com> wrote:
> Also Application Cache, AutoFill (I guess), history extension API,
> extensions in Incognito, Pepper plugin API, edit mode for the History page,
> extended about:plugins page, additional Developer Tools features, faster
> JavaScript, behind the scene changes and probably some more I am forgetting.
> Full already implemented features can be found here -
> code.google.com/p/chromium/issues/list?can=1&q=mstone:5+status:Fixed+type:f eature&colspec=ID+Stars+Pri+Area+Feature+Type+Status+Summary+Modified+Owner +Mstone+OS&x=mstone&y=area&cells=tiles
>
> <http://code.google.com/p/chromium/issues/list?can=1&q=mstone:5+status...>Besides

Tim Steele

unread,
Apr 20, 2010, 1:15:27 PM4/20/10
to phis...@gmail.com, pkas...@google.com, meo...@gmail.com, Chromium-discuss
That bug is indeed only talking about M5.  Sorry for the confusion.

PhistucK

unread,
Apr 21, 2010, 12:55:11 AM4/21/10
to Tim Steele, pkas...@google.com, meo...@gmail.com, Chromium-discuss
So does that mean that the whole autofill feature (meaning, not only autofill syncing) is being dropped for 5?

☆PhistucK

Anthony LaForge

unread,
Apr 21, 2010, 2:21:34 AM4/21/10
to phis...@gmail.com, Tim Steele, pkas...@google.com, meo...@gmail.com, Chromium-discuss
That's correct.

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA

Peter Kasting

unread,
Apr 21, 2010, 9:21:50 PM4/21/10
to Chromium-dev, Chromium-discuss
On Mon, Apr 19, 2010 at 4:26 PM, Peter Kasting <pkas...@google.com> wrote:
This is a heads-up: we are moving many of the UI changes originally planned for M5 into M6.  Among other things, changes to the omnibox, toolbar buttons, window shape, default theme color, new tab animation, autofill, and possibly other things are going to be postponed to M6 so we can spend more time testing, polishing and tweaking them.

We're in the process of temporarily reverting these changes and retargeting the associated bugs.

The revert has now landed on the trunk.  I encourage anyone who normally builds trunk to go ahead and test out our changes to ensure there's no unusual behavior.  If you find something that seems wrong, contact shess and/or me.

We will be landing the branch version to the 375 branch shortly.  This may destabilize the branch for 12 hours or so as both of us plan to go home after landing; we've already planned ahead with laforge to work with him and QA tomorrow to fix any problems that show up there, so if you sync and build the branch, consider this forewarning.

PK 

Peter Kasting

unread,
Apr 21, 2010, 10:01:10 PM4/21/10
to Chromium-dev, Chromium-discuss
On Wed, Apr 21, 2010 at 6:21 PM, Peter Kasting <pkas...@google.com> wrote:
The revert has now landed on the trunk.  I encourage anyone who normally builds trunk to go ahead and test out our changes to ensure there's no unusual behavior.  If you find something that seems wrong, contact shess and/or me.

I forgot to mention the future plans.

We intend to leave this on trunk long enough to (a) get some testing from developers building it and our build farm, and (b) allow us to shake out any issues on the branch (since if trunk is the same as branch it'll be easier to test and land fixes).  My hope is that we'll be ready to revert this revert on trunk, that is, to permanently return to the M6 code, some time this Friday.

PK

Scott Hess

unread,
Apr 21, 2010, 10:08:19 PM4/21/10
to pkas...@google.com, Chromium-dev, Chromium-discuss
On Wed, Apr 21, 2010 at 6:21 PM, Peter Kasting <pkas...@google.com> wrote:
> On Mon, Apr 19, 2010 at 4:26 PM, Peter Kasting <pkas...@google.com> wrote:
>> This is a heads-up: we are moving many of the UI changes originally
>> planned for M5 into M6.  Among other things, changes to the omnibox, toolbar
>> buttons, window shape, default theme color, new tab animation, autofill, and
>> possibly other things are going to be postponed to M6 so we can spend more
>> time testing, polishing and tweaking them.
>> We're in the process of temporarily reverting these changes and
>> retargeting the associated bugs.
>
> The revert has now landed on the trunk.  I encourage anyone who normally
> builds trunk to go ahead and test out our changes to ensure there's no
> unusual behavior.  If you find something that seems wrong, contact shess
> and/or me.
> We will be landing the branch version to the 375 branch shortly.  This may
> destabilize the branch for 12 hours or so as both of us plan to go home
> after landing; we've already planned ahead with laforge to work with him and
> QA tomorrow to fix any problems that show up there, so if you sync and build
> the branch, consider this forewarning.

And, before you flame: remember, we revert because we care.

---

The trunk CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=45267

The 375 branch CL:
http://src.chromium.org/viewvc/chrome?view=rev&revision=45275

The list of authors, in case you wonder if you should double-check if
we reverted something which will need more than a code-monkey's
attention to be correct on the branch:
19 pkas...@chromium.org
15 sh...@chromium.org
15 est...@chromium.org
10 s...@chromium.org
10 e...@chromium.org
5 gl...@chromium.org
3 w...@chromium.org
2 fin...@chromium.org
1 the...@chromium.org
1 rohi...@chromium.org
1 nsyl...@chromium.org
1 m...@chromium.org
1 ev...@chromium.org
If you do need to adjust something, best time to do it is on the trunk
on Thursday, then drover right over to the branch. Let me know so
that we can revert before we revert the revert on the trunk. [If you
wonder which specific svnid was yours, email me and I'll fish it out.]

-scott

PhistucK

unread,
Apr 22, 2010, 12:28:30 AM4/22/10
to sh...@google.com, pkas...@google.com, Chromium-dev, Chromium-discuss
This is so sad. :(

☆PhistucK


Chromium Developers mailing list: chromi...@chromium.org

View archives, change email options, or unsubscribe:

Alexander Skwar

unread,
Apr 22, 2010, 2:02:39 AM4/22/10
to sh...@google.com, pkas...@google.com, Chromium-dev, Chromium-discuss
This is very good :)

Hopefully, at least the http:// change won't come back (but I of course
read the "thread", that this won't be true, ie. that it will come back...)

Cheers,
Alexander

2010/4/22 Scott Hess <sh...@google.com>



--
Alexander
--
↯    Lifestream (Twitter, Blog, …) ↣ http://alexs77.soup.io/     ↯
↯ Chat (Jabber/Google Talk) ↣ a.s...@gmail.com , AIM: alexws77  ↯

Simon B.

unread,
Apr 22, 2010, 3:55:45 AM4/22/10
to Chromium-discuss
On Apr 22, 6:28 am, PhistucK <phist...@gmail.com> wrote:
> This is so sad. :(
> ☆PhistucK

Of course the 10 @chromium guys would've preferred not having to worry
about a revert + revert-revert, but would it even have been possible
to discover faster this won't hit M5? It sure helped on getting lots
of issues (mostly copy-paste?) that removing http:// should depend on.
Would a scrolled-out-left solution be able to avoid most (all?) of the
copy-paste issues that came out?

There is also a psychological question whether its better to introduce
the improved omnibar design first (new icons and faded omnibar
coloring), and only after that start removing "http://", or if they
should go both at the same time.
I again suggest as a first step making "http://" scroll out over the
left edge so it's overflow-hidden but not removed, and perhaps the
same for https:// if possible, which would depend on crbug.com/33904
and perhaps more.

Thanks /Simon

Meok

unread,
Apr 22, 2010, 11:47:27 AM4/22/10
to Chromium-discuss
I notice the revert on the toolbar and the colors (wide smile) but I
also notice the appearance of a new-new-new tab page. Is the current
NTP on trunk supposed to be an M5 feature of did you forget to revert
that?

On Apr 21, 10:21 pm, Peter Kasting <pkast...@google.com> wrote:
> On Mon, Apr 19, 2010 at 4:26 PM, Peter Kasting <pkast...@google.com> wrote:
> > This is a heads-up: we are moving many of the UI changes originally planned
> > for M5 into M6.  Among other things, changes to the omnibox, toolbar
> > buttons, window shape, default theme color, new tab animation, autofill, and
> > possibly other things are going to be postponed to M6 so we can spend more
> > time testing, polishing and tweaking them.
>
> > We're in the process of temporarily reverting these changes and retargeting
> > the associated bugs.
>
> The revert has now landed on the trunk.  I encourage anyone who normally
> builds trunk to go ahead and test out our changes to ensure there's no
> unusual behavior.  If you find something that seems wrong, contact shess
> and/or me.
>
> We will be landing the branch version to the 375 branch shortly.  This may
> destabilize the branch for 12 hours or so as both of us plan to go home
> after landing; we've already planned ahead with laforge to work with him and
> QA tomorrow to fix any problems that show up there, so if you sync and build
> the branch, consider this forewarning.
>
> PK
>
> --
> Chromium Discussion mailing list: chromium-disc...@chromium.org

Aaron Boodman

unread,
Apr 22, 2010, 1:13:58 PM4/22/10
to meo...@gmail.com, Chromium-discuss
On Thu, Apr 22, 2010 at 10:13 AM, Aaron Boodman <a...@google.com> wrote:
> On Thu, Apr 22, 2010 at 8:47 AM, Meok <meo...@gmail.com> wrote:
>> I notice the revert on the toolbar and the colors (wide smile) but I
>> also notice the appearance of a new-new-new tab page. Is the current
>> NTP on trunk supposed to be an M5 feature of did you forget to revert
>> that?
>
> The NNNTP is unrelated. It won't be going to M5.
>
> - a

Peter Kasting

unread,
Apr 23, 2010, 4:56:51 PM4/23/10
to Chromium-dev, Chromium-discuss
On Wed, Apr 21, 2010 at 7:01 PM, Peter Kasting <pkas...@google.com> wrote:
We intend to leave this on trunk long enough to (a) get some testing from developers building it and our build farm, and (b) allow us to shake out any issues on the branch (since if trunk is the same as branch it'll be easier to test and land fixes).  My hope is that we'll be ready to revert this revert on trunk, that is, to permanently return to the M6 code, some time this Friday.

As planned, we have now reverted the revert on trunk.  No more major changes around this topic are planned for trunk or branch.  The 375 branch will continue to stabilization for M5 without the changes, while the trunk will proceed towards M6 with the changes, along with whatever future reverts, tweaks, etc. we choose to make.

Thanks again for your patience.

PK

Erik Kay

unread,
Apr 23, 2010, 6:26:37 PM4/23/10
to pkas...@google.com, Chromium-dev, Chromium-discuss
Awesome. Thanks for the hard work.

Erik


On Fri, Apr 23, 2010 at 1:56 PM, Peter Kasting <pkas...@google.com> wrote:
> On Wed, Apr 21, 2010 at 7:01 PM, Peter Kasting <pkas...@google.com> wrote:
>>
>> We intend to leave this on trunk long enough to (a) get some testing from
>> developers building it and our build farm, and (b) allow us to shake out any
>> issues on the branch (since if trunk is the same as branch it'll be easier
>> to test and land fixes).  My hope is that we'll be ready to revert this
>> revert on trunk, that is, to permanently return to the M6 code, some time
>> this Friday.
>
> As planned, we have now reverted the revert on trunk.  No more major changes
> around this topic are planned for trunk or branch.  The 375 branch will
> continue to stabilization for M5 without the changes, while the trunk will
> proceed towards M6 with the changes, along with whatever future reverts,
> tweaks, etc. we choose to make.
> Thanks again for your patience.
> PK
>
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev

Meok

unread,
Apr 25, 2010, 9:44:45 PM4/25/10
to Chromium-discuss
If M5 is going toward stabilization then that means the feature set
for M5 has been frozen. Shouldn't the trunk be upgraded to M6 then,
since the current changes on trunk will definitely NOT be in M5?

On Apr 23, 5:56 pm, Peter Kasting <pkast...@google.com> wrote:
> On Wed, Apr 21, 2010 at 7:01 PM, Peter Kasting <pkast...@google.com> wrote:
> > We intend to leave this on trunk long enough to (a) get some testing from
> > developers building it and our build farm, and (b) allow us to shake out any
> > issues on the branch (since if trunk is the same as branch it'll be easier
> > to test and land fixes).  My hope is that we'll be ready to revert this
> > revert on trunk, that is, to permanently return to the M6 code, some time
> > this Friday.
>
> As planned, we have now reverted the revert on trunk.  No more major changes
> around this topic are planned for trunk or branch.  The 375 branch will
> continue to stabilization for M5 without the changes, while the trunk will
> proceed towards M6 with the changes, along with whatever future reverts,
> tweaks, etc. we choose to make.
>
> Thanks again for your patience.
>
> PK
>
> --
> Chromium Discussion mailing list: chromium-disc...@chromium.org
Reply all
Reply to author
Forward
0 new messages