Windows issue with adding ash_strings.grd to src/ash/

[Zach Kuznia]

Hello,

I have a CL out to add a new resource file containing strings to ash:

https://chromiumcodereview.appspot.com/9307037

The gyp changes are based on src/ui/base/strings/ui_strings.gyp.  This works for all projects except aura_shell_unittests on Windows.  On Windows, the resources do not seem to be included in the final executable, as it crashes with a "Missing resource ID" error.

Could anyone help me determine what my CL is missing that would properly include the resources on Windows?

Thanks,

-Zach

[Jói Sigurðsson]

Hi Zach,

Sorry I didn't catch this yesterday when you asked me to take a look.

On Windows, we use .rc files, not .pak files. It looks like you're
missing generation of .rc files in ash_strings.grd (they should be
<output> nodes), and you're missing inclusion of the generated .rc
files in your .gyp definitions. See e.g. how gfx_resources.rc is
included as a source file in the .gyp file in your change, and how it
is specified as an output in gfx_resources.gyp.

Hopefully with those changes the problem will be solved.

Cheers,
Jói

> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev