Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Windows issue with adding ash_strings.grd to src/ash/
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  2 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
Zach Kuznia  
View profile  
 More options Feb 2 2012, 3:24 am
From: Zach Kuznia <z...@chromium.org>
Date: Thu, 2 Feb 2012 17:24:12 +0900
Local: Thurs, Feb 2 2012 3:24 am
Subject: Windows issue with adding ash_strings.grd to src/ash/

Hello,

I have a CL out to add a new resource file containing strings to ash:
https://chromiumcodereview.appspot.com/9307037

The gyp changes are based on src/ui/base/strings/ui_strings.gyp.  This
works for all projects except aura_shell_unittests on Windows.  On Windows,
the resources do not seem to be included in the final executable, as it
crashes with a "Missing resource ID" error.

Could anyone help me determine what my CL is missing that would properly
include the resources on Windows?

Thanks,
-Zach


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Jói Sigurđsson  
View profile  
 More options Feb 2 2012, 4:43 am
From: Jói Sigurđsson <j...@chromium.org>
Date: Thu, 2 Feb 2012 09:43:18 +0000
Local: Thurs, Feb 2 2012 4:43 am
Subject: Re: [chromium-dev] Windows issue with adding ash_strings.grd to src/ash/
Hi Zach,

Sorry I didn't catch this yesterday when you asked me to take a look.

On Windows, we use .rc files, not .pak files.  It looks like you're
missing generation of .rc files in ash_strings.grd (they should be
<output> nodes), and you're missing inclusion of the generated .rc
files in your .gyp definitions.  See e.g. how gfx_resources.rc is
included as a source file in the .gyp file in your change, and how it
is specified as an output in gfx_resources.gyp.

Hopefully with those changes the problem will be solved.

Cheers,
Jói


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »