Differentiating Chrome Frame in unittests

[ttuttle]

Hi,

I'm making a change that adds functionality to net/ that's not
expected to work under Chrome Frame (it relies on code in Chromium's
URL request jobs, which aren't run in Chrome Frame). I've taken a
look around chrome_frame.gyp and other tests, but can't find a way to
tell in my test cases whether I'm running in a Chrome Frame context or
elsewhere. Does anyone have any ideas?

Thanks,

ttuttle

[Greg Thompson]

If your tests simply don't apply for CF, add them to FilterDisabledTests.

Cheers

 

Thanks,

ttuttle

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
    http://groups.google.com/a/chromium.org/group/chromium-dev

[ttuttle]

I don't want to remove them entirely, since some are modifications of
existing tests. I might fork the old ones and disable only the new
ones.

[Matthew Menke]

Having code in net/ test for the presence of Chrome Frame seems like it would be a layering violation.

Also, you can disable only specific tests in ChromeFrame, so you can, in fact, just disable the new ones - see src/chrome_frame/test/net/fake_external_tab.cc