rietveld doing weird thing

[Thiago Farina]

Hey,

When uploading a patch today with "git cl upload -m "foo"" I noticed
that rietveld is adding a comment to the CL with "foo", but hey my
"foo" is just a patchset title, not a comment, I don't want it to be
added as a comment. I think that just bloats the comment history in
the CL and doesn't add anything useful, just duplicates an information
that is already and visible there.

Thanks!

[Thiago Farina]

Also, another thing that hurts my workflow is that I used to be able
to do:

$ git cl upload -m ""

And that used to add a new patchset to the CL with an empty patchset
title. So then, I could go there and delete the previous patchset. I
do this all the time, because reviewing diffs on the browser is much
easier and nice than the command line.

But that doesn't work anymore and I'm asked everytime to provide a
patchset title.

[Ami Fischman]

OTOH, it makes it possible to see where free-form comments (not attached to a particular file/changeset) fall in the patchset history without having to compare timestamps (even that isn't always possible with the display rounding).  I think the new feature could be improved to call out the different kind of thing that it is, but just wanted to chime in with a counterpoint that I think the new feature is an improvement.

(also, to your next email, just do [-m .] instead of [-m ""])

Cheers,

-a

--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
   http://groups.google.com/a/chromium.org/group/chromium-dev

[Thiago Farina]

On Fri, May 11, 2012 at 2:23 PM, Ami Fischman <fisc...@chromium.org> wrote:
> OTOH, it makes it possible to see where free-form comments (not attached to

What is free-form comments? Doesn't make sense to me.

> (also, to your next email, just do [-m .] instead of [-m ""])
>

That displays a dot in the patchset title, so it's not the same thing
as an empty title. Yeah, I know it's just a dot, but I don't like it
(ok, I should just ignore the dot, but I really prefer an CLEAN empty
patchset title).

--
Thiago

[Ami Fischman]

> OTOH, it makes it possible to see where free-form comments (not attached to

What is free-form comments? Doesn't make sense to me.

Any comment made not attached to a particular file:line pair.  For example by clicking the "Reply" link at the bottom of the list of comments in the top-level view of a CL (https://chromiumcodereview.appspot.com/NNNN/) , or by hitting 'm' and typing comments in the Message box, or replying to a rietveld email from a mail client, and so on.

 

> (also, to your next email, just do [-m .] instead of [-m ""]) 

That displays a dot in the patchset title, so it's not the same thing as an empty title.

Yes; I was addressing your "hurts my workflow" comment, not making a suggestion for traveling back in time. ;)

-a

[Roger Tawa]

Hi guys,

This is my fault, when I updated rietveld and corresponding upload.py
file earlier this week. Looking at it now.

Thanks,
Roger

-

[Roger Tawa]

Hi guys,

The fix for this is committed as crrev.com/136922

Thanks,
Roger

-

[Thiago Farina]

On Mon, May 14, 2012 at 3:53 PM, Roger Tawa <rog...@chromium.org> wrote:
> Hi guys,
>

> The fix for this is committed as crrev.com/136922
>

This is great! Thanks for fixing this.

--
Thiago