ninja updated to v1.3.3

[Nico Weber]

Hi,

I just updated ninja from 1.1.0 to 1.3.3. The next time you run `gclient`, you'll get the new version.

Hopefully everything will work exactly like before. If you see any problems, please let me know.

Nico

ps: If your tryjob failed on mac with error 245 at the beginning of the 'compile' stage, that was my fault. Sorry. That should be fixed now.

[Jiang Jiang]

I have been constantly getting:

ninja: build stopped: stuck [this is a bug].

Since this upgrade. But when I run the command again it can proceed.

On Mac with use_deps=1 in GYP_GENERATOR_FLAGS.

- Jiang

[Nico Weber]

With a regular chromium checkout? Or do you have any local changes? Do you see this without use_reps?

[Nico Weber]

Jiang: ping.

[Jiang Jiang]

On May 23, 2013, at 3:47 PM, Nico Weber <tha...@chromium.org> wrote:
> Jiang: ping.
>
> On May 22, 2013 6:41 AM, "Nico Weber" <tha...@chromium.org> wrote:
> With a regular chromium checkout? Or do you have any local changes? Do you see this without use_reps?

I didn't try to build chromium but our build system is pretty much the same setup. I'm using ccache though. I removed use_deps=1 this morning and haven't seen any problem after that.

- Jiang

[Nico Weber]

If you can create a reduced repro case, I'll take a look. I'll also try a ccache build of chromium. But in afraid "our internal builds are broken" alone is not something actionable.

[Jiang Jiang]

On May 23, 2013, at 5:00 PM, Nico Weber <tha...@chromium.org> wrote:
> If you can create a reduced repro case, I'll take a look. I'll also try a ccache build of chromium. But in afraid "our internal builds are broken" alone is not something actionable.

Sure, I understand that. I can also try building chromium with ccache enabled.

- Jiang

[Jiang Jiang]

On May 23, 2013, at 5:00 PM, Nico Weber <tha...@chromium.org> wrote:
> If you can create a reduced repro case, I'll take a look. I'll also try a ccache build of chromium. But in afraid "our internal builds are broken" alone is not something actionable.

Also, do you know if there is any debug flag I can enable or change certain lines of code to show more information when this kind of error happens? I can compile ninja myself and use that to debug this.

- Jiang

[Nico Weber]

Probably best to file a bug for this on crbug (cc me, or email me the link) and continue this conversation there. `ninja --help` prints the flags ninja understands.

 

- Jiang

[Nico Weber]

Now tracking this at https://code.google.com/p/chromium/issues/detail?id=245034 . If you have more information, please reply there.

 

 

- Jiang

[Nico Weber]

We managed to track this down and just pushed ninja 1.3.4 which has a fix for this issue. If you see any problems with the new binaries, please let me know.

Thanks to Jiang for helping with this!

Nico

 

 

 

- Jiang

[Finnur Thorarinsson]

I did a gclient sync on my Linux box and now I get this every time I try to build:

ninja: Entering directory `out/Release'

ninja: error: build.ninja:14: unexpected variable 'deps'

  deps = gcc

            ^ near here

I've tried blowing away my Release dir, doing a gclient sync and running the install-build-deps.sh script. Nothing has worked so far.

Anything else I should be trying?

--
--
Chromium Developers mailing list: chromi...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-dev
 
 
 

[Adam Langley]

On Thu, Jun 6, 2013 at 11:34 AM, Finnur Thorarinsson
<fin...@chromium.org> wrote:
> I did a gclient sync on my Linux box and now I get this every time I try to
> build:
>
> ninja: Entering directory `out/Release'
> ninja: error: build.ninja:14: unexpected variable 'deps'
> deps = gcc
> ^ near here
>
>
> I've tried blowing away my Release dir, doing a gclient sync and running the
> install-build-deps.sh script. Nothing has worked so far.
>
> Anything else I should be trying?

I saw this and removed the deps lines from the .ninja file. There's
only a couple and everything worked after that.


Cheers

AGL

[Scott Graham]

Are you using a custom ninja binary? What's ninja --version say? The one in depot_tools has been updated to support that dependency mode.

[Cary Clark]

It happened to me too -- I had an old ninja (more than one depot_tools in $PATH was the ultimate culprit). See if ninja --version reports 1.3.3

[Stefan Kuhne]

I had yesterday the same thing. Building without via shell worked, and with Eclipse not. I have already forgotten what it was but there was something with the environment which has apparently changed.

That said - after that I was unable to use the LD_PRELOAD command anymore and had to remove OGL library because otherwise the resulting build stopped working.

-Stefan

[Finnur Thorarinsson]

Removing the two deps variables got me past the error.

But, hmm, ninja --version shows 1.1.0  :/

[Nico Weber]

What does `which ninja` say? The binary in depot_tools is at 1.3.4. If you don't get that your path is probably wrong somehow.

[Finnur Thorarinsson]

/usr/local/google/home/finnur/code/depot_tools/ninja

... and when I run it directly from there, it also says the version is 1.1.0, so it looks like depot_tools isn't updating... ?

[Nico Weber]

What does `svn info` or `git log` in that directory say?

[Finnur Thorarinsson]

What directory? If you mean depot_tools, both complain about the directory not being a working copy/repository.

[Nico Weber]

Huh, which wiki page did you follow to set up depot_tools? They are supposed to be checkouts that autoupdate every time you run gclient sync.

[Finnur Thorarinsson]

It's been too long, I don't know.

[Finnur Thorarinsson]

Checked out a fresh copy with git and now have version 1.3.4 of ninja.

Thanks!

[Finnur Thorarinsson]

... and the error is gone, even if I re-add the deps variables.

[Nico Weber]

Cool. If anyone else has a borked depot_tools checkout, http://www.chromium.org/developers/how-tos/install-depot-tools explains how to get a new one.