Where to put app/sql/?

Robert Sesek

unread,

Jun 27, 2011, 5:38:51 PM6/27/11

to chromium-dev, Thiago Farina, Scott Hess, brettw, Mark Mentovai, Darin Fisher

Thanks to the efforts of Thiago, Tony, and myself, /src/app has been almost completely yak-shaved out of existence, primarily being migrated to /src/ui (c.f. http://crbug.com/72317). The one remaining holdout is app/sql/, which clearly does not belong in ui/.

So the question is: to where does app/sql/ move? It's only used by /src/chrome and /src/webkit, which leads me to think there are three options:

1. Move it to base/. This will carry with it a dependency on third_party/sqlite. base/ already depends on a select few third_party libraries, but I completely understand any objection to this location.

2. Move it to webkit/. Since chrome/ can depend on this, it doesn't violate any dependency rules, but I think it's not quite appropriate.

3. Make it a top-level directory /src/sql. I don't think it's big enough (15 files including tests) to warrant this status, though.

4. <your brilliant idea here>

Option (1) is my preference, but I yield to the OWNERS. I've CCed some of them for their input.

Thanks,

Robert

rsesek / @chromium.org

Scott Hess

unread,

Jun 27, 2011, 5:54:56 PM6/27/11

to Robert Sesek, chromium-dev, Thiago Farina, brettw, Mark Mentovai, Darin Fisher

On Mon, Jun 27, 2011 at 2:38 PM, Robert Sesek <rse...@chromium.org> wrote:
> Thanks to the efforts of Thiago, Tony, and myself, /src/app has been
> almost completely yak-shaved out of existence, primarily being migrated to
> /src/ui (c.f. http://crbug.com/72317). The one remaining holdout is
> app/sql/, which clearly does not belong in ui/.
> So the question is: to where does app/sql/ move? It's only used by
> /src/chrome and /src/webkit, which leads me to think there are three
> options:
> 1. Move it to base/. This will carry with it a dependency on
> third_party/sqlite. base/ already depends on a select few third_party
> libraries, but I completely understand any objection to this location.

ls -l xcodebuild/Debug/{libsqlite3,libicuuc}.a
-rw-r--r-- 1 shess eng 8632400 Jun 21 16:50 xcodebuild/Debug/libicuuc.a
-rw-r--r-- 1 shess eng 1691176 Jun 23 15:27 xcodebuild/Debug/libsqlite3.a

I don't know, it doesn't freak me out that much to put it in base/.
Philosophically, there are lots of modules dependent on base/ which
certainly don't need sqlite, though.

> 2. Move it to webkit/. Since chrome/ can depend on this, it doesn't violate
> any dependency rules, but I think it's not quite appropriate.

I think this would be weird.

> 3. Make it a top-level directory /src/sql. I don't think it's big enough (15
> files including tests) to warrant this status, though.

That said, you can easily just ignore it. It doesn't seem tons less
likely than, say, googleurl.

-scott

Dirk Pranke

unread,

Jun 27, 2011, 6:03:35 PM6/27/11

to rse...@chromium.org, chromium-dev, Thiago Farina, Scott Hess, brettw, Mark Mentovai, Darin Fisher

On Mon, Jun 27, 2011 at 2:38 PM, Robert Sesek <rse...@chromium.org> wrote:

> Thanks to the efforts of Thiago, Tony, and myself, /src/app has been
> almost completely yak-shaved out of existence, primarily being migrated to
> /src/ui (c.f. http://crbug.com/72317). The one remaining holdout is
> app/sql/, which clearly does not belong in ui/.
> So the question is: to where does app/sql/ move? It's only used by
> /src/chrome and /src/webkit, which leads me to think there are three
> options:
> 1. Move it to base/. This will carry with it a dependency on
> third_party/sqlite. base/ already depends on a select few third_party
> libraries, but I completely understand any objection to this location.
> 2. Move it to webkit/. Since chrome/ can depend on this, it doesn't violate
> any dependency rules, but I think it's not quite appropriate.
> 3. Make it a top-level directory /src/sql. I don't think it's big enough (15
> files including tests) to warrant this status, though.

This gets my vote. If it feels like a standalone component, it should
probably be a standalone component. It seems like we may have more in
the future. Maybe there could be a top-level misc directory
eventually, if there are a bunch of smaller components?

-- Dirk

> 4. <your brilliant idea here>
> Option (1) is my preference, but I yield to the OWNERS. I've CCed some of
> them for their input.
> Thanks,
> Robert
> rsesek / @chromium.org
>

> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev
>

Evan Martin

unread,

Jun 27, 2011, 6:34:17 PM6/27/11

to dpr...@google.com, rse...@chromium.org, chromium-dev, Thiago Farina, Scott Hess, brettw, Mark Mentovai, Darin Fisher

On Mon, Jun 27, 2011 at 3:03 PM, Dirk Pranke <dpr...@chromium.org> wrote:
> On Mon, Jun 27, 2011 at 2:38 PM, Robert Sesek <rse...@chromium.org> wrote:
>> Thanks to the efforts of Thiago, Tony, and myself, /src/app has been
>> almost completely yak-shaved out of existence, primarily being migrated to
>> /src/ui (c.f. http://crbug.com/72317). The one remaining holdout is
>> app/sql/, which clearly does not belong in ui/.
>> So the question is: to where does app/sql/ move? It's only used by
>> /src/chrome and /src/webkit, which leads me to think there are three
>> options:
>> 1. Move it to base/. This will carry with it a dependency on
>> third_party/sqlite. base/ already depends on a select few third_party
>> libraries, but I completely understand any objection to this location.
>> 2. Move it to webkit/. Since chrome/ can depend on this, it doesn't violate
>> any dependency rules, but I think it's not quite appropriate.
>> 3. Make it a top-level directory /src/sql. I don't think it's big enough (15
>> files including tests) to warrant this status, though.
>
> This gets my vote. If it feels like a standalone component, it should
> probably be a standalone component. It seems like we may have more in
> the future. Maybe there could be a top-level misc directory
> eventually, if there are a bunch of smaller components?

We could even call such a directory "app/".

Robert Sesek

unread,

Jun 29, 2011, 9:33:29 AM6/29/11

to Dirk Pranke, chromium-dev, Thiago Farina, Scott Hess, brettw, Mark Mentovai, Darin Fisher

On Mon, Jun 27, 2011 at 6:03 PM, Dirk Pranke <dpr...@chromium.org> wrote:

This gets my vote. If it feels like a standalone component, it should
probably be a standalone component. It seems like we may have more in
the future. Maybe there could be a top-level misc directory
eventually, if there are a bunch of smaller components?

-- Dirk

Ok, I'm fine with this. We'll create a libsql and sql_unittests, add it to the waterfall, and remove app/. I don't think we yet have enough top-level components to worry about further organizing them.