Issue 131059 in chromium: Painting is sticky on latest canary

[chro...@googlecode.com]

Status: Untriaged
Owner: bac...@chromium.org
Labels: Type-Bug Pri-1 OS-Chrome

New issue 131059 by sean...@chromium.org: Painting is sticky on latest
canary
http://code.google.com/p/chromium/issues/detail?id=131059

Chrome Version : 21.0.1162.0
OS Version: 2391.0.0
Hardware: lumpy

What steps will reproduce the problem?
1. Connect to 30" monitor
2. Click the wrench menu
3. Scroll slowly through the menu items

What is the expected result?

Highlight follows mouse


What happens instead?

The highlight sticks on some menu items. There are also various other
sticky paint artifacts when scrolling pages.

[chro...@googlecode.com]

Updates:
Status: Available
Cc: shawnsi...@chromium.org dis...@chromium.org dan...@chromium.org
Labels: Feature-GPU-Compositing

Comment #1 on issue 131059 by bac...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059

Commenting out --ui-enable-partial-swaps from
/sbin/session_manager_setup.sh eliminates the problem --- suggesting that
this is a problem with damage tracking.

Added disher@ because this only happens when an external monitor is plugged
in.

seanpaul: This is a recent regression?

Attachments:
Screenshot 2012-06-04 3:54:58 PM.png 340 KB

[chro...@googlecode.com]

Updates:
Owner: cwo...@chromium.org
Cc: bac...@chromium.org

Comment #2 on issue 131059 by bac...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059

Chatted with seanpaul@ offline. This regression started on Friday.

Seems like a driver bug because it only happens with an external display
connected.

Assigning to cwolfe@ for further triaging....

[chro...@googlecode.com]

Comment #4 on issue 131059 by cwo...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059

Verified on Alex. Happens with an external display whenever one of the
screens is blanked. It is most obvious with mouse-over on the menu, but
have observed it freezing page content and scroll bar.

Moving the displayed regions around with Xrandr does not change the
behavior, so I suspect it is the Chrome-side damage tracking. Will start
bisecting and look for candidates.

[chro...@googlecode.com]

Updates:
Cc: pi...@chromium.org

Comment #6 on issue 131059 by cwo...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059

Bug was introduced by a possibly-accidental change to root_window.cc in
<https://chromiumcodereview.appspot.com/10444019/patch/5001/6003>.
Reverting the line reordering locally fixes the painting problem in that
rev and ToT.

Trivial fix uploaded for piman's review; if this needs more work I'll give
him the bug.

[chro...@googlecode.com]

Comment #9 on issue 131059 by bugdro...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059#c9

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140876

------------------------------------------------------------------------
r140876 | bac...@chromium.org | Wed Jun 06 16:02:06 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/aura/root_window.h?r1=140876&r2=140875&pathrev=140876
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/compositor/compositor.h?r1=140876&r2=140875&pathrev=140876
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/compositor/compositor.cc?r1=140876&r2=140875&pathrev=140876
M
http://src.chromium.org/viewvc/chrome/trunk/src/ui/aura/root_window.cc?r1=140876&r2=140875&pathrev=140876

aura: Drop unnecessary composites

During a composite pass, there are many commits that occur. The results of
these commits will be visible immediately, so we can cull the
scheduleComposite() calls that occur.

BUG=131059
TEST=manual: run with --force-compositing-mode; go to google.com; observe
only one draw per cursor blink via chrome://tracing


Review URL: https://chromiumcodereview.appspot.com/10537028
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #10 on issue 131059 by bac...@chromium.org: Painting is sticky on
latest canary
http://code.google.com/p/chromium/issues/detail?id=131059

(No comment was entered for this change.)