Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Chromium-bugs
About this group
Join this group
Message from discussion Issue 90078 in chromium: Implement components build for mac
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
chrom...@googlecode.com  
View profile  
 More options May 18 2012, 10:18 pm
From: chrom...@googlecode.com
Date: Sat, 19 May 2012 02:18:26 +0000
Local: Fri, May 18 2012 10:18 pm
Subject: Re: Issue 90078 in chromium: Implement components build for mac
Print | View thread | Show original | Find messages by this author

Comment #70 on issue 90078 by bugdro...@chromium.org: Implement components  
build for mac
http://code.google.com/p/chromium/issues/detail?id=90078#c70

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=138012

------------------------------------------------------------------------
r138012 | tha...@chromium.org | Fri May 18 19:12:02 PDT 2012

Changed paths:
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/rect_f.h?r1=13...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/point_f.h?r1=1...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/size.h?r1=1380...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/rect.h?r1=1380...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/size_f.h?r1=13...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/ui/gfx/point.h?r1=138...

Add instantiation declarations for PointBase, SizeBase, RectBase

These templates have explicit instantiations in point.cc, point_f.cc,  
size.cc,
size_f.cc, rect.cc, rect_f.cc. This suggests that the intent was to have  
these
instantiations in a single translation unit. Without an explicit  
instantiation
declaration, they would still be weakly emitted to all translation units  
that
use point.h (etc). Add an explicit instantiation declaration to stop this  
from
happening.

Thanks to Rafael Espindola for help with this patch.

BUG=90078
TEST=do a components debug build on mac. observe fewer linker errors.
Normal builds get a bit faster too.

Review URL: https://chromiumcodereview.appspot.com/10386220
------------------------------------------------------------------------


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
Create a group - Google Groups - Google Home - Terms of Service - Privacy Policy
©2013 Google