Re: Issue 130881 in chromium: ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch

[chro...@googlecode.com]

Updates:
Summary: ExtensionDownloader::FetchUpdatedExtension crashes browser on
every launch
Status: Assigned

Comment #8 on issue 130881 by a...@chromium.org:
ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Cc: ma...@chromium.org pawli...@chromium.org

Comment #9 on issue 130881 by ke...@google.com:

[chro...@googlecode.com]

Updates:
Labels: -Pri-1 -Type-Bug Pri-0 Type-Regression ReleaseBlock-Dev

Comment #10 on issue 130881 by ke...@google.com:

[chro...@googlecode.com]

Updates:
Cc: mih...@chromium.org

Comment #11 on issue 130881 by mih...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Antony is out on vacation (though getting back tomorrow). How sure are we
that his ExtensionDownloader changes are responsible? The last change to
that landed r139371, which first appeared in 21.0.1156.0 (a few canary
builds before the first report in his bug).

If it is a problem with Antony's changes, note that they got merged into
the M20 branch too (see last few commits on bug 129587)

I would bisect except I can't reproduce locally.

[chro...@googlecode.com]

Comment #12 on issue 130881 by ijpedow...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

This had happened for a few Canary builds, but I held off on reporting
until I could find the proper repro (not installing my extensions). Feel
free to inspect my account data to see which extensions I am using.

[chro...@googlecode.com]

Comment #13 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

> How sure are we that his ExtensionDownloader changes are responsible?

I'm not 100% sure. But he touched the code that is the last to run before
the crash, and he did it about a week ago, which is about right since the
dev channel just updated to a build that did this for me too.

[chro...@googlecode.com]

Comment #15 on issue 130881 by asar...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I'm not yet able to reproduce this locally. Would anyone who is able to be
willing to share a copy of their profile directory with me? (Please do not
attach it to this bug, instead contact me directly).

Alternatively, could someone with such a profile build a version of chrome
with the following two changes locally reverted:

svn revision 139371 (git 07c8689428a554ad42629de523673cde5e37d56b)
svn revision 138961 (git 37233482332d14311069f79b25b113c9886cb2c8)

and run that pointed at the profile and see if you get the same crash?

[chro...@googlecode.com]

Comment #16 on issue 130881 by rse...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131318 has been merged into this issue.

[chro...@googlecode.com]

Comment #17 on issue 130881 by bugdro...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch

http://code.google.com/p/chromium/issues/detail?id=130881#c17

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=140869

------------------------------------------------------------------------
r140869 | asar...@chromium.org | Wed Jun 06 15:37:59 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.h?r1=140869&r2=140868&pathrev=140869
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/webstore_installer.cc?r1=140869&r2=140868&pathrev=140869
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_constants.cc?r1=140869&r2=140868&pathrev=140869
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/updater/extension_updater_unittest.cc?r1=140869&r2=140868&pathrev=140869
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/updater/extension_downloader.cc?r1=140869&r2=140868&pathrev=140869

Revert r139371 and r138961

These seem to be causing crashes at startup for some users.

TBR=asar...@chromium.org

BUG=130881
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10532037
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #18 on issue 130881 by asar...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I think this must have something to do with sync state, because I still
could not reproduce the problem when running against a copy of Avi's
profile that he sent me (I was lacking his sync credentials that are stored
in the OSX keychain).

For now I've reverted the CL's on trunk while I continue to investigate,
and would appreciate it if someone could let me know if the next canary
build to come out makes the crashes go away.

[chro...@googlecode.com]

Updates:
Cc: will...@chromium.org asar...@chromium.org

Comment #19 on issue 130881 by mih...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131538 has been merged into this issue.

[chro...@googlecode.com]

Comment #20 on issue 130881 by qui...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Seeing the same problem on ChromeOS. (Chrome version 21.0.1166.0 Official
Build 140819, ChromeOS version 2404.0.0).

The revision number looks older than your CL, so I'll wait for a newer
version. But let me know if you want to get my profile data.

[chro...@googlecode.com]

Comment #21 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

today's Mac canary had this change as far as Ican see. Avi,do you still see
this problem on the Mac?

[chro...@googlecode.com]

Comment #22 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Alas, yes.

Process: Google Chrome Canary [43293]
Path: /Applications/Google Chrome
Canary.app/Contents/MacOS/Google Chrome Canary
Identifier: com.google.Chrome.canary
Version: 21.0.1167.0 (1167.0)
Code Type: X86 (Native)
Parent Process: launchd [302]

http://crash.corp.google.com/reportdetail?reportid=5a2a434dc6d5dc0f

I had difficulty bisecting this morning because each new version of
Chromium forced me to reauthorize my keychain items, yielding hundreds of
alerts. I'm going to try again with official builds and see if that helps.

[chro...@googlecode.com]

Comment #23 on issue 130881 by anna...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131807 has been merged into this issue.

[chro...@googlecode.com]

Comment #24 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

ok so we're planning on doing a dev release on Monday, is there something
we can do so we can make this build releasable in case u can't find the
issue? does everyone crash?

[chro...@googlecode.com]

Comment #25 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

This is already broken on dev. Pushing another dev with it broken sucks but
doesn't make things any worse.

[chro...@googlecode.com]

Updates:
Cc: a...@chromium.org

Comment #26 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

adding aaron.

[chro...@googlecode.com]

Updates:
Labels: Feature-Sync

Comment #27 on issue 130881 by anna...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

+sync team.

[chro...@googlecode.com]

Comment #28 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

There were a few changes a few days earlier by akalin that look like they
could maybe be related?

https://chromiumcodereview.appspot.com/10392192 (may 22)
https://chromiumcodereview.appspot.com/10412050 (may 23)

[chro...@googlecode.com]

Updates:
Cc: aka...@chromium.org

Comment #29 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

fred, is it possible? if so, can we maybe revert them for a day and see if
they are somehow causing the issue?

[chro...@googlecode.com]

Comment #30 on issue 130881 by t...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Bug 131807 mentions this worked if --disable-sync is passed. My hunch there
is that sync sent an extension over to a machine, and it is sitting in sync
state waiting to be "installed", and the first step is to fetch the URL.
The crash occurs when trying to fetch, but that fetch would not have
happened if sync wasn't in the picture (so I think sync is a slight red
herring, but not ruling it out).

I'm taking a look at akalin's patches now. He's ooo this week.

[chro...@googlecode.com]

Comment #31 on issue 130881 by anna...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

avi@, as you are still seeing, could you please try passing the following
flags:
--disable-extensions-file-access-check
--disable-extensions-resource-whitelist
--disable-extensions-http-throttling

Also, I assume you are syncing - is any of the accounts 2-factor enabled?

[chro...@googlecode.com]

Comment #32 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

On my personal MacBook I have two accounts: corp Google and home (an AFYD
dasher). Both have 2-factor.

OTOH, I have the same two accounts set up with work Chrome and don't see an
issue.

Will try the flags and post results.

[chro...@googlecode.com]

Comment #33 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

--disable-extensions-file-access-check
--disable-extensions-resource-whitelist
--disable-extensions-http-throttling

None of those flags changed the behavior; it still crashed.

[chro...@googlecode.com]

Comment #34 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

***

When on GoogleGuest, I crash. When on the Google corp network, I don't.

***

[chro...@googlecode.com]

Comment #35 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

And once I updated via the corp network, I no longer crash on GoogleGuest.

[chro...@googlecode.com]

Comment #36 on issue 130881 by mih...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Those flags disable random extensions-related functionality that hasn't
changed recently. --disable-extensions (which disables extensions
wholesale) may be more appropriate.

[chro...@googlecode.com]

Comment #37 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Hopefully you kept a copy of the crashy profile?? Pretty please?

[chro...@googlecode.com]

Comment #38 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

aa: of course I kept a copy. I'm back to crashing.

[chro...@googlecode.com]

Comment #39 on issue 130881 by t...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I'm guessing you guys have a corp extension installed? So possibly one of
your machines (on corp) updated a property of the extension specifics
(perhaps the update url?), synced it over to a non-corp machine, and for
some reason now fetching that url (which is possibly unreachable) crashes.

Fred's patches weren't supposed to have functional changes, hmm..

[chro...@googlecode.com]

Comment #40 on issue 130881 by z...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Can you run in a debug build with that same profile? If it's coming from
sync, it'll arrive via ExtensionSyncBundle::ProcessSyncChange(..), which
will call ExtensionService::ProcessExtensionSyncData.

It'd be interesting to know which particular extension is causing this.

[chro...@googlecode.com]

Comment #41 on issue 130881 by ste...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

FYI the console stuff from avi@ in comment 5 is unrelated to this crash,
but it is related to another issue which I am following up on, offline.

[chro...@googlecode.com]

Comment #42 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

in case it helps, i see this crash first on version 21.0.1160.0 which was
released a week ago. before that, if it's around, it's very low.

[chro...@googlecode.com]

Updates:
Owner: a...@chromium.org

Comment #48 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #49 on issue 130881 by bugdro...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch

http://code.google.com/p/chromium/issues/detail?id=130881#c49

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=141332

------------------------------------------------------------------------
r141332 | a...@chromium.org | Fri Jun 08 17:29:54 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/updater/extension_downloader.cc?r1=141332&r2=141331&pathrev=141332

Quick fix to skip invalid URLs in ExtensionDownloader.

We don't know why they appear yet, but this fixes a crash.

BUG=130881


Review URL: https://chromiumcodereview.appspot.com/10544083
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Cc: angel...@chromium.org je...@chromium.org su...@chromium.org
anna...@chromium.org

Comment #50 on issue 130881 by nkos...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131845 has been merged into this issue.

[chro...@googlecode.com]

Comment #51 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Aargh! 141332 just missed today's canary (21.0.1169.0), which cut at
141317. As soon as this hits a canary I'll test and if it works we can
merge to dev.

[chro...@googlecode.com]

Updates:
Labels: OS-Chrome

Comment #52 on issue 130881 by yus...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issues merged in #19 and #50 are OS-Chrome.

[chro...@googlecode.com]

Comment #53 on issue 130881 by a...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Confirmed not crashing any more on 21.0.1170.0.

[chro...@googlecode.com]

Comment #54 on issue 130881 by kar...@google.com:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

woot!! thanks so much to all of you! :)

[chro...@googlecode.com]

Comment #55 on issue 130881 by asar...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I was wondering whether we were simply allowing invalid urls for crx files
in the xml manifest that we get back from an update check, but it looks
like we filter them out in normal circumstances (see ParseSingleAppTag
function in chrome/common/extensions/update_manifest.cc).

I'll keep looking to see if I can spot ways we either modify these crx urls
or get them into the queue without going through this code path.

[chro...@googlecode.com]

Comment #57 on issue 130881 by y...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 132084 has been merged into this issue.

[chro...@googlecode.com]

Updates:
Cc: josa...@chromium.org so...@chromium.org osh...@chromium.org
stev...@chromium.org

Comment #58 on issue 130881 by xiy...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 132138 has been merged into this issue.

[chro...@googlecode.com]

Updates:
Cc: tturche...@chromium.org rche...@chromium.org

Comment #60 on issue 130881 by josa...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

As per comment #53 we should not have this crash in the latest Chrome OS
from ToT , we are going to validate no crash is seen in latest canary that
include 21.0.1172.0.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #61 on issue 130881 by josa...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Set as Fixed/ Crash is no longer seen in goto/crash for 21.0.1172.0 which
is live in canaries.
aa/asargent, please open a new issue for handling invalid URLs in xml
manifest (comment 55)

[chro...@googlecode.com]

Comment #62 on issue 130881 by josa...@chromium.org:

[chro...@googlecode.com]

Comment #63 on issue 130881 by josa...@chromium.org:

[chro...@googlecode.com]

Updates:
Status: Verified

Comment #64 on issue 130881 by tturche...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Closing this bug based on Comment 62.

[chro...@googlecode.com]

Comment #65 on issue 130881 by aka...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

I just saw this. Is there anything else that needs doing on the sync
side? Did my patches have anything to do with it?

[chro...@googlecode.com]

Updates:
Cc: nkos...@chromium.org

Comment #66 on issue 130881 by nkos...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch
http://code.google.com/p/chromium/issues/detail?id=130881

Issue 131997 has been merged into this issue.

[chro...@googlecode.com]

Comment #67 on issue 130881 by bugdro...@chromium.org:

ExtensionDownloader::FetchUpdatedExtension crashes browser on every launch

http://code.google.com/p/chromium/issues/detail?id=130881#c67

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=142058

------------------------------------------------------------------------
r142058 | asar...@chromium.org | Wed Jun 13 18:33:06 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/updater/extension_downloader.cc?r1=142058&r2=142057&pathrev=142058

Better logging in extension update code for case of invalid crx urls

It turns out that calling .spec() on an invalid url just returns the empty
string (and causes a DCHECK failure).

BUG=130881
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10534148
------------------------------------------------------------------------