Issue 131174 in chromium: Remove favicon from web intents dialog.

4 views
Skip to first unread message

chro...@googlecode.com

unread,
Jun 5, 2012, 9:40:23 AM6/5/12
to chromi...@chromium.org
Status: Assigned
Owner: gr...@chromium.org
CC: gaur...@chromium.org, kenmo...@chromium.org
Labels: Type-Bug Pri-1 Area-UI Mstone-21 Feature-WebIntents echo

New issue 131174 by joshwood...@chromium.org: Remove favicon from web
intents dialog.
http://code.google.com/p/chromium/issues/detail?id=131174

Google Chrome 21.0.1162.0 (Official Build 140191) canary
Platform 2391.0.0 (Official Build) canary-channel lumpy

What steps will reproduce the problem?
1. Open the web intents dialog via ECHO.
2. Observe the floating favicon.

What is the expected output? What do you see instead?
According to the email exchange from @glen on May 18, "No dialogs or
windows in Chrome should have a title."

@groby - I assume this also applies to the favicon? It looks rather odd in
this screenshot to me, don't you think? I propose we remove it.

Attachments:
Original dialog - 150 px.png 13.7 KB

chro...@googlecode.com

unread,
Jun 5, 2012, 1:05:25 PM6/5/12
to chromi...@chromium.org
Updates:
Status: WontFix

Comment #1 on issue 131174 by jhawk...@chromium.org: Remove favicon from
The design of the Web Intents Picker calls for the Service favicon and
title. This service hacks around that by setting an empty title, which is
not correct.

chro...@googlecode.com

unread,
Jun 6, 2012, 3:32:28 AM6/6/12
to chromi...@chromium.org

Comment #2 on issue 131174 by joshwood...@chromium.org: Remove favicon from
@jhawkins - Thanks for the quick response. I'm sorry, but I think I'm
confused. How does your comment about the service favicon and title
appearing relate to @glen's comment about "no title in Chrome dialogs."
Thanks!

chro...@googlecode.com

unread,
Jun 6, 2012, 12:21:42 PM6/6/12
to chromi...@chromium.org

Comment #3 on issue 131174 by jhawk...@chromium.org: Remove favicon from
The "title of the service" is not the title of the dialog. If we were to
position the favicon and title in the titlebar, that would probably be more
suspicious.

Regardless of rules about titles in dialogs, we must show the title of the
service due to security concerns. In addition we also need to display
security information (ssl status, origin, etc.) related to the service, but
we haven't figured out the right UI to expose it yet.

chro...@googlecode.com

unread,
Jun 7, 2012, 6:21:18 AM6/7/12
to chromi...@chromium.org
Updates:
Status: Assigned
Owner: gaur...@chromium.org
Cc: -gaur...@chromium.org gr...@chromium.org

Comment #4 on issue 131174 by joshwood...@chromium.org: Remove favicon from
@jhawkins - Got it, thanks!

@gauravsh - Given this, I think we should use the Google Drive favicon
along with "Google Drive" in this spot for the 'title of the service'. It
will be a bit redundant because just below that we'll say, "Google Drive
wants to verify..." but I think that redundancy makes the most sense for
users.

The favicon is attached. Let's see how this looks.



Attachments:
product16.png 1.5 KB

chro...@googlecode.com

unread,
Jun 7, 2012, 6:16:39 PM6/7/12
to chromi...@chromium.org
Updates:
Status: WontFix

Comment #5 on issue 131174 by gaur...@chromium.org: Remove favicon from
Josh: We can't use the favicon for Drive since the favicon needs to be
shared by all possible services. Lets sync up offline.

Reply all
Reply to author
Forward
0 new messages