Re: Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...

chro...@googlecode.com

unread,

Jan 12, 2012, 7:26:50 PM1/12/12

to chromi...@chromium.org

Comment #1 on issue 110105 by pkas...@chromium.org: Chrome: Crash Report
- Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

I don't know how GetDeviceCaps(..., LOGPIXELSY) can return 0, but I guess
there's no harm in bandaiding to just default to 96 in that case.

chro...@googlecode.com

unread,

Jan 12, 2012, 10:04:20 PM1/12/12

to chromi...@chromium.org

Comment #2 on issue 110105 by pkas...@chromium.org: Chrome: Crash Report

- Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

OK, per Carlos, this is likely due to GetDC() returning NULL, which is in
turn likely due to GDI handle exhaustion or similar.

In this case Chrome is going to behave really badly and the best thing for
the user is just going to be to force a browser crash. The current code
already does that (by accident), but we can make things clearer by
CHECK()ing the result of GetDC().

chro...@googlecode.com

unread,

Jun 7, 2012, 6:00:39 PM6/7/12

to chromi...@chromium.org

Updates:
Status: Fixed

Comment #8 on issue 110105 by pkas...@chromium.org: Chrome: Crash Report

- Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

Fixed in r141087.

chro...@googlecode.com

unread,

Jun 7, 2012, 6:08:39 PM6/7/12

to chromi...@chromium.org

Updates:
Summary: Chrome: Crash Report - Stack Signature:
OmniboxViewWin::OmniboxViewWin(Autocomplete...

Comment #9 on issue 110105 by bugdro...@chromium.org: Chrome: Crash Report

- Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...

http://code.google.com/p/chromium/issues/detail?id=110105#c9

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=141087

------------------------------------------------------------------------
r141087 | pkas...@chromium.org | Thu Jun 07 14:42:23 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_win.cc?r1=141087&r2=141086&pathrev=141087
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/win/scoped_hdc.h?r1=141087&r2=141086&pathrev=141087

Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL.

Use scoping objects more in the omnibox code.

BUG=110105
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10545045
------------------------------------------------------------------------

Reply all

Reply to author

Forward