Issue 131772 in chromium: SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

[chro...@googlecode.com]

Status: Untriaged
Owner: dgo...@chromium.org
CC: kaznach...@chromium.org, se...@chromium.org, achu...@chromium.org
Labels: Type-Bug Pri-1 Area-UI OS-Chrome Feature-FileManager Iteration-57
Mstone-21

New issue 131772 by achu...@chromium.org: SelectFileDialog::SELECT_FOLDER
should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

I'm working on enabling the option to change your default download folder:
crbug.com/127159

However, SelectFileDialog with SELECT_FOLDER does not allow you to select
Drive or Downloads. You can select sub-directories.

[chro...@googlecode.com]

Issue 131772: SelectFileDialog::SELECT_FOLDER should allow selection of top
level folders
http://code.google.com/p/chromium/issues/detail?id=131772

This issue is no longer blocking issue 127159.
See http://code.google.com/p/chromium/issues/detail?id=127159
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: se...@chromium.org
Cc: -se...@chromium.org dgo...@chromium.org

Comment #1 on issue 131772 by achu...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #3 on issue 131772 by kenmo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

I'm imagining a mode/flag for SelectFileDialog which has a hidden left
column and starts at the uber-root level where the 2 items you see in the
list are Drive and Downloads. The user could select either of those, or
drill down to select a folder. There would need to be a new uber-root node
in the breadcrumbs (perhaps named "Chrome") so they could get back to the
top level.

Thoughts?

[chro...@googlecode.com]

Comment #4 on issue 131772 by joshwood...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

@kenmoore - I'm hesitant to use Chrome because it's used a lot and might
add confusion: Chrome the browser?, the OS?, etc. Some ideas:

1) 'Files' (the app's name, though a little bit confusing, e.g. 'Files >
Drive')
2) 'Chromebook' or 'Chromebox', based on the device (seems like more work
but is the most concrete)

Open to other ideas here.

[chro...@googlecode.com]

Comment #5 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

I don't like implicit different modes. This will confuse user.
And we just moved from that uber-root when introduced left panel.

What about more lightweight way? For example, we can select the root by
double-clicking in left panel. Or we can show the border around selected
item and let the Ok button select the root, if nothing in the list is
selected. WDYT?

[chro...@googlecode.com]

Comment #6 on issue 131772 by achu...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

I like the latter suggestion (selection border + Open button enabled).
That's what I was expecting when I was testing this.

[chro...@googlecode.com]

Comment #7 on issue 131772 by joshwood...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

This may be a silly question, but why can't we simply let a user select
Drive in the left panel, and then allow him/ her to hit OK? (I'd lean away
from a lead item border around an item in the left panel)

@kenmoore - Thoughts?

[chro...@googlecode.com]

Comment #8 on issue 131772 by achu...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

This is blocking http://code.google.com/p/chromium/issues/detail?id=127159
so I hope we can get this in this week..

[chro...@googlecode.com]

Updates:
Owner: dgo...@chromium.org
Cc: -dgo...@chromium.org se...@chromium.org

Comment #9 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

So, I will just enable OK button when nothing is selected in list. Clicking
OK will select the current root.
If you have any objections, post here.

[chro...@googlecode.com]

Comment #10 on issue 131772 by se...@google.com:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

It basically as other OSes treat this case: not allowing selecting files,
when not directory selected OK means the user chooses the current directory.

I guess you need to modify the selection controller to support unselectable
items in the file list.

Another option is not to show files in this dialog. Actually it looks
simpler to implement and simpler to use. Only use of files in this dialog
is helping the user to recognize known directory by list of files. Not sure
it's so helpful.

[chro...@googlecode.com]

Comment #11 on issue 131772 by achu...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Comment #9 sounds good to me.

[chro...@googlecode.com]

Comment #12 on issue 131772 by joshwood...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Comment 9 SGTM, too.

[chro...@googlecode.com]

Updates:
Status: Started

Comment #15 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Created a separate issue 132976 for UI change.

CL allowing to select current folder:
https://chromiumcodereview.appspot.com/10559004/.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #16 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

[chro...@googlecode.com]

Comment #17 on issue 131772 by bugdro...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

http://code.google.com/p/chromium/issues/detail?id=131772#c17

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=142387

------------------------------------------------------------------------
r142387 | dgo...@chromium.org | Fri Jun 15 06:37:43 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=142387&r2=142386&pathrev=142387

[filemanager] Allow user to select current directory when nothing in list
is selected.

BUG=131772
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/10559004
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #19 on issue 131772 by bugdro...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

http://code.google.com/p/chromium/issues/detail?id=131772#c19

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=142968

------------------------------------------------------------------------
r142968 | dgo...@chromium.org | Tue Jun 19 09:12:52 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=142968&r2=142967&pathrev=142968

[filemanager] Fix problems when Drive root is set as default folder.

- Fixed exception when selecting the Drive root in open-folder dialog.
- Fixed defaultPath handling: adding leading slash if necessary.

BUG=131772
TEST=See bug.

Review URL: https://chromiumcodereview.appspot.com/10586002
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #20 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

[chro...@googlecode.com]

Updates:
Status: Assigned

Comment #21 on issue 131772 by sivag...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Tested in R21-Dev 2465.3.0

Cannot set /Downloads and /Drive as default location. After selecting
/Downloads or /Drive, clicking on "Open" button does not do anything.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #22 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Fixed in r143578.

[chro...@googlecode.com]

Comment #23 on issue 131772 by bugdro...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

http://code.google.com/p/chromium/issues/detail?id=131772#c23

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=143578

------------------------------------------------------------------------
r143578 | dgo...@chromium.org | Fri Jun 22 06:09:18 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=143578&r2=143577&pathrev=143578

[filemanager] Moved summarizeSelection call sooner in initialization.

This also fixes the bad merge.

BUG=131772
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/10631013
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Assigned
Labels: Merge-Requested

Comment #24 on issue 131772 by sivag...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Fix r143578 is not landed in R21 branch 21.0.1180.9/2465.19.0

Reopening to merge the fix in R21 branch

[chro...@googlecode.com]

Comment #25 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Both r143578 and r142968 have to be merged.

[chro...@googlecode.com]

Updates:
Labels: Iteration-59

Comment #26 on issue 131772 by zeli...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

not merged yet?

[chro...@googlecode.com]

Comment #27 on issue 131772 by dgo...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

No, this is not approved yet.

[chro...@googlecode.com]

Issue 131772: SelectFileDialog::SELECT_FOLDER should allow selection of top
level folders
http://code.google.com/p/chromium/issues/detail?id=131772

This issue is now blocking issue chromium:127159.

[chro...@googlecode.com]

[chro...@googlecode.com]

Comment #32 on issue 131772 by bugdro...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

http://code.google.com/p/chromium/issues/detail?id=131772#c32

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=144542

------------------------------------------------------------------------
r144542 | zeli...@chromium.org | Wed Jun 27 13:52:18 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=144542&r2=144541&pathrev=144542

Merge 143578 - [filemanager] Moved summarizeSelection call sooner in

initialization.

This also fixes the bad merge.

BUG=131772
TEST=See bug.
Review URL: https://chromiumcodereview.appspot.com/10631013

TBR=dgo...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10698015
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Labels: merge-merged-1180

Comment #31 on issue 131772 by bugdro...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders

http://code.google.com/p/chromium/issues/detail?id=131772#c31

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=144540

------------------------------------------------------------------------
r144540 | zeli...@chromium.org | Wed Jun 27 13:51:36 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1180/src/chrome/browser/resources/file_manager/js/file_manager.js?r1=144540&r2=144539&pathrev=144540

Merge 142968 - [filemanager] Fix problems when Drive root is set as default

folder.

- Fixed exception when selecting the Drive root in open-folder dialog.
- Fixed defaultPath handling: adding leading slash if necessary.

BUG=131772
TEST=See bug.

Review URL: https://chromiumcodereview.appspot.com/10586002

TBR=dgo...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10699011
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Verified

Comment #33 on issue 131772 by sivag...@chromium.org:

SelectFileDialog::SELECT_FOLDER should allow selection of top level folders
http://code.google.com/p/chromium/issues/detail?id=131772

Verified in R21 Dev 2465.30.0/Chrome 21.0.1180.18