Re: Issue 131474 in chromium: Support high DPI profile images

33 views
Skip to first unread message

chro...@googlecode.com

unread,
Jun 7, 2012, 7:30:27 AM6/7/12
to chromi...@chromium.org
Updates:
Summary: Support high DPI profile images
Status: Available
Cc: nkos...@chromium.org
Labels: -Mstone-21 Mstone-22 OS-Chrome

Comment #2 on issue 131474 by rby...@chromium.org: Support high DPI profile
images
http://code.google.com/p/chromium/issues/detail?id=131474

I think this is profile images, both pre-defined and captured from the
camera.

chro...@googlecode.com

unread,
Jun 7, 2012, 8:29:16 AM6/7/12
to chromi...@chromium.org
Updates:
Status: Assigned
Owner: iva...@chromium.org
Cc: mlc...@chromium.org

Comment #3 on issue 131474 by nkos...@chromium.org: Support high DPI
profile images
http://code.google.com/p/chromium/issues/detail?id=131474

Yes, we're planning to capture 320x320 instead current 160x160.

Min, are high-res version of predefined profile pictures tracked elsewhere?

chro...@googlecode.com

unread,
Jun 7, 2012, 10:14:12 AM6/7/12
to chromi...@chromium.org
Updates:
Cc: pkotw...@chromium.org

Comment #4 on issue 131474 by rby...@chromium.org: Support high DPI profile
images
http://code.google.com/p/chromium/issues/detail?id=131474

Note there's probably work required to get them to pain high-res too.
Please co-ordinate with pkotwicz to decide who will do what and break this
up into two bugs if the work will be done by different people.

chro...@googlecode.com

unread,
Jun 7, 2012, 10:18:42 AM6/7/12
to chromi...@chromium.org

Comment #5 on issue 131474 by nkos...@chromium.org: Support high DPI
profile images
http://code.google.com/p/chromium/issues/detail?id=131474

>> there's probably work required to get them to pain high-res too

Could you please provide more details on that?

chro...@googlecode.com

unread,
Jun 7, 2012, 10:25:54 AM6/7/12
to chromi...@chromium.org

Comment #6 on issue 131474 by rby...@chromium.org: Support high DPI profile
images
http://code.google.com/p/chromium/issues/detail?id=131474

See issue 124566 for lots of CLs that have landed across Chrome for this.
Mostly it means using ImageSkia to get multi-resolution images. Ping
pkotwicz on IM to chat about details - or feel free to split this bug into
two pieces and assign one to him.


chro...@googlecode.com

unread,
Jun 7, 2012, 2:19:04 PM6/7/12
to chromi...@chromium.org

Comment #7 on issue 131474 by mlc...@chromium.org: Support high DPI profile
images
http://code.google.com/p/chromium/issues/detail?id=131474

Re: Comment #3 - no, we don't have the predefined profile pictures in
high-res yet. Coming soon!

Re: Comment #6 - chatted with pkotwicz on IM: for assets like predefined
profile pictures, we should be able to check them in and they should work.
For capturing from camera in 320x320, we need to decide whether we want to
save to the file system profile pictures for each resolution, 1x and 2x.
And we need to make sure we pass in the correct density when we create the
ImageSkia in take_photo_view.


chro...@googlecode.com

unread,
Jun 9, 2012, 5:57:10 AM6/9/12
to chromi...@chromium.org

Comment #9 on issue 131474 by nkos...@chromium.org: Support high DPI
profile images
http://code.google.com/p/chromium/issues/detail?id=131474

>> For capturing from camera in 320x320

We might be switching to capturing 512x512 frame from camera since we have
256x256 css px preview frame for it (and for each predefined profile
picture).

When displayed at login screen these are shown in 160x1600 css px.

>> we need to decide whether we want to save to the file system profile
>> pictures for each resolution, 1x and 2x

I think it makes sense to save single high-res version since it will be
synced eventually.

>> High-res version of predefined profile pictures are now available here:

Thanks, these now are 1024x1024. I think it makes sense to resize them to
512x512 as the largest frame were we show them is 256x256 css px frame.

chro...@googlecode.com

unread,
Jun 9, 2012, 6:03:09 AM6/9/12
to chromi...@chromium.org

Comment #10 on issue 131474 by iva...@chromium.org: Support high DPI
profile images
http://code.google.com/p/chromium/issues/detail?id=131474

Actually, we can only capture 640x480 from camera, but I guess 480x480
picture should be still OK.

chro...@googlecode.com

unread,
Jun 9, 2012, 6:04:10 AM6/9/12
to chromi...@chromium.org
Updates:
Status: Started

Comment #11 on issue 131474 by iva...@chromium.org: Support high DPI
profile images
http://code.google.com/p/chromium/issues/detail?id=131474

(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages