Re: Issue 131510 in chromium: "Confirm changes" (sideload) dialog erroneously appears on sign-in

[chro...@googlecode.com]

Updates:
Labels: -area-ui -Sev-2 Area-UI Feature-Ash

Comment #3 on issue 131510 by sain...@chromium.org: "Confirm changes"
(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Owner: kal...@chromium.org

Comment #8 on issue 131510 by kal...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Assigning to myself since it's a blocker for 137469 (according to the bug
tracker).

[chro...@googlecode.com]

Comment #9 on issue 131510 by kal...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Could you give more details on how to reproduce this bug?
- what machines have sync set up?
- which machine(s) saw the warning?
- which machine(s) didn't see the warning?
- has it happened since May?

I ask because I just had a go at reproducing this by
- setting up chromeos sync with a test account (canary v22)
- signing into chrome on ubuntu (v22)

I was operating under the assumption that stuff was getting synced from
chromeos onto ubuntu, triggering the warning; however it looks like we
don't actually sync OS-installed extensions anymore, so its moot.

Is this all correct?

[chro...@googlecode.com]

Updates:
Status: Available
Owner: ---

Comment #11 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

[chro...@googlecode.com]

Updates:
Cc: -jhurw...@chromium.org plud...@chromium.org

Comment #12 on issue 131510 by kenmo...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Saw this again yesterday after getting the latest canary update (2909.0.0).

Attachments:
Screenshot 2012-09-18 at 8.11.23 PM.png 11.4 KB

[chro...@googlecode.com]

Updates:
Cc: kal...@chromium.org

Comment #13 on issue 131510 by plud...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

[chro...@googlecode.com]

Comment #14 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Maybe we should just kill it in M23 (and even M22). It doesn't seem to work
properly, it's not that useful when it does.

[chro...@googlecode.com]

Updates:
Labels: Review-UI

Comment #15 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

+ui.

Dear UI team, are you ok with me disabling this feature for a little while?
It's already live in older Chrome versions, but doesn't work very well.

[chro...@googlecode.com]

Updates:
Labels: -Review-UI

Comment #16 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Nevermind. We're going to keep it.

[chro...@googlecode.com]

Updates:
Status: Assigned
Owner: y...@chromium.org

Comment #17 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Yoyo, can you look into this for M24? It's really important that we never
classify default installed extensions as sideloaded.

[chro...@googlecode.com]

Updates:
Labels: -Mstone-23 MovedFrom-23 Mstone-24

Comment #18 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

[chro...@googlecode.com]

Issue 131510: "Confirm changes" (sideload) dialog erroneously appears on
sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

This issue is now blocking issue chromium:154401.
See http://code.google.com/p/chromium/issues/detail?id=154401

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[chro...@googlecode.com]

Updates:
Cc: g...@chromium.org

Comment #22 on issue 131510 by y...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

My hunch is that this is happening when the set of default apps changes and
a new app is added, because the alert dialog is only suppressed once, when
the profile is created. This is consistent with the screenshots reported
above.

Fortunately, it looks like grv's r153554 added a way to tell which are the
default apps more easily.

[chro...@googlecode.com]

Comment #23 on issue 131510 by y...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Gaurav, is it your understanding that default apps used to be installed
with EXTERNAL location and are now INTERNAL? This alert only shows for
EXTERNAL install locations.

[chro...@googlecode.com]

Comment #24 on issue 131510 by g...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

@yoz Yes, the default apps use to be installed as location = EXTERNAL and i
converted them to have location as INTERNAL. The
function "was_installed_by_default" will work only for porfiles and chrome
installs post Chrome-23. For older versions, it will return false since the
default_app preference is not present.

[chro...@googlecode.com]

Comment #25 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

What about on Chrome OS? I think that the default install mechanism is
implemented differently there, and those extensions might be EXTERNAL.

/me checks his Chrome OS device...

[chro...@googlecode.com]

Updates:
Labels: OS-Chrome

Comment #26 on issue 131510 by y...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

[chro...@googlecode.com]

Updates:
Owner: mpcom...@chromium.org
Cc: dpol...@chromium.org

Comment #27 on issue 131510 by a...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Yeah, on Chrome OS, default apps are marked as EXTERNAL_PREFS. Does this UI
show up everytime new default apps are installed on Chrome OS? It seems
like it should, but if that were the case, I'd expect a lot more reports.

In any case, there's an easy solution: Let's just not show this UI on
Chrome OS. It doesn't make sense there since sideloading isn't a problem on
Chrome OS.

Reassigning to Matt since he's working on the latest iteration of this UI.

[chro...@googlecode.com]

Comment #28 on issue 131510 by dpol...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

I agree, we should completely disable side load UI on Chrome OS.

[chro...@googlecode.com]

Comment #29 on issue 131510 by erik...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

agree. sounds like a great approach.

[chro...@googlecode.com]

Comment #30 on issue 131510 by bugdro...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in

http://code.google.com/p/chromium/issues/detail?id=131510#c30

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=162380

------------------------------------------------------------------------
r162380 | mpcom...@chromium.org | 2012-10-17T13:18:03.940862Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/feature_switch.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/theme/theme_resources.grd?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service_unittest.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_switches.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_service.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome_browser_extensions.gypi?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/global_error/global_error.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/global_error/global_error.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_install_prompt.h?r1=162380&r2=162379&pathrev=162380
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/external_install_ui.cc?r1=162380&r2=162379&pathrev=162380
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/external_install_ui.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_command_ids.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/pending_extension_manager.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_prefs.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/global_error/global_error_service_unittest.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/global_error/global_error_service.cc?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertest.h?r1=162380&r2=162379&pathrev=162380
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/feature_switch.cc?r1=162380&r2=162379&pathrev=162380

New post-sideload UI:
- External extensions are installed initially disabled.
- Global error appears in menu, which will show an install dialog when
clicked.

TBR=s...@chromium.org
BUG=137469,131510

Review URL: https://chromiumcodereview.appspot.com/11150002
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #31 on issue 131510 by mpcom...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in
http://code.google.com/p/chromium/issues/detail?id=131510

Disabled sideload UI on Chrome OS, so this should no longer happen.

[chro...@googlecode.com]

Updates:
Labels: -Merge-Approved merge-merged-1271

Comment #35 on issue 131510 by bugdro...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in

http://code.google.com/p/chromium/issues/detail?id=131510#c35

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=162860

------------------------------------------------------------------------
r162860 | mpcom...@chromium.org | 2012-10-19T00:34:49.059097Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/extensions/extension_service.cc?r1=162860&r2=162859&pathrev=162860

Disable sideload UI bubble on ChromeOS.

BUG=131510
Review URL: https://codereview.chromium.org/11193039
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #36 on issue 131510 by bugdro...@chromium.org: "Confirm changes"

(sideload) dialog erroneously appears on sign-in

http://code.google.com/p/chromium/issues/detail?id=131510#c36

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=163034

------------------------------------------------------------------------
r163034 | mpcom...@chromium.org | 2012-10-19T18:32:15.493475Z

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1271/src/chrome/browser/extensions/extension_service_unittest.cc?r1=163034&r2=163033&pathrev=163034

Disable failing ExtensionServiceTest.AlertableExtensionHappyPath on
chromeos.

It's testing the feature that I disabled.

BUG=131510
TBR=zeli...@chromium.org
Review URL: https://codereview.chromium.org/11225010
------------------------------------------------------------------------