Re: Issue 131306 in chromium: Hard to see impact of optimizations on successive timeline recordings in the frame graph

[chro...@googlecode.com]

Comment #1 on issue 131306 by stefa...@chromium.org: Hard to see impact of
optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

would introducing a vertical scale solve the problem?

[chro...@googlecode.com]

Comment #2 on issue 131306 by nd...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

That might work! :)

I'd be curious how that fares against always having the Y axis be
0-1000/30.0ms, such that 16.6ms was exactly in the middle. That is very
predictable.

[chro...@googlecode.com]

Comment #3 on issue 131306 by pfeld...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

I am with Nat on this one. I.e. 33.3 as a total.

[chro...@googlecode.com]

Updates:
Status: Started
Owner: ca...@chromium.org

Comment #4 on issue 131306 by ca...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Proposed fix upstream (also a couple of screenshots):
https://bugs.webkit.org/show_bug.cgi?id=88556

I left a fallback to autoscale -- otherwise, in cases where all frames are
long, all bars go for the entire height of the window and overview just
stops making sense.
Also added two horizontal lines @ 30 and 60fps.

Another option that I see is providing some ping-like statistics in a
pop-up over overview, e.g.:

frame duration: min 0.015ms avg 0.18 max 0.120ms etc.

Would it make sense?

[chro...@googlecode.com]

Comment #5 on issue 131306 by nd...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

That's a fair point, I do understand the point behind "everything is slow"
case.

I really like the horizontal lines. Can we make them on-top so they're more
obvious? They're very faint.

[chro...@googlecode.com]

Updates:
Cc: vse...@chromium.org

Comment #6 on issue 131306 by ca...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

(No comment was entered for this change.)

[chro...@googlecode.com]

Comment #7 on issue 131306 by ca...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Made lines darker, added two screenshots for lines in foreground and in
background.

[chro...@googlecode.com]

Comment #9 on issue 131306 by ca...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

> /me wonders if we should use two colors that aren't being used for color
> categories. E.g. bright red or something. Using purple and green I think
> imply to a casual consumer that those are where you want your purple and
> green lines to be, which at all the case.

Changed it to pale pink -- doesn't look too aggressive (IMHO), but well
visible over both white and colored bars.

> dumb question guy has a dumb question... erm, the lower of the two lines
> --- does
> that imply 120fps or 30? It seems to me since the heights of these bars
> are
> **duration** not rate, the lower one would be 120, but then it makes me
> think we
> really only need the 60fps line.

We always draw just lines for 30 (higher) and 60 (lower) FPS . But I do
read you -- added labels ;)

[chro...@googlecode.com]

Comment #10 on issue 131306 by pfeld...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

I would draw them using dark color (#333), probably using dotted pattern.

[chro...@googlecode.com]

Comment #11 on issue 131306 by nd...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Thanks so much guys! The latest screenshot is very <3.

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #12 on issue 131306 by ca...@chromium.org: Hard to see impact of

optimizations on successive timeline recordings in the frame graph
http://code.google.com/p/chromium/issues/detail?id=131306

Cool! Landed it as http://trac.webkit.org/changeset/119896