Issue 129682 in chromium: Remove GSG from showing in retail mode.

[chro...@googlecode.com]

Status: Assigned
Owner: dpol...@chromium.org
CC: r...@chromium.org, nkos...@chromium.org
Labels: Type-Bug Pri-1 Area-UI Mstone-20 OS-Chrome feature-kioskmode

New issue 129682 by joshwood...@chromium.org: Remove GSG from showing in
retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

What steps will reproduce the problem?
1. Enroll a device into retail mode.
2. Start the machine and move the mouse while viewing the screensaver.
3. It logs you in.

What is the expected output?
2 windows are displayed: the "Chrome OS demo app" and a regular window with
the New Tab page.

What do you see instead?
2 windows are displayed: the "Chrome OS demo app" and a regular window with
the New Tab page *AND* the Getting Started Guide (GSG).

The GSG should never show in retail mode. Logic: the "Chrome OS demo app"
covers similar material, and we don't want to overwhelm users with too many
windows.

This issue was raised in
http://code.google.com/p/chromium/issues/detail?id=126743#c32, and we
decided to create a separate bug to track it.

Putting Mstone-20 on this for now; talking to @caesars about if we should
put this into Mstone-19.



Please use labels and text to provide additional information.

[chro...@googlecode.com]

Updates:
Owner: nkos...@chromium.org
Cc: -nkos...@chromium.org dpol...@chromium.org

Comment #1 on issue 129682 by dpol...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Nikita, could you please fix this issue ASAP? I don't have device right now
to test changes.

It looks like we need to check demo mode with
user_manager->IsLoggedInAsDemoUser() in
ExistingUserController::OptionallyShowReleaseNotes and do nothing in this
case.

[chro...@googlecode.com]

Updates:
Cc: mnis...@chromium.org

Comment #2 on issue 129682 by dpol...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

(No comment was entered for this change.)

[chro...@googlecode.com]

Updates:
Status: Started
Owner: r...@chromium.org

Comment #3 on issue 129682 by r...@chromium.org: Remove GSG from showing in

[chro...@googlecode.com]

Comment #4 on issue 129682 by r...@chromium.org: Remove GSG from showing in
retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

I've sent a CL out for review (http://codereview.chromium.org/10446032/)
but currently I have not been able to test this properly.

On ToT, when trying to enroll my machine on a base or dev image seems to
put Chrome on a crashing loop; on a test image, this doesn't happen. I have
to investigate why this is.

On a test image, with the patch, the GSC doesn't show up, but then on a
test image even without the patch, the GSC doesn't show up.

This 'looks' like the correct code fix, just not verified it for sure yet.

[chro...@googlecode.com]

Comment #5 on issue 129682 by bugdro...@chromium.org: Remove GSG from
showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682#c5

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=138996

------------------------------------------------------------------------
r138996 | r...@chromium.org | Thu May 24 22:16:55 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=138996&r2=138995&pathrev=138996

Don't show release notes if in Kiosk Mode.
If we're in KioskMode, don't show the release notes/getting started page.

R=dpol...@chromium.org,nkos...@chromium.org
BUG=129682
TEST=Tested with a test image but this is not a complete test, since the
test image wasn't reproing the issue in the first place.


Review URL: https://chromiumcodereview.appspot.com/10446032
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed
Cc: scunning...@chromium.org

Comment #6 on issue 129682 by r...@chromium.org: Remove GSG from showing in
retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Marking as fixed for verification - once this is verified, I'll merge this
in.
Scott, you mentioned to Josh that you saw this repro? Could you try a
latest ToT build after the revision this went in on to verify that the
issue is fixed and update the bug accordingly?

[chro...@googlecode.com]

Updates:
Status: Verified

Comment #7 on issue 129682 by debs...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Verified at 2268.36.0 (Cr 20.0.1132.19).
2 windows are displayed: the "Tips and Tricks" and a regular window with
the New Tab page.

[chro...@googlecode.com]

Updates:
Labels: Merge-Requested

Comment #8 on issue 129682 by r...@chromium.org: Remove GSG from showing in
retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

[chro...@googlecode.com]

Updates:
Labels: -Merge-Requested Merge-Approved

Comment #9 on issue 129682 by dhar...@google.com: Remove GSG from showing

[chro...@googlecode.com]

Updates:
Status: Assigned
Cc: debs...@chromium.org

Comment #10 on issue 129682 by scunning...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

'Tips and Tricks' is tool-tip for the Launcher icon for the Getting Started
Guide app. So, sadly... this build is now displaying the GSG, not the
Chrome OS Demo App.

[chro...@googlecode.com]

Comment #15 on issue 129682 by r...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

This one was a pain to track down; apparently the StartupUrl is "not set"
on the dixons retail domain - the 'startup window' that we see is just an
app launching itself on install.

In case that we don't have at least one startup URL, the demo mode check
was being bypassed and the GSC was getting loaded.

Fixed and merging.

[chro...@googlecode.com]

Comment #16 on issue 129682 by bugdro...@chromium.org: Remove GSG from
showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682#c16

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=139683

------------------------------------------------------------------------
r139683 | r...@chromium.org | Wed May 30 16:32:13 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=139683&r2=139682&pathrev=139683

Disable showing GSC when in KioskMode.
If the startup URL is not set, even in kiosk mode, the GSC would show; this
CL fixes that.

R=dpol...@chromium.org,nkos...@chromium.org
BUG=129682
TEST=Tested on a base image and verified that the GSC doesn't show up
anymore.

Review URL: https://chromiumcodereview.appspot.com/10456043
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #17 on issue 129682 by r...@chromium.org: Remove GSG from showing
in retail mode.

[chro...@googlecode.com]

Comment #18 on issue 129682 by bugdro...@chromium.org: Remove GSG from
showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682#c18

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=139687

------------------------------------------------------------------------
r139687 | r...@chromium.org | Wed May 30 16:35:58 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1132/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=139687&r2=139686&pathrev=139687

Merge 139683 - Disable showing GSC when in KioskMode.

If the startup URL is not set, even in kiosk mode, the GSC would show; this
CL fixes that.

R=dpol...@chromium.org,nkos...@chromium.org
BUG=129682
TEST=Tested on a base image and verified that the GSC doesn't show up
anymore.

Review URL: https://chromiumcodereview.appspot.com/10456043

TBR=r...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10454087
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #19 on issue 129682 by joshwood...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

@rkc - Thanks for merging into M20! There may be a M19.1 stable release
update that we could squeeze this into. Stay tuned...

[chro...@googlecode.com]

Updates:
Labels: -Mstone-20 Mstone-19 Merge-Requested

Comment #22 on issue 129682 by r...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Requesting merge for 19.

[chro...@googlecode.com]

Comment #23 on issue 129682 by josa...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

@rkc/debsahu: Is https://code.google.com/p/chromium/issues/detail?id=130602
a regression on 20 only? will same issue be on 19 once CL is merged?

[chro...@googlecode.com]

Comment #24 on issue 129682 by r...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

From what I know, it's a R20 regression.
I still don't have a merge approval for 19 yet for this anyway.

If you look at comment 7, Issue 130602 was showing up even before this fix
was in for R20.

"2 windows are displayed: the "Tips and Tricks" and a regular window with
the New Tab page."

i.e., the ChromeOS demo window was already not showing up at that point.


These two issues are completely unrelated.

[chro...@googlecode.com]

Comment #25 on issue 129682 by r...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Ping?

[chro...@googlecode.com]

Comment #26 on issue 129682 by scunning...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Verified both problems fixed in 2268.57.0 (Cr 20.0.1132.27):
1) GSG does not appear.
2) Chrome OS window opens.

Note that, per bug 130602, one must wait ~30 seconds after enrollment is
successful, before clicking the [Done] button. If you don't wait long
enough, the Chrome OS window will not be opened.

[chro...@googlecode.com]

Comment #27 on issue 129682 by josa...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Thanks Scott, Merge approved for R19

[chro...@googlecode.com]

Updates:
Labels: merge-merged-1084

Comment #28 on issue 129682 by bugdro...@chromium.org: Remove GSG from
showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682#c28

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=140909

------------------------------------------------------------------------
r140909 | r...@chromium.org | Wed Jun 06 17:54:42 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1084/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=140909&r2=140908&pathrev=140909

Merge 139683 - Disable showing GSC when in KioskMode.
If the startup URL is not set, even in kiosk mode, the GSC would show; this
CL fixes that.

R=dpol...@chromium.org,nkos...@chromium.org
BUG=129682
TEST=Tested on a base image and verified that the GSC doesn't show up
anymore.

Review URL: https://chromiumcodereview.appspot.com/10456043

TBR=r...@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10543042
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #29 on issue 129682 by bugdro...@chromium.org: Remove GSG from
showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682#c29

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=140912

------------------------------------------------------------------------
r140912 | r...@chromium.org | Wed Jun 06 17:57:19 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/1084/src/chrome/browser/chromeos/login/existing_user_controller.cc?r1=140912&r2=140911&pathrev=140912

Merge 138996 - Don't show release notes if in Kiosk Mode.

If we're in KioskMode, don't show the release notes/getting started page.

R=dpol...@chromium.org,nkos...@chromium.org
BUG=129682
TEST=Tested with a test image but this is not a complete test, since the
test image wasn't reproing the issue in the first place.


Review URL: https://chromiumcodereview.appspot.com/10446032

TBR=r...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10543043
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #30 on issue 129682 by r...@chromium.org: Remove GSG from showing

in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

Please verify on the next release of 19.
Thanks.

[chro...@googlecode.com]

Updates:
Labels: -feature-kioskmode Feature-KioskMode

Comment #32 on issue 129682 by scunning...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

[chro...@googlecode.com]

Updates:
Status: Assigned

Comment #34 on issue 129682 by scunning...@chromium.org: Remove GSG from

[chro...@googlecode.com]

Comment #37 on issue 129682 by mnis...@chromium.org: Remove GSG from

showing in retail mode.
http://code.google.com/p/chromium/issues/detail?id=129682

FWIW, the people setting up retail machines should have instructions to
reboot after enterprise enrollment.