Issue 126591 in chromium: Broken downloads in metro mode

[chro...@googlecode.com]

Status: Untriaged
Owner: rva...@chromium.org
Labels: Type-Bug Pri-2 Area-Internals Hotlist-Windows8

New issue 126591 by rva...@chromium.org: Broken downloads in metro mode
http://code.google.com/p/chromium/issues/detail?id=126591

Just switch to another metro app, and downloads/uploads brake.

I've been told we already have bugs for this (audio etc), but this specific
use case deserves a separate bug (besides, I didn't find the other bug
reports)

(assigning to myself 'cause I don't know if someone is already working on
this)

[chro...@googlecode.com]

Comment #4 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c4

The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=137960

------------------------------------------------------------------------
r137960 | rva...@google.com | Fri May 18 14:23:08 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor.h?r1=137960&r2=137959&pathrev=137960
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_posix.cc?r1=137960&r2=137959&pathrev=137960
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_android.cc?r1=137960&r2=137959&pathrev=137960
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_win.cc?r1=137960&r2=137959&pathrev=137960
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_unittest.cc?r1=137960&r2=137959&pathrev=137960

Base: Add power requirements to the System monitor.

The only thing we need in the short term is CPU_REQUIRED,
and that part is implemented for all platforms (as far as it
makes sense). The other options are implemented for Windows,
but given that currently there's no user, I expect the
implementation for other platforms to be written when there's
an actual need for it.

BUG=126591
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10406012
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #5 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c5

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=137976

------------------------------------------------------------------------
r137976 | z...@chromium.org | Fri May 18 16:42:54 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor.h?r1=137976&r2=137975&pathrev=137976
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_posix.cc?r1=137976&r2=137975&pathrev=137976
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_android.cc?r1=137976&r2=137975&pathrev=137976
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_win.cc?r1=137976&r2=137975&pathrev=137976
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_unittest.cc?r1=137976&r2=137975&pathrev=137976

Revert 137960 - Base: Add power requirements to the System monitor.

The only thing we need in the short term is CPU_REQUIRED,
and that part is implemented for all platforms (as far as it
makes sense). The other options are implemented for Windows,
but given that currently there's no user, I expect the
implementation for other platforms to be written when there's
an actual need for it.

BUG=126591
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10406012

TBR=rva...@google.com
Review URL: https://chromiumcodereview.appspot.com/10414012
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #6 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c6

[chro...@googlecode.com]

Comment #7 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c7

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=138011

------------------------------------------------------------------------
r138011 | rva...@google.com | Fri May 18 19:10:28 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor.h?r1=138011&r2=138010&pathrev=138011
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_posix.cc?r1=138011&r2=138010&pathrev=138011
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_android.cc?r1=138011&r2=138010&pathrev=138011
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_win.cc?r1=138011&r2=138010&pathrev=138011
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/system_monitor/system_monitor_unittest.cc?r1=138011&r2=138010&pathrev=138011

Base: Add power requirements to the System monitor.

The only thing we need in the short term is CPU_REQUIRED,
and that part is implemented for all platforms (as far as it
makes sense). The other options are implemented for Windows,
but given that currently there's no user, I expect the
implementation for other platforms to be written when there's
an actual need for it.

BUG=126591
TEST=none

Original review: https://chromiumcodereview.appspot.com/10406012/
TBR=brettw
Review URL: https://chromiumcodereview.appspot.com/10389227
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #8 on issue 126591 by gideonw...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591

Hey Ricardo - any update on how things are going here would be awesome when
you have a chance. Thanks!

[chro...@googlecode.com]

Comment #9 on issue 126591 by rva...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591

Sorry about that... I have been distracted by other stuff this week.

The code was ready and working fine in my tests, but the last code reviewer
pointed out something that I didn't see before, and that basically means
that I have to scrap some of the code that I added an integrate it with
other code that we have... I'm not sure if I'll be able to do that this
week, though.

[chro...@googlecode.com]

Comment #10 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c10

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=140664

------------------------------------------------------------------------
r140664 | a...@chromium.org | Tue Jun 05 17:16:52 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker_mac.cc?r1=140664&r2=140663&pathrev=140664

Content: Implement PowerSaveBlocker2 for the Mac.

BUG=126591
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10543009
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #11 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c11

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=140668

------------------------------------------------------------------------
r140668 | rva...@google.com | Tue Jun 05 17:23:57 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker_win.cc?r1=140668&r2=140667&pathrev=140668

Content: Implement PowerSaveBlocker2 for windows.

BUG=126591
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10538013
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #12 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c12

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=141091

------------------------------------------------------------------------
r141091 | rva...@google.com | Thu Jun 07 14:59:14 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker_win.cc?r1=141091&r2=141090&pathrev=141091

Content: fix the power save blocker for Win7.

This code is not yet in use.

BUG=126591
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10542064
------------------------------------------------------------------------

[chro...@googlecode.com]

Comment #13 on issue 126591 by bugdro...@chromium.org: Broken downloads in
metro mode
http://code.google.com/p/chromium/issues/detail?id=126591#c13

The following revision refers to this bug:

http://src.chromium.org/viewvc/chrome?view=rev&revision=141311

------------------------------------------------------------------------
r141311 | m...@chromium.org | Fri Jun 08 15:48:02 PDT 2012

Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker_linux.cc?r1=141311&r2=141310&pathrev=141311
M
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/power_save_blocker.h?r1=141311&r2=141310&pathrev=141311

Implement PowerSaveBlocker2 for Linux. Much simpler than the original!

After this CL is committed, I'll remove all the old code and switch over the
callers. I'll also port the Android version, which is just a stub with a
NOTIMPLEMENTED() in it anyway.

BUG=126591
Review URL: https://chromiumcodereview.appspot.com/10545076
------------------------------------------------------------------------

[chro...@googlecode.com]

Updates:
Status: Assigned

Comment #15 on issue 126591 by m...@chromium.org: Broken downloads in metro
mode
http://code.google.com/p/chromium/issues/detail?id=126591

I assume this is fixed now, but I'll let Ricardo test that it works and
close it.