Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin (Autocomplete...
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  4 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
chrom...@googlecode.com  
View profile   Translate to Translated (View Original)
 More options Jan 12 2012, 7:26 pm
From: chrom...@googlecode.com
Date: Fri, 13 Jan 2012 00:26:50 +0000
Local: Thurs, Jan 12 2012 7:26 pm
Subject: Re: Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocompl ete...

Comment #1 on issue 110105 by pkast...@chromium.org: Chrome: Crash Report  
-         Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

I don't know how GetDeviceCaps(..., LOGPIXELSY) can return 0, but I guess  
there's no harm in bandaiding to just default to 96 in that case.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile   Translate to Translated (View Original)
 More options Jan 12 2012, 10:04 pm
From: chrom...@googlecode.com
Date: Fri, 13 Jan 2012 03:04:20 +0000
Local: Thurs, Jan 12 2012 10:04 pm
Subject: Re: Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocompl ete...

Comment #2 on issue 110105 by pkast...@chromium.org: Chrome: Crash Report  
-         Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

OK, per Carlos, this is likely due to GetDC() returning NULL, which is in  
turn likely due to GDI handle exhaustion or similar.

In this case Chrome is going to behave really badly and the best thing for  
the user is just going to be to force a browser crash.  The current code  
already does that (by accident), but we can make things clearer by  
CHECK()ing the result of GetDC().


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 6:00 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 22:00:39 +0000
Local: Thurs, Jun 7 2012 6:00 pm
Subject: Re: Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocompl ete...
Updates:
        Status: Fixed

Comment #8 on issue 110105 by pkast...@chromium.org: Chrome: Crash Report  
-         Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105

Fixed in r141087.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 6:08 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 22:08:39 +0000
Local: Thurs, Jun 7 2012 6:08 pm
Subject: Re: Issue 110105 in chromium: Chrome: Crash Report - Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocompl ete...
Updates:
        Summary: Chrome: Crash Report -         Stack Signature:  
OmniboxViewWin::OmniboxViewWin(Autocomplete...

Comment #9 on issue 110105 by bugdro...@chromium.org: Chrome: Crash Report  
-         Stack Signature: OmniboxViewWin::OmniboxViewWin(Autocomplete...
http://code.google.com/p/chromium/issues/detail?id=110105#c9

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=141087

------------------------------------------------------------------------
r141087 | pkast...@chromium.org | Thu Jun 07 14:42:23 PDT 2012

Changed paths:
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/ui/vie...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/win/scoped_hdc.h...

Make ScopedGetDC() CHECK fail if GetDC(NULL) returns NULL.

Use scoping objects more in the omnibox code.

BUG=110105
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10545045
------------------------------------------------------------------------


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »