Issue 243590 in chromium: shill: cellular: CellularCapabilityUniversalCdma::OnActivateReply should check for null callback.

[chro...@googlecode.com]

Status: Started
Owner: armans...@chromium.org
CC: benc...@chromium.org, thie...@chromium.org, ppra...@chromium.org,
byr...@chromium.org
Labels: Type-Bug Pri-2 Cr-OS-Systems Iteration-82

New issue 243590 by armans...@chromium.org: shill: cellular:
CellularCapabilityUniversalCdma::OnActivateReply should check for null
callback.
http://code.google.com/p/chromium/issues/detail?id=243590

Invoking the result callback without checking for null causes shill to
crash, as Activate gets invoked with an empty callback as a result of
Service::CompleteCellularActivation.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[chro...@googlecode.com]

Issue 243590: shill: cellular:

CellularCapabilityUniversalCdma::OnActivateReply should check for null
callback.
http://code.google.com/p/chromium/issues/detail?id=243590

This issue is now blocking issue chromium:240017.
See http://code.google.com/p/chromium/issues/detail?id=240017

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

[chro...@googlecode.com]

Comment #2 on issue 243590 by bugdro...@chromium.org: shill: cellular:

CellularCapabilityUniversalCdma::OnActivateReply should check for null
callback.

http://code.google.com/p/chromium/issues/detail?id=243590#c2

Project: chromiumos/platform/shill
Branch : master
Author : Arman Uguray <arma...@chromium.org>
Commit : f2b4a3448a051ec9e9be3027c8e4b79928e026a2

Code Review +2: Ben Chan
Verified +1: Arman Uguray
Change-Id : I6c588498d827f35e5fd3a9ddfc670765a2e44858
Reviewed-at : https://gerrit.chromium.org/gerrit/56550

cellular: Added check for null callback in *UniversalCDMA::OnActivateReply.

Added check for null callback in
CellularCapabilityUniversalCDMA::OnActivateReply.

Additionally, added activation_code entry for Test Network.

BUG=chromium:243590
TEST=Option 1. Activate a CDMA service on an image built with USE="-gobi
qmi".
Check the logs to see that shill hasn't crashed during
activation.
Option 2. Run network_CDMAActivate once it gets checked in. It
should pass.

Commit-Queue: Arman Uguray <arma...@chromium.org>

M cellular_capability_universal_cdma.cc
M data/cellular_operator_info

[chro...@googlecode.com]

Updates:
Status: Fixed

Comment #3 on issue 243590 by armans...@chromium.org: shill: cellular:

CellularCapabilityUniversalCdma::OnActivateReply should check for null
callback.
http://code.google.com/p/chromium/issues/detail?id=243590

(No comment was entered for this change.)