Account Options

  1. Sign in
The old Google Groups will be going away soon, but your browser is incompatible with the new version.
Google Groups Home for chromium.org
« Groups Home
Issue 114517 in chromium: Setting window title resets cursor
There are currently too many topics in this group that display first. To make this topic appear first, remove this option from another topic.
There was an error processing your request. Please try again.
flag
  14 messages - Collapse all  -  Translate all to Translated (View all originals)
The group you are posting to is a Usenet group. Messages posted to this group will make your email address visible to anyone on the Internet.
Your reply message has not been sent.
Your post was successful
 
From:
To:
Cc:
Followup To:
Add Cc | Add Followup-to | Edit Subject
Subject:
Validation:
For verification purposes please type the characters you see in the picture below or the numbers you hear by clicking the accessibility icon. Listen and type the numbers you hear
 
chrom...@googlecode.com  
View profile  
 More options Mar 2 2012, 1:28 pm
From: chrom...@googlecode.com
Date: Fri, 02 Mar 2012 18:28:45 +0000
Local: Fri, Mar 2 2012 1:28 pm
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #13 on issue 114517 by rn...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

This appears to be a WebKit bug. I can reproduce the same issue on WebKit.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Mar 2 2012, 10:13 pm
From: chrom...@googlecode.com
Date: Sat, 03 Mar 2012 03:13:00 +0000
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor
Updates:
        Labels: WebKit-ID-78858

Comment #16 on issue 114517 by a...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

(No comment was entered for this change.)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Mar 2 2012, 11:01 pm
From: chrom...@googlecode.com
Date: Sat, 03 Mar 2012 04:01:15 +0000
Local: Fri, Mar 2 2012 11:01 pm
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor
Updates:
        Labels: -WebKit-ID-78858 WebKit-ID-78858-NEW

Comment #17 on issue 114517 by bugdro...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517#c17

https://bugs.webkit.org/show_bug.cgi?id=78858


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 23 2012, 2:14 am
From: chrom...@googlecode.com
Date: Wed, 23 May 2012 06:14:57 +0000
Local: Wed, May 23 2012 2:14 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor
Updates:
        Owner: domin...@chromium.org

Comment #18 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

(No comment was entered for this change.)


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 23 2012, 4:08 am
From: chrom...@googlecode.com
Date: Wed, 23 May 2012 08:08:37 +0000
Local: Wed, May 23 2012 4:08 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #19 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

I have done some debugging.

First, I believe the second repro ("Disable the timeouts... We now have a  
static webpage.") is a separate issue. I have filed issue 129323 to track  
that.

Regarding setting document.title resetting the cursor; I could repro this  
in Chrome Canary Version 21.0.1147.0 on OS X 10.7.4. I could not repro this  
in WebKit Nightly Version 5.1.6 (7534.56.5, r118039) on OS X 10.7.4. rniwa  
– can you elaborate on "I can reproduce the same issue on WebKit"?

I did some debugging of setting the document title resetting the cursor. I  
believe this is a Chromium-side bug. The cursor is being reset in this  
callstack in Cocoa gubbins:

#0  0x9114363a in -[NSCursor set] ()
#1  0x91142307 in -[NSWindow(NSCarbonExtensions)  
_setCursorForMouseLocation:] ()
#2  0x91135e0b in __-[NSWindow _postInvalidCursorRects]_block_invoke_1 ()
#3  0x92a47ebd in _runLoopObserverWithBlockContext ()
#4  0x92a140ce in  
__CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ ()
#5  0x92a1400d in __CFRunLoopDoObservers ()
#6  0x929e6984 in __CFRunLoopRun ()
#7  0x929e61dc in CFRunLoopRunSpecific ()
#8  0x929e6088 in CFRunLoopRunInMode ()
#9  0x957d1723 in RunCurrentEventLoopInMode ()
#10 0x957d89b6 in ReceiveNextEventCommon ()
#11 0x957d88fa in BlockUntilNextEventMatchingListInMode ()
#12 0x9106c0d8 in _DPSNextEvent ()
#13 0x9106b942 in -[NSApplication  
nextEventMatchingMask:untilDate:inMode:dequeue:] ()
#14 0x91067cb1 in -[NSApplication run] ()

I note that the tab controller is mucking with the NSView hierarchy any  
time the title changes:

#0  0x911893ef in -[NSWindow invalidateCursorRectsForView:] ()
#1  0x91182251 in -[NSView addSubview:] ()
^C#2  0x0532a37d in -[TabController setIconView:] (self=0x6d962ee0,  
_cmd=0x91a4bce2Quit
) at ../../chrome/browser/ui/cocoa/tabs/tab_controller.mm:212
#3  0x05335bb0 in -[TabStripController updateFaviconForContents:atIndex:]  
(self=0x6b952810, _cmd=0x8760f13, contents=0x6f84ace0, modelIndex=0)  
at ../../chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1490
#4  0x05335d47 in -[TabStripController  
tabChangedWithContents:atIndex:changeType:] (self=0x6b952810,  
_cmd=0x8760feb, contents=0x6f84ace0, modelIndex=0,  
change=TabStripModelObserver::ALL)  
at ../../chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:1517
#5  0x05344952 in TabStripModelObserverBridge::TabChangedAt  
(this=0x6b91fe40, contents=0x6f84ace0, index=0,  
change_type=TabStripModelObserver::ALL)  
at ../../chrome/browser/ui/cocoa/tabs/tab_strip_model_observer_bridge.mm:82
#6  0x05457b01 in TabStripModel::UpdateTabContentsStateAt (this=0x1317eac0,  
index=0, change_type=TabStripModelObserver::ALL)  
at ../../chrome/browser/ui/tabs/tab_strip_model.cc:404
#7  0x0514e954 in Browser::ProcessPendingUIUpdates (this=0x13180be0)  
at ../../chrome/browser/ui/browser.cc:4803
#8  0x051606d4 in base::internal::RunnableAdapter<void (Browser::*)()>::Run  
(this=0xc001d3a0, object=0x13180be0) at bind_internal.h:132
#9  0x05160544 in base::internal::InvokeHelper<true, void,  
base::internal::RunnableAdapter<void (Browser::*)()>, void  
()(base::WeakPtr<Browser> const&)>::MakeItSo (runnable={method_ = {ptr =  
85255360, ptr = 0}}, a1=@0x6d9e7d14) at bind_internal.h:880
#10 0x0516046c in base::internal::Invoker<1,  
base::internal::BindState<base::internal::RunnableAdapter<void  
(Browser::*)()>, void ()(Browser*), void ()(base::WeakPtr<Browser>)>, void  
()(Browser*)>::Run (base=0x6d9e7d00) at bind_internal.h:1170
#11 0x027f7adb in base::Callback<void ()()>::Run (this=0xc001d644) at  
callback.h:272
#12 0x027f5318 in MessageLoop::RunTask (this=0x6bc1d5e0,  
pending_task=@0xc001d630) at ../../base/message_loop.cc:463
#13 0x027f56c1 in MessageLoop::DeferOrRunPendingTask (this=0x6bc1d5e0,  
pending_task=@0xc001d630) at ../../base/message_loop.cc:475
#14 0x027f5c78 in MessageLoop::DoDelayedWork (this=0x6bc1d5e0,  
next_delayed_work_time=0xc001d710) at ../../base/message_loop.cc:690
#15 0x027523e8 in base::MessagePumpCFRunLoopBase::RunWork (this=0x6bc1d770)  
at ../../base/message_pump_mac.mm:246
...

I believe this invalidateCursorRectsForView is what is tickling Cocoa to  
mess with the cursor. [NSWindow disableCursorRects] fixes the bug, but it  
CodeSearch indicates that  
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm uses cursor  
rects, so I am not sure if this is a feasible solution.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 24 2012, 5:17 am
From: chrom...@googlecode.com
Date: Thu, 24 May 2012 09:17:09 +0000
Local: Thurs, May 24 2012 5:17 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #20 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

Quick update on this: Since various widgets (extensions splitter, bookmarks  
bar, Omnibox styled text entry, etc.) use cursor rects for changing the  
cursor, this invalidateCursorRectsForView: might be unavoidable. I have  
been experimenting with creating a cursor rect for the entire extent of the  
render widget host view.

This is not working reliably yet; for example, mousing from the bookmarks  
bar over the web view causes the cursor to become an I-beam and the bounds  
of the Omnibox I-beam cursor rect are sometimes also interpreted relative  
to the render widget host view.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 24 2012, 5:21 am
From: chrom...@googlecode.com
Date: Thu, 24 May 2012 09:21:30 +0000
Local: Thurs, May 24 2012 5:21 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #21 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

My impression is that the cursor rect over the extent of the render widget  
host view is pretty solid in release. So I will investigate whether the  
slower message pumping in debug causes the spurious I-beam cursors in debug.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 24 2012, 5:26 am
From: chrom...@googlecode.com
Date: Thu, 24 May 2012 09:26:41 +0000
Local: Thurs, May 24 2012 5:26 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #22 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

WIP patch at <https://chromiumcodereview.appspot.com/10450012>; comments  
welcome.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options May 24 2012, 5:27 am
From: chrom...@googlecode.com
Date: Thu, 24 May 2012 09:27:41 +0000
Local: Thurs, May 24 2012 5:27 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #23 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

WIP patch at https://chromiumcodereview.appspot.com/10450012 ; comments  
welcome.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 1 2012, 1:07 pm
From: chrom...@googlecode.com
Date: Fri, 01 Jun 2012 17:07:41 +0000
Local: Fri, Jun 1 2012 1:07 pm
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor
Updates:
        Labels: -WebKit-ID-78858-NEW WebKit-ID-78858-REOPENED

Comment #24 on issue 114517 by bugdro...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517#c24

https://bugs.webkit.org/show_bug.cgi?id=78858


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 5 2012, 3:40 am
From: chrom...@googlecode.com
Date: Tue, 05 Jun 2012 07:40:51 +0000
Local: Tues, Jun 5 2012 3:40 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #25 on issue 114517 by bugdro...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517#c25

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=140495

------------------------------------------------------------------------
r140495 | domin...@chromium.org | Tue Jun 05 00:35:44 PDT 2012

Changed paths:
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/rende...
  M  
http://src.chromium.org/viewvc/chrome/trunk/src/content/browser/rende...

Apply a CursorRect to the extent of the render widget view for web page  
cursors.

BUG=114517
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10450012
------------------------------------------------------------------------


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 5 2012, 4:19 am
From: chrom...@googlecode.com
Date: Tue, 05 Jun 2012 08:19:46 +0000
Local: Tues, Jun 5 2012 4:19 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #26 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

While working on this I noticed another bug where the cursor is changed as  
a cursor is loaded, even if the mouse is not over the element with that  
cursor. I filed issue 131150 for that. Feedback on whether it is of  
interest welcome.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 6 2012, 11:16 pm
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 03:16:35 +0000
Local: Wed, Jun 6 2012 11:16 pm
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor
Updates:
        Status: Fixed

Comment #27 on issue 114517 by domin...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

I tried this in 21.0.1165.0 canary on OS X 10.7.4 and it is fixed.


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
chrom...@googlecode.com  
View profile  
 More options Jun 7 2012, 11:30 am
From: chrom...@googlecode.com
Date: Thu, 07 Jun 2012 15:30:05 +0000
Local: Thurs, Jun 7 2012 11:30 am
Subject: Re: Issue 114517 in chromium: Setting window title resets cursor

Comment #28 on issue 114517 by komoro...@chromium.org: Setting window title  
resets cursor
http://code.google.com/p/chromium/issues/detail?id=114517

Just confirmed that it is fixed on Canary on Mac.

Thanks, Dominic!


 
You must Sign in before you can post messages.
To post a message you must first join this group.
Please update your nickname on the subscription settings page before posting.
You do not have the permission required to post.
End of messages
« Back to Discussions « Newer topic     Older topic »